From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915: BUG_ON when ggtt_view is NULL Date: Wed, 30 Mar 2016 13:02:33 +0300 Message-ID: <1459332153.5520.1.camel@linux.intel.com> References: <1458834860-7898-1-git-send-email-matthew.auld@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D5DE6E06A for ; Wed, 30 Mar 2016 10:01:53 +0000 (UTC) In-Reply-To: <1458834860-7898-1-git-send-email-matthew.auld@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matthew Auld , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTYtMDMtMjQgYXQgMTU6NTQgKzAwMDAsIE1hdHRoZXcgQXVsZCB3cm90ZToKPiBM ZXRzIEJVR19PTiBhbmQgZG9uJ3QgYm90aGVyIHdpdGggYSBXQVJOIGFuZCByZXR1cm5pbmcgYW4g ZXJyb3IsIHNvIHdlIGNhbgo+IHJlbW92ZSB0aGUgbmVlZCB0byBwb2xsdXRlIHRoZSBjb2RlIHdp dGggZXJyb3IgaGFuZGxpbmcsIGFmdGVyIGFsbCBpdCBpcwo+IGEgcHJvZ3JhbW1lciBlcnJvciB0 byBwcm92aWRlIE5VTEwgdmlldy4gQWxzbyB3aGlsZSB3ZSdyZSBoZXJlIHJlbW92ZQo+IHJlZHVu ZGFudCBOVUxMIGdndHRfdmlldyBjaGVjay4KPiAKPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29u YXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AbGludXguaW50ZWwuY29tPgoKVGhhbmtzIGZvciB0aGUgcGF0Y2gsIEknbGwgbWVy Z2UuCgpSZXZpZXdlZC1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXgu aW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxkQGlu dGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmPCoMKgwqDC oMKgfMKgwqA5ICsrLS0tLS0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0 LmMgfCAxMCArLS0tLS0tLS0tCj4gwqAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggYzdhOTk3 YS4uY2JmNjE2YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC00MjM1LDkgKzQy MzUsNiBAQCBpOTE1X2dlbV9vYmplY3RfZG9fcGluKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvYmosCj4gwqAJdm1hID0gZ2d0dF92aWV3ID8gaTkxNV9nZW1fb2JqX3RvX2dndHRfdmlldyhv YmosIGdndHRfdmlldykgOgo+IMKgCQkJwqDCoGk5MTVfZ2VtX29ial90b192bWEob2JqLCB2bSk7 Cj4gwqAKPiAtCWlmIChJU19FUlIodm1hKSkKPiAtCQlyZXR1cm4gUFRSX0VSUih2bWEpOwo+IC0K PiDCoAlpZiAodm1hKSB7Cj4gwqAJCWlmIChXQVJOX09OKHZtYS0+cGluX2NvdW50ID09IERSTV9J OTE1X0dFTV9PQkpFQ1RfTUFYX1BJTl9DT1VOVCkpCj4gwqAJCQlyZXR1cm4gLUVCVVNZOwo+IEBA IC00MzAwLDggKzQyOTcsNyBAQCBpOTE1X2dlbV9vYmplY3RfZ2d0dF9waW4oc3RydWN0IGRybV9p OTE1X2dlbV9vYmplY3QgKm9iaiwKPiDCoAkJCcKgdWludDMyX3QgYWxpZ25tZW50LAo+IMKgCQkJ wqB1aW50NjRfdCBmbGFncykKPiDCoHsKPiAtCWlmIChXQVJOX09OQ0UoIXZpZXcsICJubyB2aWV3 IHNwZWNpZmllZCIpKQo+IC0JCXJldHVybiAtRUlOVkFMOwo+ICsJQlVHX09OKCF2aWV3KTsKPiDC oAo+IMKgCXJldHVybiBpOTE1X2dlbV9vYmplY3RfZG9fcGluKG9iaiwgaTkxNV9vYmpfdG9fZ2d0 dChvYmopLCB2aWV3LAo+IMKgCQkJCcKgwqDCoMKgwqDCoGFsaWdubWVudCwgZmxhZ3MgfCBQSU5f R0xPQkFMKTsKPiBAQCAtNDYxOCw4ICs0NjE0LDcgQEAgc3RydWN0IGk5MTVfdm1hICppOTE1X2dl bV9vYmpfdG9fZ2d0dF92aWV3KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gwqAJ c3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqZ2d0dCA9IGk5MTVfb2JqX3RvX2dndHQob2JqKTsK PiDCoAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiDCoAo+IC0JaWYgKFdBUk5fT05DRSghdmlldywg Im5vIHZpZXcgc3BlY2lmaWVkIikpCj4gLQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gKwlC VUdfT04oIXZpZXcpOwo+IMKgCj4gwqAJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZvYmotPnZt YV9saXN0LCBvYmpfbGluaykKPiDCoAkJaWYgKHZtYS0+dm0gPT0gZ2d0dCAmJgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gaW5kZXggN2NmYWZkYy4uMDczYzZiYiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTMzNDEsMTUgKzMzNDEsNyBAQCBpOTE1 X2dlbV9vYmpfbG9va3VwX29yX2NyZWF0ZV9nZ3R0X3ZtYShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29i amVjdCAqb2JqLAo+IMKgCQkJCcKgwqDCoMKgwqDCoMKgY29uc3Qgc3RydWN0IGk5MTVfZ2d0dF92 aWV3ICp2aWV3KQo+IMKgewo+IMKgCXN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKmdndHQgPSBp OTE1X29ial90b19nZ3R0KG9iaik7Cj4gLQlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiAtCj4gLQlp ZiAoV0FSTl9PTighdmlldykpCj4gLQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gLQo+IC0J dm1hID0gaTkxNV9nZW1fb2JqX3RvX2dndHRfdmlldyhvYmosIHZpZXcpOwo+IC0KPiAtCWlmIChJ U19FUlIodm1hKSkKPiAtCQlyZXR1cm4gdm1hOwo+ICsJc3RydWN0IGk5MTVfdm1hICp2bWEgPSBp OTE1X2dlbV9vYmpfdG9fZ2d0dF92aWV3KG9iaiwgdmlldyk7Cj4gwqAKPiDCoAlpZiAoIXZtYSkK PiDCoAkJdm1hID0gX19pOTE1X2dlbV92bWFfY3JlYXRlKG9iaiwgZ2d0dCwgdmlldyk7Ci0tIApK b29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9y YXRpb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==