From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH v3 (rebased) 4/4] drm/i915: Add locking to pll updates, v3. Date: Wed, 30 Mar 2016 14:45:23 +0300 Message-ID: <1459338323.2949.3.camel@gmail.com> References: <1457944075-14123-1-git-send-email-maarten.lankhorst@linux.intel.com> <1457944075-14123-5-git-send-email-maarten.lankhorst@linux.intel.com> <1458145178.2596.45.camel@gmail.com> <56E99C52.3080805@linux.intel.com> <1458206173.2706.31.camel@gmail.com> <56F29F50.1090708@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-x244.google.com (mail-pa0-x244.google.com [IPv6:2607:f8b0:400e:c03::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 693246E751 for ; Wed, 30 Mar 2016 11:45:31 +0000 (UTC) Received: by mail-pa0-x244.google.com with SMTP id hj7so5941082pac.1 for ; Wed, 30 Mar 2016 04:45:31 -0700 (PDT) In-Reply-To: <56F29F50.1090708@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE2LTAzLTIzIGF0IDE0OjUxICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBXaXRoIGFzeW5jIG1vZGVzZXRzIHRoaXMgaXMgbm8gbG9uZ2VyIHByb3RlY3RlZCB3aXRo IGNvbm5lY3Rpb25fbXV0ZXgsCj4gc28gZW5zdXJlIHRoYXQgZWFjaCBwbGwgaGFzIGl0cyBvd24g bG9jay4gVGhlIHBsbCBjb25maWd1cmF0aW9uIHN0YXRlCj4gaXMgc3RpbGwgcHJvdGVjdGVkOyBp dCdzIG9ubHkgdGhlIHBsbCB1cGRhdGVzIHRoYXQgbmVlZCBsb2NraW5nIGFnYWluc3QKPiBjb25j dXJyZW5jeS4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gUmViYXNlZC4KPiAtIEZpeCBsb2Nr aW5nIHRvIHByb3RlY3QgYWxsIGFjY2Vzc2VzLiAoRHVyZ2Fkb3NzKQo+IENoYW5nZXMgc2luY2Ug djI6Cj4gLSBNYWtlIHRoZSBkcGxsX2xvY2sgZ2xvYmFsIHRvIHByb3RlY3QgY29uY3VycmVudCB1 cGRhdGVzIHRvIHRoZQo+ICAgc2FtZSByZWdpc3RlciwgZm9yIGV4YW1wbGUgRFBMTF9DVFJMMSBv biBza2wuIChBbmRlcikKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEFuZGVyIENvbnNl bHZhbiBkZSBPbGl2ZWlyYSA8Y29uc2VsdmFuMkBnbWFpbC5jb20+Cgo+IC0tLQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaAo+IGluZGV4IDA2ZTQ3NzNhZTdmNi4uYTY2NzMyNzQ0NDk0IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTE4NTQsNiArMTg1NCwxMyBAQCBzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSB7Cj4gIAlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgc2hhcmVkX2RwbGxz W0k5MTVfTlVNX1BMTFNdOwo+ICAJY29uc3Qgc3RydWN0IGludGVsX2RwbGxfbWdyICpkcGxsX21n cjsKPiAgCj4gKwkvKgo+ICsJICogZHBsbF9sb2NrIHNlcmlhbGl6ZXMgaW50ZWxfe3ByZXBhcmUs ZW5hYmxlLGRpc2FibGV9X3NoYXJlZF9kcGxsLgo+ICsJICogTXVzdCBiZSBnbG9iYWwgcmF0aGVy IHRoYW4gcGVyIGRwbGwsIGJlY2F1c2Ugb24gc29tZSBwbGF0Zm9ybXMKPiArCSAqIHBsbHMgc2hh cmUgcmVnaXN0ZXJzLgo+ICsJICovCj4gKwlzdHJ1Y3QgbXV0ZXggZHBsbF9sb2NrOwo+ICsKPiAg CXVuc2lnbmVkIGludCBhY3RpdmVfY3J0Y3M7Cj4gIAl1bnNpZ25lZCBpbnQgbWluX3BpeGNsa1tJ OTE1X01BWF9QSVBFU107Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcGxsX21nci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5j Cj4gaW5kZXggMTliZmU2NzQzZWYyLi4xMTc1ZWViZmUwM2IgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwbGxfbWdyLmMKPiBAQCAtODksMTQgKzg5LDE2IEBAIHZvaWQgaW50ZWxfcHJl cGFyZV9zaGFyZWRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCWlmIChXQVJOX09O KHBsbCA9PSBOVUxMKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICsJbXV0ZXhfbG9jaygmZGV2X3ByaXYt PmRwbGxfbG9jayk7Cj4gIAlXQVJOX09OKCFwbGwtPmNvbmZpZy5jcnRjX21hc2spOwo+IC0JaWYg KHBsbC0+YWN0aXZlX21hc2sgPT0gMCkgewo+ICsJaWYgKCFwbGwtPmFjdGl2ZV9tYXNrKSB7Cj4g IAkJRFJNX0RFQlVHX0RSSVZFUigic2V0dGluZyB1cCAlc1xuIiwgcGxsLT5uYW1lKTsKPiAgCQlX QVJOX09OKHBsbC0+b24pOwo+ICAJCWFzc2VydF9zaGFyZWRfZHBsbF9kaXNhYmxlZChkZXZfcHJp diwgcGxsKTsKPiAgCj4gIAkJcGxsLT5mdW5jcy5tb2RlX3NldChkZXZfcHJpdiwgcGxsKTsKPiAg CX0KPiArCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4gIH0KPiAgCj4gIC8q Kgo+IEBAIC0xMTMsMTQgKzExNSwxNyBAQCB2b2lkIGludGVsX2VuYWJsZV9zaGFyZWRfZHBsbChz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBs bCA9IGNydGMtPmNvbmZpZy0+c2hhcmVkX2RwbGw7Cj4gIAl1bnNpZ25lZCBjcnRjX21hc2sgPSAx IDw8IGRybV9jcnRjX2luZGV4KCZjcnRjLT5iYXNlKTsKPiAtCXVuc2lnbmVkIG9sZF9tYXNrID0g cGxsLT5hY3RpdmVfbWFzazsKPiArCXVuc2lnbmVkIG9sZF9tYXNrOwo+ICAKPiAgCWlmIChXQVJO X09OKHBsbCA9PSBOVUxMKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICsJbXV0ZXhfbG9jaygmZGV2X3By aXYtPmRwbGxfbG9jayk7Cj4gKwlvbGRfbWFzayA9IHBsbC0+YWN0aXZlX21hc2s7Cj4gKwo+ICAJ aWYgKFdBUk5fT04oIShwbGwtPmNvbmZpZy5jcnRjX21hc2sgJiBjcnRjX21hc2spKSB8fAo+ICAJ ICAgIFdBUk5fT04ocGxsLT5hY3RpdmVfbWFzayAmIGNydGNfbWFzaykpCj4gLQkJcmV0dXJuOwo+ ICsJCWdvdG8gb3V0Owo+ICAKPiAgCXBsbC0+YWN0aXZlX21hc2sgfD0gY3J0Y19tYXNrOwo+ICAK PiBAQCAtMTMxLDEzICsxMzYsMTYgQEAgdm9pZCBpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwoc3Ry dWN0IGludGVsX2NydGMgKmNydGMpCj4gIAlpZiAob2xkX21hc2spIHsKPiAgCQlXQVJOX09OKCFw bGwtPm9uKTsKPiAgCQlhc3NlcnRfc2hhcmVkX2RwbGxfZW5hYmxlZChkZXZfcHJpdiwgcGxsKTsK PiAtCQlyZXR1cm47Cj4gKwkJZ290byBvdXQ7Cj4gIAl9Cj4gIAlXQVJOX09OKHBsbC0+b24pOwo+ ICAKPiAgCURSTV9ERUJVR19LTVMoImVuYWJsaW5nICVzXG4iLCBwbGwtPm5hbWUpOwo+ICAJcGxs LT5mdW5jcy5lbmFibGUoZGV2X3ByaXYsIHBsbCk7Cj4gIAlwbGwtPm9uID0gdHJ1ZTsKPiArCj4g K291dDoKPiArCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4gIH0KPiAgCj4g IHZvaWQgaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykK PiBAQCAtMTU0LDggKzE2Miw5IEBAIHZvaWQgaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCWlmIChwbGwgPT0gTlVMTCkKPiAgCQlyZXR1cm47Cj4g IAo+ICsJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4gIAlpZiAoV0FSTl9PTigh KHBsbC0+YWN0aXZlX21hc2sgJiBjcnRjX21hc2spKSkKPiAtCQlyZXR1cm47Cj4gKwkJZ290byBv dXQ7Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygiZGlzYWJsZSAlcyAoYWN0aXZlICV4LCBvbj8gJWQp IGZvciBjcnRjICVkXG4iLAo+ICAJCSAgICAgIHBsbC0+bmFtZSwgcGxsLT5hY3RpdmVfbWFzaywg cGxsLT5vbiwKPiBAQCAtMTY2LDExICsxNzUsMTQgQEAgdm9pZCBpbnRlbF9kaXNhYmxlX3NoYXJl ZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAKPiAgCXBsbC0+YWN0aXZlX21hc2sg Jj0gfmNydGNfbWFzazsKPiAgCWlmIChwbGwtPmFjdGl2ZV9tYXNrKQo+IC0JCXJldHVybjsKPiAr CQlnb3RvIG91dDsKPiAgCj4gIAlEUk1fREVCVUdfS01TKCJkaXNhYmxpbmcgJXNcbiIsIHBsbC0+ bmFtZSk7Cj4gIAlwbGwtPmZ1bmNzLmRpc2FibGUoZGV2X3ByaXYsIHBsbCk7Cj4gIAlwbGwtPm9u ID0gZmFsc2U7Cj4gKwo+ICtvdXQ6Cj4gKwltdXRleF91bmxvY2soJmRldl9wcml2LT5kcGxsX2xv Y2spOwo+ICB9Cj4gIAo+ICBzdGF0aWMgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICoKPiBAQCAt MTc1MCw2ICsxNzYyLDcgQEAgdm9pZCBpbnRlbF9zaGFyZWRfZHBsbF9pbml0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCj4gIAo+ICAJZGV2X3ByaXYtPmRwbGxfbWdyID0gZHBsbF9tZ3I7Cj4gIAlk ZXZfcHJpdi0+bnVtX3NoYXJlZF9kcGxsID0gaTsKPiArCW11dGV4X2luaXQoJmRldl9wcml2LT5k cGxsX2xvY2spOwo+ICAKPiAgCUJVR19PTihkZXZfcHJpdi0+bnVtX3NoYXJlZF9kcGxsID4gSTkx NV9OVU1fUExMUyk7Cj4gIAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK