From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v4 1/2] drm/i915: Protect fbdev across slow or failed initialisation Date: Thu, 31 Mar 2016 19:05:21 +0300 Message-ID: <1459440321.8191.17.camel@linux.intel.com> References: <56FD1151.5050303@intel.com> <1459432663-990-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id EB76A6E24E for ; Thu, 31 Mar 2016 16:04:39 +0000 (UTC) In-Reply-To: <1459432663-990-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Gabriel Feceoru List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTYtMDMtMzEgYXQgMTQ6NTcgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJ ZiB0aGUgaW5pdGlhbGlzYXRpb24gZmFpbHMsIHdlIG1heSBiZSBsZWZ0IHdpdGggYSBkYW5nbGlu ZyBwb2ludGVyIHdpdGgKPiBhbiBpbmNvbXBsZXRlIGZiZGV2IHN0cnVjdHVyZS4gSGVyZSB3ZSB3 YW50IHRvIGRpc2FibGUgaW50ZXJuYWwgY2FsbHMKPiBpbnRvIGZiZGV2LiBTaW1pbGFybHksIHRo ZSBpbml0aWFsaXNhdGlvbiBtYXkgYmUgc2xvdyBhbmQgd2UgaGF2ZW4ndCB5ZXQKPiBlbmFibGVk IHRoZSBmYmRldiAoZS5nLiBxdWljayBzdXNwZW5kIG9yIGxhc3QtY2xvc2UgYmVmb3JlIHRoZSBh c3luYyBpbml0Cj4gY29tcGxldGVzKS4KPiAKPiB2MzogVG8gY3JlYXRlIGEgdHlwbyBpbnRyb2R1 Y2VkIHdoZW4gcmV0eXBpbmcKPiB2NDogUHJldmVudCBpbmZvPT1OVUxMIGRlcmVmZXJlbmNlIGlu IGVhcmx5IGJvb3QKPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTM1ODAKPiBSZXBvcnRlZC1ieTogIkxpLCBXZWluYW4gWiIgPHdlaW5h bi56LmxpQGludGVsLmNvbT4KPiBUZXN0ZWQtYnk6IEdhYnJpZWwgRmVjZW9ydSA8Z2FicmllbC5m ZWNlb3J1QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zi ZGV2LmMgfCA3MiArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+IMKgMSBm aWxlIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IGluZGV4IDE1M2VhN2EzZmNmNi4uNWQ0YmU3MWJkZjIy IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gQEAgLTc1NiwxNyArNzU2LDQ3 IEBAIHZvaWQgaW50ZWxfZmJkZXZfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IMKgCWRl dl9wcml2LT5mYmRldiA9IE5VTEw7Cj4gwqB9Cj4gwqAKPiArc3RhdGljIHN0cnVjdCBpbnRlbF9m YmRldiAqaW50ZWxfZmJkZXZfZ2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVj dCBmYl9pbmZvICppbmZvOwo+ICsKPiArCWlmIChkZXZfcHJpdi0+ZmJkZXYgPT0gTlVMTCkKPiAr CQlyZXR1cm4gTlVMTDsKPiArCj4gKwlpbmZvID0gZGV2X3ByaXYtPmZiZGV2LT5oZWxwZXIuZmJk ZXY7Cj4gKwlpZiAoaW5mbyA9PSBOVUxMKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCWlmIChp bmZvLT5zY3JlZW5fYmFzZSA9PSBOVUxMKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKClRoaXMgaXMg cmF0aGVyIHZlcmJvc2UgdG8gbXkgbGlraW5nLCBJJ2QgcmF0aGVyIGJlIGRyb3BwaW5nIHRob3Nl ICc9PQpOVUxMJyBhbmQgY29udmVydCB0byAhLiBCdXQgZWl0aGVyIHdheSB0byBtZS4KCj4gKwly ZXR1cm4gZGV2X3ByaXYtPmZiZGV2Owo+ICt9Cj4gKwo+ICtzdGF0aWMgc3RydWN0IGludGVsX2Zi ZGV2ICppbnRlbF9mYmRldl9nZXRfaWZfYWN0aXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g K3sKPiArCXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2Owo+ICsKPiArCWlmYmRldiA9IGludGVs X2ZiZGV2X2dldChkZXYpOwo+ICsJaWYgKGlmYmRldiA9PSBOVUxMKQo+ICsJCXJldHVybiBOVUxM Owo+ICsKPiArCWlmIChpZmJkZXYtPmhlbHBlci5mYmRldi0+c3RhdGUgIT0gRkJJTkZPX1NUQVRF X1JVTk5JTkcpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJcmV0dXJuIGlmYmRldjsKPiArfQo+ ICsKPiDCoHZvaWQgaW50ZWxfZmJkZXZfc2V0X3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgaW50IHN0YXRlLCBib29sIHN5bmNocm9ub3VzKQo+IMKgewo+IMKgCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gLQlzdHJ1Y3QgaW50ZWxf ZmJkZXYgKmlmYmRldiA9IGRldl9wcml2LT5mYmRldjsKPiAtCXN0cnVjdCBmYl9pbmZvICppbmZv Owo+ICsJc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXY7Cj4gwqAKPiAtCWlmICghaWZiZGV2KQo+ ICsJaWZiZGV2ID0gaW50ZWxfZmJkZXZfZ2V0KGRldik7Cj4gKwlpZiAoaWZiZGV2ID09IE5VTEwp Cj4gwqAJCXJldHVybjsKPiDCoAo+IC0JaW5mbyA9IGlmYmRldi0+aGVscGVyLmZiZGV2Owo+IC0K PiDCoAlpZiAoc3luY2hyb25vdXMpIHsKPiDCoAkJLyogRmx1c2ggYW55IHBlbmRpbmcgd29yayB0 byB0dXJuIHRoZSBjb25zb2xlIG9uLCBhbmQgdGhlbgo+IMKgCQnCoCogd2FpdCB0byB0dXJuIGl0 IG9mZi4gSXQgbXVzdCBiZSBzeW5jaHJvbm91cyBhcyB3ZSBhcmUKPiBAQCAtNzk4LDggKzgyOCwx MCBAQCB2b2lkIGludGVsX2ZiZGV2X3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IGludCBzdGF0ZSwgYm9vbCBzeW5jaHJvbm91cwo+IMKgCcKgKiBiZWVuIHJlc3RvcmVkIGZyb20g c3dhcC4gSWYgdGhlIG9iamVjdCBpcyBzdG9sZW4gaG93ZXZlciwgaXQgd2lsbCBiZQo+IMKgCcKg KiBmdWxsIG9mIHdoYXRldmVyIGdhcmJhZ2Ugd2FzIGxlZnQgaW4gdGhlcmUuCj4gwqAJwqAqLwo+ IC0JaWYgKHN0YXRlID09IEZCSU5GT19TVEFURV9SVU5OSU5HICYmIGlmYmRldi0+ZmItPm9iai0+ c3RvbGVuKQo+ICsJaWYgKHN0YXRlID09IEZCSU5GT19TVEFURV9SVU5OSU5HICYmIGlmYmRldi0+ ZmItPm9iai0+c3RvbGVuKSB7Cj4gKwkJc3RydWN0IGZiX2luZm8gKmluZm8gPSBpZmJkZXYtPmhl bHBlci5mYmRldjsKPiDCoAkJbWVtc2V0X2lvKGluZm8tPnNjcmVlbl9iYXNlLCAwLCBpbmZvLT5z Y3JlZW5fc2l6ZSk7Cj4gKwl9Cj4gwqAKPiDCoAlkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kKCZp ZmJkZXYtPmhlbHBlciwgc3RhdGUpOwo+IMKgCWNvbnNvbGVfdW5sb2NrKCk7Cj4gQEAgLTgwNywz MiArODM5LDI0IEBAIHZvaWQgaW50ZWxfZmJkZXZfc2V0X3N1c3BlbmQoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgaW50IHN0YXRlLCBib29sIHN5bmNocm9ub3VzCj4gwqAKPiDCoHZvaWQgaW50ZWxf ZmJkZXZfb3V0cHV0X3BvbGxfY2hhbmdlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IMKgewo+ IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsK PiArCXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0gaW50ZWxfZmJkZXZfZ2V0X2lmX2FjdGl2 ZShkZXYpOwo+ICsKPiArCWlmIChpZmJkZXYgPT0gTlVMTCkKPiArCQlyZXR1cm47Cj4gwqAKPiAt CWFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKTsKPiAtCWlmIChkZXZfcHJpdi0+ZmJkZXYpCj4gLQkJ ZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50KCZkZXZfcHJpdi0+ZmJkZXYtPmhlbHBlcik7Cj4g Kwlkcm1fZmJfaGVscGVyX2hvdHBsdWdfZXZlbnQoJmlmYmRldi0+aGVscGVyKTsKPiDCoH0KPiDC oAo+IMKgdm9pZCBpbnRlbF9mYmRldl9yZXN0b3JlX21vZGUoc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiDCoHsKPiAtCWludCByZXQ7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IC0Jc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPSBk ZXZfcHJpdi0+ZmJkZXY7Cj4gLQlzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyOwo+ICsJ c3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPSBpbnRlbF9mYmRldl9nZXRfaWZfYWN0aXZlKGRl dik7Cj4gwqAKPiAtCWFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKTsKCldoYXQncyB3aXRoIHRoZSBh c3luY19zeW5jaHJvbml6ZV9mdWxsKCkgYmVnaW4gcmVtb3ZlZCBjb21wbGV0ZWx5PwoKPiAtCWlm ICghaWZiZGV2KQo+ICsJaWYgKGlmYmRldiA9PSBOVUxMKQoKQXJnaC4KCj4gwqAJCXJldHVybjsK PiDCoAo+IC0JZmJfaGVscGVyID0gJmlmYmRldi0+aGVscGVyOwo+IC0KPiAtCXJldCA9IGRybV9m Yl9oZWxwZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKGZiX2hlbHBlcik7Cj4gLQlpZiAo cmV0KSB7Cj4gLQkJRFJNX0RFQlVHKCJmYWlsZWQgdG8gcmVzdG9yZSBjcnRjIG1vZGVcbiIpOwo+ IC0JfSBlbHNlIHsKPiAtCQltdXRleF9sb2NrKCZmYl9oZWxwZXItPmRldi0+c3RydWN0X211dGV4 KTsKPiArCWlmIChkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZCgmaWZi ZGV2LT5oZWxwZXIpID09IDApIHsKPiArCQltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7 Cj4gwqAJCWludGVsX2ZiX29ial9pbnZhbGlkYXRlKGlmYmRldi0+ZmItPm9iaiwgT1JJR0lOX0dU VCk7Cj4gLQkJbXV0ZXhfdW5sb2NrKCZmYl9oZWxwZXItPmRldi0+c3RydWN0X211dGV4KTsKPiAr CQltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKCkFib3ZlIGFkZHJlc3NlZCwKClJl dmlld2VkLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5j b20+Cgo+IMKgCX0KPiDCoH0KLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBUZWNobm9s b2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK