From: Imre Deak <imre.deak@intel.com>
To: Dongwon Kim <dongwon.kim@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
Date: Mon, 11 Apr 2016 13:00:25 +0300 [thread overview]
Message-ID: <1460368825.12168.1.camel@intel.com> (raw)
In-Reply-To: <1458176773-26925-1-git-send-email-dongwon.kim@intel.com>
On ke, 2016-03-16 at 18:06 -0700, Dongwon Kim wrote:
> For BXT, description of polarities of PORT_PLL_REF_SEL
> has been reversed for newer Gen9LP steppings according to the
> recent update in Bspec. This bit now should be set for
> "Non-SSC" mode for all Gen9LP starting from B0 stepping.
>
> v2: Only B0 and newer stepping should be affected by this
> change.
>
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94866
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 4b636c4..c84589e 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -1285,7 +1285,15 @@ static void bxt_ddi_pll_enable(struct
> drm_i915_private *dev_priv,
> enum port port = (enum port)pll->id; /* 1:1 port->PLL
> mapping */
>
> temp = I915_READ(BXT_PORT_PLL_ENABLE(port));
> - temp &= ~PORT_PLL_REF_SEL;
> + /*
> + * Definition of each bit polarity has been changed
> + * after A1 stepping
> + */
> + if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
> + temp &= ~PORT_PLL_REF_SEL;
> + else
> + temp |= PORT_PLL_REF_SEL;
> +
> /* Non-SSC reference */
> I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-11 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 23:37 [PATCH] drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit Dongwon Kim
2016-03-16 9:01 ` Imre Deak
2016-03-16 11:58 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-16 16:58 ` dw kim
2016-03-17 1:06 ` [PATCH] " Dongwon Kim
2016-03-22 9:10 ` Imre Deak
2016-03-22 17:33 ` dw kim
2016-04-11 10:00 ` Imre Deak [this message]
2016-03-17 13:03 ` ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2) Patchwork
2016-03-17 18:05 ` dw kim
2016-04-11 10:10 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460368825.12168.1.camel@intel.com \
--to=imre.deak@intel.com \
--cc=dongwon.kim@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox