From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/opregion: remove unnecessary ifdefs on CONFIG_ACPI
Date: Tue, 12 Apr 2016 13:33:35 +0300 [thread overview]
Message-ID: <1460457215.2697.0.camel@gmail.com> (raw)
In-Reply-To: <1460127589-8357-1-git-send-email-jani.nikula@intel.com>
On Fri, 2016-04-08 at 17:59 +0300, Jani Nikula wrote:
> The whole file is ignored on CONFIG_ACPI=n.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 6 ------
> 1 file changed, 6 deletions(-)
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c
> b/drivers/gpu/drm/i915/intel_opregion.c
> index c15718b4862a..d5a4cb80273e 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -246,7 +246,6 @@ struct opregion_asle_ext {
>
> #define MAX_DSLP 1500
>
> -#ifdef CONFIG_ACPI
> static int swsci(struct drm_device *dev, u32 function, u32 parm, u32
> *parm_out)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
> @@ -905,9 +904,6 @@ static void swsci_setup(struct drm_device *dev)
> opregion->swsci_gbda_sub_functions,
> opregion->swsci_sbcb_sub_functions);
> }
> -#else /* CONFIG_ACPI */
> -static inline void swsci_setup(struct drm_device *dev) {}
> -#endif /* CONFIG_ACPI */
>
> static int intel_no_opregion_vbt_callback(const struct dmi_system_id *id)
> {
> @@ -950,9 +946,7 @@ int intel_opregion_setup(struct drm_device *dev)
> return -ENOTSUPP;
> }
>
> -#ifdef CONFIG_ACPI
> INIT_WORK(&opregion->asle_work, asle_work);
> -#endif
>
> base = memremap(asls, OPREGION_SIZE, MEMREMAP_WB);
> if (!base)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-12 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 14:59 [PATCH] drm/i915/opregion: remove unnecessary ifdefs on CONFIG_ACPI Jani Nikula
2016-04-08 15:55 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-12 10:33 ` Ander Conselvan De Oliveira [this message]
2016-04-12 10:36 ` [PATCH] " Chris Wilson
2016-04-12 12:20 ` Jani Nikula
2016-04-13 13:01 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460457215.2697.0.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox