From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: call kunmap_px on pt_vaddr
Date: Mon, 18 Apr 2016 16:26:11 +0300 [thread overview]
Message-ID: <1460985971.6027.15.camel@linux.intel.com> (raw)
In-Reply-To: <1460476663-24890-4-git-send-email-matthew.auld@intel.com>
On ti, 2016-04-12 at 16:57 +0100, Matthew Auld wrote:
> We need to kunmap pt_vaddr and not pt itself, otherwise we end up
> mapping a bunch of pages without ever unmapping them.
>
It's always a good idea to use 'git blame' to figure out the bug
inducing commit, and include that information + CC'ing the author (Mika
here):
Fixes: d1c54acd67dc ("drm/i915/gtt: Introduce kmap|kunmap for dma page")
With that added,
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mika to comment on too, looks like fairly straightforward error when
doing a mass replace.
Regards, Joonas
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 6601b11..7aef7bf 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -746,7 +746,7 @@ static void gen8_ppgtt_clear_pte_range(struct i915_address_space *vm,
> num_entries--;
> }
>
> - kunmap_px(ppgtt, pt);
> + kunmap_px(ppgtt, pt_vaddr);
>
> pte = 0;
> if (++pde == I915_PDES) {
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-18 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 15:57 [PATCH 1/5] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt Matthew Auld
2016-04-12 15:57 ` [PATCH 2/5] drm/i915: harden allocation paths in allocate_va_range Matthew Auld
2016-04-18 13:13 ` Joonas Lahtinen
2016-04-12 15:57 ` [PATCH 3/5] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT Matthew Auld
2016-04-18 13:19 ` Joonas Lahtinen
2016-04-12 15:57 ` [PATCH 4/5] drm/i915: call kunmap_px on pt_vaddr Matthew Auld
2016-04-18 13:26 ` Joonas Lahtinen [this message]
2016-04-19 14:28 ` Mika Kuoppala
2016-04-12 15:57 ` [PATCH 5/5] drm/i915: Propagate error from drm_gem_object_init() Matthew Auld
2016-04-19 11:45 ` Joonas Lahtinen
2016-04-13 14:39 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt Patchwork
2016-04-18 12:51 ` [PATCH 1/5] " Joonas Lahtinen
2016-04-18 13:11 ` Chris Wilson
2016-04-18 13:28 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460985971.6027.15.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).