From: Imre Deak <imre.deak@intel.com>
To: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>,
Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/kbl: Reset secondary power well requests left on by DMC/KVMR
Date: Mon, 18 Apr 2016 20:31:31 +0300 [thread overview]
Message-ID: <1461000691.3172.63.camel@intel.com> (raw)
In-Reply-To: <20160418081547.GA26680@patrik-desktop.isw.intel.com>
On ma, 2016-04-18 at 10:15 +0200, Patrik Jakobsson wrote:
> On Fri, Apr 15, 2016 at 10:32:58PM +0300, Imre Deak wrote:
> > The workaround added in c6782b76d31a ("drm/i915/gen9: Reset
> > secondary power
> > well requests left on by DMC/KVMR") needs to be applied on Kabylake
> > too as
> > shown by the corresponding timeout errors about power well 1 and
> > MISC IO
> > power well disabling in the latest CI run.
> >
> > CC: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> Ok, so this seems to affect all DMC firmwares we have so far? Any
> news on the
> bug report?
>
> Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
I pushed this to -dinq thanks for the review.
Jani, Daniel: I made a mistake pushing this before getting the CI
result. It wasn't either picked up by PW, so not sure about its status.
What can we do, revert/resubmit or wait for the next regular CI result?
Sorry for the mess,
Imre
> > ---
> > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index 259f66f..1242fb5 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -709,7 +709,7 @@ static void skl_set_power_well(struct
> > drm_i915_private *dev_priv,
> > DRM_DEBUG_KMS("Disabling %s\n",
> > power_well->name);
> > }
> >
> > - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > + if (IS_GEN9(dev_priv))
> > gen9_sanitize_power_well_requests(dev_priv
> > , power_well);
> > }
> >
> > --
> > 2.5.0
> >
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-04-18 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 19:32 [PATCH] drm/i915/kbl: Reset secondary power well requests left on by DMC/KVMR Imre Deak
2016-04-18 8:15 ` Patrik Jakobsson
2016-04-18 8:19 ` Imre Deak
2016-04-18 17:31 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461000691.3172.63.camel@intel.com \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=patrik.jakobsson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox