* [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown
@ 2016-04-22 13:03 Chris Wilson
2016-04-22 13:04 ` Daniel Vetter
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2016-04-22 13:03 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
When tearing down the device, emit a warning if there are any contexts
remaining, as they all should be freed by this point.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_context.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index e5acc3916f75..82339b45cc9b 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -437,6 +437,8 @@ void i915_gem_context_fini(struct drm_device *dev)
i915_gem_context_unreference(dctx);
dev_priv->kernel_context = NULL;
+
+ WARN_ON(!list_empty(&dev_priv->context_list));
}
int i915_gem_context_enable(struct drm_i915_gem_request *req)
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown
2016-04-22 13:03 [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown Chris Wilson
@ 2016-04-22 13:04 ` Daniel Vetter
2016-04-22 13:25 ` Joonas Lahtinen
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2016-04-22 13:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Mika Kuoppala
On Fri, Apr 22, 2016 at 02:03:02PM +0100, Chris Wilson wrote:
> When tearing down the device, emit a warning if there are any contexts
> remaining, as they all should be freed by this point.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
I guess it fires already, or not? Either way, this /should/ hold true.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_gem_context.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index e5acc3916f75..82339b45cc9b 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -437,6 +437,8 @@ void i915_gem_context_fini(struct drm_device *dev)
>
> i915_gem_context_unreference(dctx);
> dev_priv->kernel_context = NULL;
> +
> + WARN_ON(!list_empty(&dev_priv->context_list));
> }
>
> int i915_gem_context_enable(struct drm_i915_gem_request *req)
> --
> 2.8.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown
2016-04-22 13:03 [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown Chris Wilson
2016-04-22 13:04 ` Daniel Vetter
@ 2016-04-22 13:25 ` Joonas Lahtinen
2016-04-22 14:33 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-24 8:23 ` ✓ Fi.CI.BAT: success " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2016-04-22 13:25 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Mika Kuoppala
On pe, 2016-04-22 at 14:03 +0100, Chris Wilson wrote:
> When tearing down the device, emit a warning if there are any contexts
> remaining, as they all should be freed by this point.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_context.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index e5acc3916f75..82339b45cc9b 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -437,6 +437,8 @@ void i915_gem_context_fini(struct drm_device *dev)
>
> i915_gem_context_unreference(dctx);
> dev_priv->kernel_context = NULL;
> +
> + WARN_ON(!list_empty(&dev_priv->context_list));
> }
>
> int i915_gem_context_enable(struct drm_i915_gem_request *req)
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Warn there are any unfreed contexts when we shutdown
2016-04-22 13:03 [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown Chris Wilson
2016-04-22 13:04 ` Daniel Vetter
2016-04-22 13:25 ` Joonas Lahtinen
@ 2016-04-22 14:33 ` Patchwork
2016-04-24 8:23 ` ✓ Fi.CI.BAT: success " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-04-22 14:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Warn there are any unfreed contexts when we shutdown
URL : https://patchwork.freedesktop.org/series/6157/
State : failure
== Summary ==
Series 6157v1 drm/i915: Warn there are any unfreed contexts when we shutdown
http://patchwork.freedesktop.org/api/1.0/series/6157/revisions/1/mbox/
Test drv_module_reload_basic:
pass -> FAIL (snb-dellxps)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> SKIP (hsw-brixbox)
bdw-nuci7 total:193 pass:181 dwarn:0 dfail:0 fail:0 skip:12
bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39
byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38
hsw-brixbox total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
hsw-gt2 total:193 pass:174 dwarn:0 dfail:0 fail:0 skip:19
ilk-hp8440p total:193 pass:136 dwarn:0 dfail:0 fail:0 skip:57
ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28
skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:193 pass:154 dwarn:0 dfail:0 fail:1 skip:38
snb-x220t total:193 pass:155 dwarn:0 dfail:0 fail:1 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_1995/
43973a44fd376caef9419c7abb460b47520a1734 drm-intel-nightly: 2016y-04m-22d-13h-33m-45s UTC integration manifest
5be4c17 drm/i915: Warn there are any unfreed contexts when we shutdown
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Warn there are any unfreed contexts when we shutdown
2016-04-22 13:03 [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown Chris Wilson
` (2 preceding siblings ...)
2016-04-22 14:33 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-04-24 8:23 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-04-24 8:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Warn there are any unfreed contexts when we shutdown
URL : https://patchwork.freedesktop.org/series/6157/
State : success
== Summary ==
Series 6157v1 drm/i915: Warn there are any unfreed contexts when we shutdown
http://patchwork.freedesktop.org/api/1.0/series/6157/revisions/1/mbox/
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (ilk-hp8440p) UNSTABLE
bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23
bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39
byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38
ilk-hp8440p total:193 pass:135 dwarn:0 dfail:0 fail:1 skip:57
ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28
skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25
skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:193 pass:155 dwarn:0 dfail:0 fail:0 skip:38
Results at /archive/results/CI_IGT_test/Patchwork_2032/
340c485ad98d0ec0369a3b18d4a09938f3f5537d drm-intel-nightly: 2016y-04m-22d-17h-32m-25s UTC integration manifest
d3a52c0 drm/i915: Warn there are any unfreed contexts when we shutdown
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-24 8:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-22 13:03 [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown Chris Wilson
2016-04-22 13:04 ` Daniel Vetter
2016-04-22 13:25 ` Joonas Lahtinen
2016-04-22 14:33 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-24 8:23 ` ✓ Fi.CI.BAT: success " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).