public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: robert.foss@collabora.com
To: marius.vlad@intel.com, daniel.vetter@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t v2 2/6] kms_panel_fitting: Remove un-read variable pipe_crc.
Date: Mon, 25 Apr 2016 10:35:47 -0400	[thread overview]
Message-ID: <1461594951-27706-3-git-send-email-robert.foss@collabora.com> (raw)
In-Reply-To: <1461594951-27706-1-git-send-email-robert.foss@collabora.com>

From: Robert Foss <robert.foss@collabora.com>

pipe_crc in data_t is assigned an allocated memory space and
then later free'd. But it is never used for any comparisons.
It should therefore be safe to remove pipe_crc and the crc
requirement.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 tests/kms_panel_fitting.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 43ad770..7bfd980 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -32,7 +32,6 @@ typedef struct {
 	int drm_fd;
 	igt_display_t display;
 	igt_crc_t ref_crc;
-	igt_pipe_crc_t *pipe_crc;
 
 	int image_w;
 	int image_h;
@@ -59,10 +58,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
 
 	igt_output_set_pipe(output, pipe);
 
-	/* create the pipe_crc object for this pipe */
-	igt_pipe_crc_free(data->pipe_crc);
-	data->pipe_crc = igt_pipe_crc_new(pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
-
 	/* before allocating, free if any older fb */
 	if (data->fb_id1) {
 		igt_remove_fb(data->drm_fd, &data->fb1);
@@ -109,9 +104,6 @@ static void cleanup_crtc(data_t *data, igt_output_t *output, igt_plane_t *plane)
 {
 	igt_display_t *display = &data->display;
 
-	igt_pipe_crc_free(data->pipe_crc);
-	data->pipe_crc = NULL;
-
 	if (data->fb_id1) {
 		igt_remove_fb(data->drm_fd, &data->fb1);
 		data->fb_id1 = 0;
@@ -222,7 +214,6 @@ igt_simple_main
 	igt_skip_on_simulation();
 
 	data.drm_fd = drm_open_driver(DRIVER_INTEL);
-	igt_require_pipe_crc();
 	igt_display_init(&data.display, data.drm_fd);
 
 	test_panel_fitting(&data);
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-04-25 14:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 14:35 [PATCH i-g-t v2 0/6] Improve kms_panel_fitting robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 1/6] kms_panel_fitting: Remove un-read variable robert.foss
2016-04-25 14:35 ` robert.foss [this message]
2016-04-25 14:35 ` [PATCH i-g-t v2 3/6] kms_panel_fitting: Remove un-used variable robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 4/6] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 5/6] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
2016-04-25 14:35 ` [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
2016-04-25 15:10   ` Ville Syrjälä
2016-04-25 15:38     ` Robert Foss
2016-04-25 16:43       ` Ville Syrjälä
2016-04-26 11:51 ` [PATCH i-g-t v2 0/6] Improve kms_panel_fitting Tomeu Vizoso
2016-04-26 15:47   ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461594951-27706-3-git-send-email-robert.foss@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.vlad@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox