From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [PATCH v6 14/25] drm/i915: Manually unwind after a
 failed request allocation
Date: Wed, 27 Apr 2016 13:48:01 +0300
Message-ID: <1461754081.3986.28.camel@linux.intel.com>
References: <1461701180-895-1-git-send-email-chris@chris-wilson.co.uk>
 <1461701180-895-15-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 05C9F6EA58
 for <intel-gfx@lists.freedesktop.org>; Wed, 27 Apr 2016 10:46:37 +0000 (UTC)
In-Reply-To: <1461701180-895-15-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gdGksIDIwMTYtMDQtMjYgYXQgMjE6MDYgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJ
biB0aGUgbmV4dCBwYXRjaGVzLCB3ZSB3YW50IHRvIG1vdmUgdGhlIHdvcmsgb3V0IG9mIGZyZWVp
bmcgdGhlIHJlcXVlc3QKPiBhbmQgaW50byBpdHMgcmV0aXJlbWVudCAoc28gdGhhdCB3ZSBjYW4g
ZnJlZSB0aGUgcmVxdWVzdCB3aXRob3V0Cj4gcmVxdWlyaW5nIHRoZSBzdHJ1Y3RfbXV0ZXgpLiBU
aGlzIG1lYW5zIHRoYXQgd2UgY2Fubm90IHJlbHkgb24KPiB1bnJlZmVyZW5jaW5nIHRoZSByZXF1
ZXN0IHRvIGNvbXBsZXRlbHkgdGVhcmRvd24gdGhlIHJlcXVlc3QgYW55IG1vcmUKPiBhbmQgc28g
d2UgbmVlZCB0byBtYW51YWxseSB1bndpbmQgdGhlIGZhaWxlZCBhbGxvY2F0aW9uLiBJbiBkb2lu
ZyBzbywgd2UKPiByZW9yZGVyIHRoZSBhbGxvY2F0aW9uIGluIG9yZGVyIHRvIG1ha2UgdGhlIHVu
d2luZCBzaW1wbGUgKGFuZCBlbnN1cmUKPiB0aGF0IHdlIGRvbid0IHRyeSB0byB1bndpbmQgYSBw
YXJ0aWFsIHJlcXVlc3QgdGhhdCBtYXkgaGF2ZSBtb2RpZmllZAo+IGdsb2JhbCBzdGF0ZSkgYW5k
IHNvIHdlIGVuZCB1cCBwdXNoaW5nIHRoZSBpbml0aWFsIHByZWFsbG9jYXRpb24gZG93bgo+IGlu
dG8gdGhlIGVuZ2luZSByZXF1ZXN0IGluaXRpYWxpc2F0aW9uIGZ1bmN0aW9ucyB3aGVyZSB3ZSBo
YXZlIHRoZQo+IHJlcXVpc2l0ZSBjb250cm9sIG92ZXIgdGhlIHN0YXRlIG9mIHRoZSByZXF1ZXN0
Lgo+IAo+IE1vdmluZyB0aGUgaW5pdGlhbCBwcmVhbGxvY2F0aW9uIGludG8gdGhlIGVuZ2luZSBp
cyBsZXNzIHRoYW4gaWRlYWw6IGl0Cj4gbW92ZXMgbG9naWMgdG8gaGFuZGxlIGEgc3BlY2lmaWMg
cHJvYmxlbSB3aXRoIHJlcXVlc3QgaGFuZGxpbmcgb3V0IG9mCj4gdGhlIGNvbW1vbiBjb2RlLiBP
biB0aGUgb3RoZXIgaGFuZCwgaXQgZG9lcyBhbGxvdyB0aG9zZSBiYWNrZW5kcwo+IHNpZ25pZmlj
YW50bHkgbW9yZSBmbGV4aWJpbGl0eSBpbiBwZXJmb3JtaW5nIGl0cyBhbGxvY2F0aW9ucy4KPiAK
CkFkZGluZyBKb2huIGFzIENDLAoKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz
QGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBs
aW51eC5pbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51
eC5pbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4
LmludGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmPCoMKg
wqDCoMKgwqDCoMKgwqB8IDI4ICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiDCoGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jwqDCoMKgwqDCoMKgwqDCoHwgMTYgKysrKysrKysr
KysrKystLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHzCoMKg
MiArLQo+IMKgMyBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMo
LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCAwZTI3NDg0YmQyOGEuLmQ3ZmY1
ZTc5MTgyZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0yNzY2LDE1ICsyNzY2
LDYgQEAgX19pOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu
Z2luZSwKPiDCoAlyZXEtPmN0eMKgwqA9IGN0eDsKPiDCoAlpOTE1X2dlbV9jb250ZXh0X3JlZmVy
ZW5jZShyZXEtPmN0eCk7Cj4gwqAKPiAtCWlmIChpOTE1LmVuYWJsZV9leGVjbGlzdHMpCj4gLQkJ
cmV0ID0gaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFzKHJlcSk7Cj4gLQll
bHNlCj4gLQkJcmV0ID0gaW50ZWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhyZXEpOwo+IC0J
aWYgKHJldCkgewo+IC0JCWk5MTVfZ2VtX2NvbnRleHRfdW5yZWZlcmVuY2UocmVxLT5jdHgpOwo+
IC0JCWdvdG8gZXJyOwo+IC0JfQo+IC0KPiDCoAkvKgo+IMKgCcKgKiBSZXNlcnZlIHNwYWNlIGlu
IHRoZSByaW5nIGJ1ZmZlciBmb3IgYWxsIHRoZSBjb21tYW5kcyByZXF1aXJlZCB0bwo+IMKgCcKg
KiBldmVudHVhbGx5IGVtaXQgdGhpcyByZXF1ZXN0LiBUaGlzIGlzIHRvIGd1YXJhbnRlZSB0aGF0
IHRoZQo+IEBAIC0yNzgzLDIwICsyNzc0LDE5IEBAIF9faTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhz
dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gwqAJwqAqIGF3YXksIGUuZy4gYmVjYXVz
ZSBhIEdQVSBzY2hlZHVsZXIgaGFzIGRlZmVycmVkIGl0Lgo+IMKgCcKgKi8KPiDCoAlyZXEtPnJl
c2VydmVkX3NwYWNlID0gTUlOX1NQQUNFX0ZPUl9BRERfUkVRVUVTVDsKPiAtCXJldCA9IGludGVs
X3JpbmdfYmVnaW4ocmVxLCAwKTsKPiAtCWlmIChyZXQpIHsKPiAtCQkvKgo+IC0JCcKgKiBBdCB0
aGlzIHBvaW50LCB0aGUgcmVxdWVzdCBpcyBmdWxseSBhbGxvY2F0ZWQgZXZlbiBpZiBub3QKPiAt
CQnCoCogZnVsbHkgcHJlcGFyZWQuIFRodXMgaXQgY2FuIGJlIGNsZWFuZWQgdXAgdXNpbmcgdGhl
IHByb3Blcgo+IC0JCcKgKiBmcmVlIGNvZGUuCj4gLQkJwqAqLwo+IC0JCWk5MTVfZ2VtX3JlcXVl
c3RfdW5yZWZlcmVuY2UocmVxKTsKPiAtCQlyZXR1cm4gcmV0Owo+IC0JfQo+ICsKPiArCWlmIChp
OTE1LmVuYWJsZV9leGVjbGlzdHMpCj4gKwkJcmV0ID0gaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9j
X3JlcXVlc3RfZXh0cmFzKHJlcSk7Cj4gKwllbHNlCj4gKwkJcmV0ID0gaW50ZWxfcmluZ19hbGxv
Y19yZXF1ZXN0X2V4dHJhcyhyZXEpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIGVycl9jdHg7Cj4g
wqAKPiDCoAkqcmVxX291dCA9IHJlcTsKPiDCoAlyZXR1cm4gMDsKPiDCoAo+ICtlcnJfY3R4Ogo+
ICsJaTkxNV9nZW1fY29udGV4dF91bnJlZmVyZW5jZShjdHgpOwo+IMKgZXJyOgo+IMKgCWttZW1f
Y2FjaGVfZnJlZShkZXZfcHJpdi0+cmVxdWVzdHMsIHJlcSk7Cj4gwqAJcmV0dXJuIHJldDsKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDkxMDA0NGNmMTQzZS4uMDE1MTdkZDcwNjli
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtNjk4LDcgKzY5OCw3IEBAIHN0
YXRpYyBpbnQgZXhlY2xpc3RzX21vdmVfdG9fZ3B1KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVz
dCAqcmVxLAo+IMKgCj4gwqBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0
cmFzKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiDCoHsKPiAtCWludCBy
ZXQgPSAwOwo+ICsJaW50IHJldDsKPiDCoAo+IMKgCXJlcXVlc3QtPnJpbmdidWYgPSByZXF1ZXN0
LT5jdHgtPmVuZ2luZVtyZXF1ZXN0LT5lbmdpbmUtPmlkXS5yaW5nYnVmOwo+IMKgCj4gQEAgLTcx
NSw5ICs3MTUsMjEgQEAgaW50IGludGVsX2xvZ2ljYWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJh
cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QKPiDCoAkJCXJldHVybiByZXQ7
Cj4gwqAJfQo+IMKgCj4gLQlpZiAocmVxdWVzdC0+Y3R4ICE9IHJlcXVlc3QtPmk5MTUtPmtlcm5l
bF9jb250ZXh0KQo+ICsJaWYgKHJlcXVlc3QtPmN0eCAhPSByZXF1ZXN0LT5pOTE1LT5rZXJuZWxf
Y29udGV4dCkgewo+IMKgCQlyZXQgPSBpbnRlbF9scl9jb250ZXh0X3BpbihyZXF1ZXN0LT5jdHgs
IHJlcXVlc3QtPmVuZ2luZSk7Cj4gKwkJaWYgKHJldCkKPiArCQkJcmV0dXJuIHJldDsKPiArCX0K
PiDCoAo+ICsJcmV0ID0gaW50ZWxfcmluZ19iZWdpbihyZXF1ZXN0LCAwKTsKPiArCWlmIChyZXQp
Cj4gKwkJZ290byBlcnJfdW5waW47Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gKwo+ICtlcnJfdW5waW46
Cj4gKwlpZiAocmVxdWVzdC0+Y3R4ICE9IHJlcXVlc3QtPmk5MTUtPmtlcm5lbF9jb250ZXh0KQo+
ICsJCWludGVsX2xyX2NvbnRleHRfdW5waW4ocmVxdWVzdC0+Y3R4LCByZXF1ZXN0LT5lbmdpbmUp
Owo+IMKgCXJldHVybiByZXQ7Cj4gwqB9Cj4gwqAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
cmluZ2J1ZmZlci5jCj4gaW5kZXggYmE1OTQ2YjlmYTA2Li4xMTkzMzcyZjc0ZmQgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTIzMzMsNyArMjMzMyw3
IEBAIGludCBpbnRlbF9lbmdpbmVfaWRsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp
Cj4gwqBpbnQgaW50ZWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhzdHJ1Y3QgZHJtX2k5MTVf
Z2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gwqB7Cj4gwqAJcmVxdWVzdC0+cmluZ2J1ZiA9IHJlcXVl
c3QtPmVuZ2luZS0+YnVmZmVyOwo+IC0JcmV0dXJuIDA7Cj4gKwlyZXR1cm4gaW50ZWxfcmluZ19i
ZWdpbihyZXF1ZXN0LCAwKTsKPiDCoH0KClRoZSBuYW1lcyBvZiB0aGVzZSB0d28gX2V4dHJhcyBm
dW5jdGlvbnMgd2l0aCB0aGUgYWRkZWQgZnVuY3Rpb25hbGl0eQpkbyBub3QgbWFrZSBzZW5zZS4K
ClJlZ2FyZHMsIEpvb25hcwoKPiDCoAo+IMKgc3RhdGljIGludCB3YWl0X2Zvcl9zcGFjZShzdHJ1
Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgaW50IGJ5dGVzKQotLSAKSm9vbmFzIExhaHRp
bmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0aW9uCl9fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls
aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy
ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=