[PATCH] drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

[PATCH] drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

[Rodrigo Vivi]

We have in the history some changes on this behaviour, but
there are many platforms out there and we don't know all panels.

VBT might not be reliable but it knows the platform better than
us usually. Or at least it should.
So, first of all let's respect the VBT. If something bad happens
again with one platform or another it is better to create a
quirk than to bypass the VBT.

Cc: Mihai Dontu <mihai.dontu@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index c3abae4..e65e2c3 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -788,14 +788,11 @@ void intel_psr_init(struct drm_device *dev)
 	}
 
 	/* Set link_standby x link_off defaults */
-	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
-		/* HSW and BDW require workarounds that we don't implement. */
-		dev_priv->psr.link_standby = false;
 	else if (IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev))
 		/* On VLV and CHV only standby mode is supported. */
 		dev_priv->psr.link_standby = true;
 	else
-		/* For new platforms let's respect VBT back again */
+		/* For other platforms let's respect VBT back again */
 		dev_priv->psr.link_standby = dev_priv->vbt.psr.full_link;
 
 	/* Override link_standby x link_off defaults */
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

[Chris Wilson]

On Wed, Apr 27, 2016 at 08:47:54AM -0700, Rodrigo Vivi wrote:
> We have in the history some changes on this behaviour, but
> there are many platforms out there and we don't know all panels.
> 
> VBT might not be reliable but it knows the platform better than
> us usually. Or at least it should.
> So, first of all let's respect the VBT. If something bad happens
> again with one platform or another it is better to create a
> quirk than to bypass the VBT.
> 
> Cc: Mihai Dontu <mihai.dontu@gmail.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index c3abae4..e65e2c3 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -788,14 +788,11 @@ void intel_psr_init(struct drm_device *dev)
>  	}
>  
>  	/* Set link_standby x link_off defaults */
> -	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> -		/* HSW and BDW require workarounds that we don't implement. */
> -		dev_priv->psr.link_standby = false;

This patch has nothing to do with respecting the VBT or not, it's about
whether the comment that we still require w/a is valid or not.

That's not even mentioned in the changelog.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

[Vivi, Rodrigo]

On Wed, 2016-04-27 at 16:53 +0100, Chris Wilson wrote:
> On Wed, Apr 27, 2016 at 08:47:54AM -0700, Rodrigo Vivi wrote:
> > We have in the history some changes on this behaviour, but
> > there are many platforms out there and we don't know all panels.
> > 
> > VBT might not be reliable but it knows the platform better than
> > us usually. Or at least it should.
> > So, first of all let's respect the VBT. If something bad happens
> > again with one platform or another it is better to create a
> > quirk than to bypass the VBT.
> > 
> > Cc: Mihai Dontu <mihai.dontu@gmail.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_psr.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_psr.c
> > b/drivers/gpu/drm/i915/intel_psr.c
> > index c3abae4..e65e2c3 100644
> > --- a/drivers/gpu/drm/i915/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/intel_psr.c
> > @@ -788,14 +788,11 @@ void intel_psr_init(struct drm_device *dev)
> >  	}
> >  
> >  	/* Set link_standby x link_off defaults */
> > -	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> > -		/* HSW and BDW require workarounds that we don't
> > implement. */
> > -		dev_priv->psr.link_standby = false;
> 
> This patch has nothing to do with respecting the VBT or not, it's
> about
> whether the comment that we still require w/a is valid or not.
> 
> That's not even mentioned in the changelog.

Oh you are right... Looking to the logs and HSD it seems that we still
need the workaround on HSW and BDW, since HSW has no single frame
update and we don't implement on BDW because it requires other 3 W/a...

Maybe we should just disable PSR for the cases VBT tells only link
standby is supported on HSW and BDW.

> -Chris
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

[Patchwork]

== Series Details ==

Series: drm/i915: respect VBT PSR link standby configuration for HSW/BDW.
URL   : https://patchwork.freedesktop.org/series/6416/
State : success

== Summary ==

Series 6416v1 drm/i915: respect VBT PSR link standby configuration for HSW/BDW.
http://patchwork.freedesktop.org/api/1.0/series/6416/revisions/1/mbox/

Test drv_module_reload_basic:
                skip       -> PASS       (bdw-nuci7)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (bdw-ultra)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-b:
                dmesg-warn -> PASS       (snb-dellxps)

bdw-nuci7        total:200  pass:188  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:200  pass:175  dwarn:0   dfail:0   fail:0   skip:25 
bsw-nuc-2        total:199  pass:158  dwarn:0   dfail:0   fail:0   skip:41 
byt-nuc          total:199  pass:158  dwarn:0   dfail:0   fail:0   skip:41 
hsw-brixbox      total:200  pass:174  dwarn:0   dfail:0   fail:0   skip:26 
hsw-gt2          total:200  pass:178  dwarn:0   dfail:0   fail:1   skip:21 
ilk-hp8440p      total:200  pass:139  dwarn:0   dfail:0   fail:0   skip:61 
ivb-t430s        total:200  pass:169  dwarn:0   dfail:0   fail:0   skip:31 
skl-i7k-2        total:200  pass:173  dwarn:0   dfail:0   fail:0   skip:27 
skl-nuci5        total:200  pass:189  dwarn:0   dfail:0   fail:0   skip:11 
snb-dellxps      total:200  pass:158  dwarn:0   dfail:0   fail:0   skip:42 
snb-x220t        total:200  pass:158  dwarn:0   dfail:0   fail:1   skip:41 

Results at /archive/results/CI_IGT_test/Patchwork_2094/

e6c43160f35ad64114e1156e3f995e5dabe74835 drm-intel-nightly: 2016y-04m-27d-13h-17m-05s UTC integration manifest
adbbc5d drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx