public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH] lib/igt_kms: move gtk-doc comments next to the definition
Date: Tue, 17 May 2016 14:44:13 +0300	[thread overview]
Message-ID: <1463485453-22168-1-git-send-email-jani.nikula@intel.com> (raw)
In-Reply-To: <20160517111156.GB27098@phenom.ffwll.local>

Now that we have actual functions for kms_test_*_str since

commit 2d432fc5773df17f04283f4780dab161dd2e1c85
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Wed May 11 12:42:06 2016 +0300

    lib/igt_aux: define actual functions for kmstest_*_str

move also the gtk-doc comments next to the definitions, for consistency.

Acked-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 lib/igt_aux.c | 18 ++++++++++++++++++
 lib/igt_kms.h | 20 --------------------
 2 files changed, 18 insertions(+), 20 deletions(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 6c3eb1f42fab..27b74aec8461 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -942,6 +942,12 @@ static const struct type_name encoder_type_names[] = {
 	{}
 };
 
+/**
+ * kmstest_encoder_type_str:
+ * @type: DRM_MODE_ENCODER_* enumeration value
+ *
+ * Returns: A string representing the drm encoder @type.
+ */
 const char *kmstest_encoder_type_str(int type)
 {
 	return find_type_name(encoder_type_names, type);
@@ -954,6 +960,12 @@ static const struct type_name connector_status_names[] = {
 	{}
 };
 
+/**
+ * kmstest_connector_status_str:
+ * @status: DRM_MODE_* connector status value
+ *
+ * Returns: A string representing the drm connector status @status.
+ */
 const char *kmstest_connector_status_str(int status)
 {
 	return find_type_name(connector_status_names, status);
@@ -980,6 +992,12 @@ static const struct type_name connector_type_names[] = {
 	{}
 };
 
+/**
+ * kmstest_connector_type_str:
+ * @type: DRM_MODE_CONNECTOR_* enumeration value
+ *
+ * Returns: A string representing the drm connector @type.
+ */
 const char *kmstest_connector_type_str(int type)
 {
 	return find_type_name(connector_type_names, type);
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 5c8340171ab6..7aad8c8c2153 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -77,28 +77,8 @@ enum port {
  */
 #define kmstest_port_name(port) ((port) + 'A')
 
-/**
- * kmstest_encoder_type_str:
- * @type: DRM_MODE_ENCODER_* enumeration value
- *
- * Returns: A string representing the drm encoder @type.
- */
 const char *kmstest_encoder_type_str(int type);
-
-/**
- * kmstest_connector_status_str:
- * @status: DRM_MODE_* connector status value
- *
- * Returns: A string representing the drm connector status @status.
- */
 const char *kmstest_connector_status_str(int status);
-
-/**
- * kmstest_connector_type_str:
- * @type: DRM_MODE_CONNECTOR_* enumeration value
- *
- * Returns: A string representing the drm connector @type.
- */
 const char *kmstest_connector_type_str(int type);
 
 void kmstest_dump_mode(drmModeModeInfo *mode);
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-05-17 11:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11  9:42 [PATCH i-g-t 1/2] lib/igt_aux: update encoder and type names Jani Nikula
2016-05-11  9:42 ` [PATCH i-g-t 2/2] lib/igt_aux: define actual functions for kmstest_*_str Jani Nikula
2016-05-17  9:56   ` Daniel Vetter
2016-05-17 10:05     ` Jani Nikula
2016-05-17 11:11       ` Daniel Vetter
2016-05-17 11:44         ` Jani Nikula [this message]
2016-05-11 15:24 ` [PATCH i-g-t 1/2] lib/igt_aux: update encoder and type names Marius Vlad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463485453-22168-1-git-send-email-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox