From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 10/21] drm/i915: Unify SKL cdclk init paths Date: Thu, 19 May 2016 18:43:32 +0300 Message-ID: <1463672612.12342.41.camel@intel.com> References: <1463172100-24715-1-git-send-email-ville.syrjala@linux.intel.com> <1463172100-24715-11-git-send-email-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 312226E1C1 for ; Thu, 19 May 2016 15:44:38 +0000 (UTC) In-Reply-To: <1463172100-24715-11-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTYtMDUtMTMgYXQgMjM6NDEgKzAzMDAsIHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tIHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gCj4gQ3VycmVudGx5IHdlIGluaXRpYWxpemUgY2RjbGsgb24gU0tMIGZy b20gdHdvIGRpZmZlcmVudCBwbGFjZXMsCj4gZGVwZW5kaW5nIG9uIHdoZXRoZXIgaXQncyBkdXJp bmcgZHJpdmVyIGluaXQgb3IgcmVzdW1lLiBMZXQncwo+IHVuaWZ5IGl0IHRvIGhhcHBlbiBmcm9t IHRoZSBzYW1lIHBsYWNlIGFsd2F5cywgYW5kIHRoYXQgcGxhY2Ugd2lsbCBiZQo+IHRoZSBkaXNw bGF5IGNvcmUgaW5pdCBmdW5jdGlvbi4KPiAKPiBUbyBkbyB0aGlzIHdlIGZpcnN0IHJ1biB0aHJv dWdoIHRoZSBjZGNsayBzYW5pdGF0aW9uIGNvZGUsIHdoaWNoIHdpbGwKPiBmaXJzdCB2ZXJpZnkg dGhhdCB0aGUgUExMIGlzIHByb2dyYW1tZWQgY29ycmVjdGx5LCBhZnRlciB3aGljaCB3ZSBjYW4K PiByZWFkIG91dCB0aGUgY3VycmVudCBjZGNsayBmcmVxdWVuY3ksIGFuZCBvbmNlIHRoZSBjZGNs ayBpcyBrbm93biB3ZQo+IHZlcmlmeSB0aGF0IHRoZSBjZGNsayAiZGVjaW1hbCIgZnJlcXVlbmN5 IGlzIHByb2dyYW1tZWQgY29ycmVjdGx5LiBJZgo+IGFueSBvZiB0aGVzZSBmYWlsIHdlIHdpbGwg Zm9yY2UgYSBjZGNsayBjaGFuZ2UsIGFuZCB0byBiZSBzYWZlIHdlIGFsc28KPiBmb3JjZSB0aGUg UExMIHRvIGJlIHR1cm5lZCBvZmYgYW5kIG9uIGFnYWluLiBJZiB0aGUgc2FuaXRhdGlvbiBzdGVw Cj4gZGlkbid0IG5vdGljZSBhbnl0aGluZyBhbWlzcywgd2UnbGwgc2tpcCB0aGUgY2RjbGsgcHJv Z3JhbW1pbmcgd2hpY2gKPiB3aWxsIHByZXZlbnQgY2RjbGsgcmVwcm9ncmFtbWluZyB3aGVuIHRo ZSBkaXNwbGF5cyBtaWdodCBiZSBhY3RpdmUuCj4gCj4gV2UgY2FuIGFsc28gdG9zcyBpbiBhIGZl dyBXQVJOcyBhYm91dCB0aGUgcmVnaXN0ZXIgdmFsdWVzIGludG8KPiBza2xfdXBkYXRlX2RwbGww KCkgc2luY2Ugd2Ugbm93IGtub3cgdGhhdCB0aGUgUExMIHN0YXRlIHNob3VsZAo+IGFsd2F5cyBi ZSBzYW5lIHdoZW4gdGhhdCBmdW5jdGlvbiBpcyBjYWxsZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiDC oGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuY8KgwqDCoMKgfCA0MCArKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwbGxfbWdyLmPCoMKgwqB8IDExICsrLS0tLS0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmjCoMKgwqDCoMKgwqDCoMKgfMKgwqAxIC0KPiDCoGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3J1bnRpbWVfcG0uYyB8wqDCoDUgKy0tLS0KPiDCoDQgZmlsZXMgY2hhbmdlZCwg MzQgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IGluZGV4IDQ5MzE2MDY4MmIyYS4uZGE5MDNiNzE4YzExIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC01NTc3LDggKzU1NzcsMTUgQEAg c2tsX2RwbGwwX3VwZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gwqAJ CXJldHVybjsKPiDCoAl9Cj4gwqAKPiArCVdBUk5fT04oKHZhbCAmIExDUExMX1BMTF9MT0NLKSA9 PSAwKTsKPiArCj4gwqAJdmFsID0gSTkxNV9SRUFEKERQTExfQ1RSTDEpOwo+IMKgCj4gKwlXQVJO X09OKCh2YWwgJiAoRFBMTF9DVFJMMV9IRE1JX01PREUoU0tMX0RQTEwwKSB8Cj4gKwkJCURQTExf Q1RSTDFfU1NDKFNLTF9EUExMMCkgfAo+ICsJCQlEUExMX0NUUkwxX09WRVJSSURFKFNLTF9EUExM MCkpKSAhPQo+ICsJCURQTExfQ1RSTDFfT1ZFUlJJREUoU0tMX0RQTEwwKSk7Cj4gKwo+IMKgCXN3 aXRjaCAodmFsICYgRFBMTF9DVFJMMV9MSU5LX1JBVEVfTUFTSyhTS0xfRFBMTDApKSB7Cj4gwqAJ Y2FzZSBEUExMX0NUUkwxX0xJTktfUkFURShEUExMX0NUUkwxX0xJTktfUkFURV84MTAsIFNLTF9E UExMMCk6Cj4gwqAJY2FzZSBEUExMX0NUUkwxX0xJTktfUkFURShEUExMX0NUUkwxX0xJTktfUkFU RV8xMzUwLCBTS0xfRFBMTDApOgo+IEBAIC01NzQ4LDYgKzU3NTUsOCBAQCBzdGF0aWMgdm9pZCBz a2xfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IGNkY2xr LCBpbnQgdmNvKQo+IMKgCWludGVsX3VwZGF0ZV9jZGNsayhkZXYpOwo+IMKgfQo+IMKgCj4gK3N0 YXRpYyB2b2lkIHNrbF9zYW5pdGl6ZV9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpOwo+ICsKPiDCoHZvaWQgc2tsX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gwqB7Cj4gwqAJLyogZGlzYWJsZSBEQlVGIHBvd2VyICovCj4gQEAg LTU3NjQsMTAgKzU3NzMsMTkgQEAgdm9pZCBza2xfdW5pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiDCoAo+IMKgdm9pZCBza2xfaW5pdF9jZGNsayhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gwqB7Cj4gLQkvKiBEUExMMCBub3QgZW5hYmxl ZCAoaGFwcGVucyBvbiBlYXJseSBCSU9TIHZlcnNpb25zKSAqLwo+IC0JaWYgKGRldl9wcml2LT5z a2xfdmNvX2ZyZXEgPT0gMCkgewo+IC0JCWludCBjZGNsaywgdmNvOwo+ICsJaW50IGNkY2xrLCB2 Y287Cj4gKwo+ICsJc2tsX3Nhbml0aXplX2NkY2xrKGRldl9wcml2KTsKPiDCoAo+ICsJaWYgKGRl dl9wcml2LT5jZGNsa19mcmVxICE9IDAgJiYgZGV2X3ByaXYtPnNrbF92Y29fZnJlcSAhPSAwKSB7 Cj4gKwkJLyoKPiArCQnCoCogVXNlIHRoZSBjdXJyZW50IHZjbyBhcyBvdXQgaW5pdGlhbAoKdHlw byBhYm92ZS4KCkxvb2tzIG9rOgpSZXZpZXdlZC1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50 ZWwuY29tPgoKPiArCQnCoCogZ3Vlc3MgYXMgdG8gd2hhdCB0aGUgcHJlZmVycmVkIHZjbyBpcy4K PiArCQnCoCovCj4gKwkJaWYgKGRldl9wcml2LT5za2xfcHJlZmVycmVkX3Zjb19mcmVxID09IDAp Cj4gKwkJCXNrbF9zZXRfcHJlZmVycmVkX2NkY2xrX3ZjbyhkZXZfcHJpdiwKPiArCQkJCQkJwqDC oMKgwqBkZXZfcHJpdi0+c2tsX3Zjb19mcmVxKTsKPiArCX0gZWxzZSB7Cj4gwqAJCS8qIHNldCBD RENMSyB0byB0aGUgbG93ZXN0IGZyZXF1ZW5jeSwgTW9kZXNldCBmb2xsb3dzICovCj4gwqAJCXZj byA9IGRldl9wcml2LT5za2xfcHJlZmVycmVkX3Zjb19mcmVxOwo+IMKgCQlpZiAodmNvID09IDAp Cj4gQEAgLTU3ODcsNyArNTgwNSw3IEBAIHZvaWQgc2tsX2luaXRfY2RjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IMKgCQlEUk1fRVJST1IoIkRCdWYgcG93ZXIgZW5hYmxl IHRpbWVvdXRcbiIpOwo+IMKgfQo+IMKgCj4gLWludCBza2xfc2FuaXRpemVfY2RjbGsoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgdm9pZCBza2xfc2FuaXRpemVf Y2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IMKgewo+IMKgCXVpbnQz Ml90IGNkY3RsLCBleHBlY3RlZDsKPiDCoAo+IEBAIC01ODEwLDYgKzU4MjgsOCBAQCBpbnQgc2ts X3Nhbml0aXplX2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiDCoAnC oMKgwqDCoERQTExfQ1RSTDFfT1ZFUlJJREUoU0tMX0RQTEwwKSkKPiDCoAkJZ290byBzYW5pdGl6 ZTsKPiDCoAo+ICsJaW50ZWxfdXBkYXRlX2NkY2xrKGRldl9wcml2LT5kZXYpOwo+ICsKPiDCoAkv KiBEUExMIG9rYXk7IHZlcmlmeSB0aGUgY2RjbG9jawo+IMKgCcKgKgo+IMKgCcKgKiBOb3RpY2Vk IGluIHNvbWUgaW5zdGFuY2VzIHRoYXQgdGhlIGZyZXEgc2VsZWN0aW9uIGlzIGNvcnJlY3QgYnV0 Cj4gQEAgLTU4MjEsMTMgKzU4NDEsMTUgQEAgaW50IHNrbF9zYW5pdGl6ZV9jZGNsayhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gwqAJCXNrbF9jZGNsa19kZWNpbWFsKGRldl9w cml2LT5jZGNsa19mcmVxKTsKPiDCoAlpZiAoY2RjdGwgPT0gZXhwZWN0ZWQpCj4gwqAJCS8qIEFs bCB3ZWxsOyBub3RoaW5nIHRvIHNhbml0aXplICovCj4gLQkJcmV0dXJuIGZhbHNlOwo+IC1zYW5p dGl6ZToKPiArCQlyZXR1cm47Cj4gwqAKPiAtCXNrbF9pbml0X2NkY2xrKGRldl9wcml2KTsKPiAr c2FuaXRpemU6Cj4gKwlEUk1fREVCVUdfS01TKCJTYW5pdGl6aW5nIGNkY2xrIHByb2dyYW1tZWQg YnkgcHJlLW9zXG4iKTsKPiDCoAo+IC0JLyogd2UgZGlkIGhhdmUgdG8gc2FuaXRpemUgKi8KPiAt CXJldHVybiB0cnVlOwo+ICsJLyogZm9yY2UgY2RjbGsgcHJvZ3JhbW1pbmcgKi8KPiArCWRldl9w cml2LT5jZGNsa19mcmVxID0gMDsKPiArCS8qIGZvcmNlIGZ1bGwgUExMIGRpc2FibGUgKyBlbmFi bGUgKi8KPiArCWRldl9wcml2LT5za2xfdmNvX2ZyZXEgPSAtMTsKPiDCoH0KPiDCoAo+IMKgLyog QWRqdXN0IENEY2xrIGRpdmlkZXJzIHRvIGFsbG93IGhpZ2ggcmVzIG9yIHNhdmUgcG93ZXIgaWYg cG9zc2libGUgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBs bF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCAz NGVjMTQ5ZmRlODUuLjZiNzBlMWVjY2IxMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcGxsX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBsbF9tZ3IuYwo+IEBAIC0xNjMwLDE3ICsxNjMwLDEwIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg aW50ZWxfc2hhcmVkX2RwbGxfZnVuY3MgYnh0X2RkaV9wbGxfZnVuY3MgPSB7Cj4gwqBzdGF0aWMg dm9pZCBpbnRlbF9kZGlfcGxsX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiDCoHsKPiDC oAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ IC0JdWludDMyX3QgdmFsID0gSTkxNV9SRUFEKExDUExMX0NUTCk7Cj4gwqAKPiAtCWlmIChJU19T S1lMQUtFKGRldikgfHwgSVNfS0FCWUxBS0UoZGV2KSkgewo+IC0JCWlmIChza2xfc2FuaXRpemVf Y2RjbGsoZGV2X3ByaXYpKQo+IC0JCQlEUk1fREVCVUdfS01TKCJTYW5pdGl6ZWQgY2RjbGsgcHJv Z3JhbW1lZCBieSBwcmUtb3NcbiIpOwo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5KSB7 Cj4gKwkJdWludDMyX3QgdmFsID0gSTkxNV9SRUFEKExDUExMX0NUTCk7Cj4gwqAKPiAtCQkvKiBX ZSdsbCB3YW50IHRvIGtlZXAgdXNpbmcgdGhlIGN1cnJlbnQgdmNvIGZyb20gbm93IG9uICovCj4g LQkJaWYgKGRldl9wcml2LT5za2xfdmNvX2ZyZXEgIT0gMCkKPiAtCQkJc2tsX3NldF9wcmVmZXJy ZWRfY2RjbGtfdmNvKGRldl9wcml2LAo+IC0JCQkJCQnCoMKgwqDCoGRldl9wcml2LT5za2xfdmNv X2ZyZXEpOwo+IC0JfSBlbHNlIGlmICghSVNfQlJPWFRPTihkZXZfcHJpdikpIHsKPiDCoAkJLyoK PiDCoAkJwqAqIFRoZSBMQ1BMTCByZWdpc3RlciBzaG91bGQgYmUgdHVybmVkIG9uIGJ5IHRoZSBC SU9TLiBGb3Igbm93Cj4gwqAJCcKgKiBsZXQncyBqdXN0IGNoZWNrIGl0cyBzdGF0ZSBhbmQgcHJp bnQgZXJyb3JzIGluIGNhc2UKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDhmNDhh MzJlOTkxYi4uMzE5ZTUyMjc4ZDFmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBA QCAtMTI3OSw3ICsxMjc5LDYgQEAgdm9pZCBieHRfZW5hYmxlX2RjOShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpOwo+IMKgdm9pZCBieHRfZGlzYWJsZV9kYzkoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiDCoHZvaWQgZ2VuOV9lbmFibGVfZGM1KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gwqB2b2lkIHNrbF9pbml0X2NkY2xrKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gLWludCBza2xfc2FuaXRpemVfY2RjbGso c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiDCoHZvaWQgc2tsX3VuaW5pdF9j ZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+IMKgdW5zaWduZWQgaW50 IHNrbF9jZGNsa19nZXRfdmNvKHVuc2lnbmVkIGludCBmcmVxKTsKPiDCoHZvaWQgc2tsX2VuYWJs ZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gaW5kZXggYjY5YjkzNTUxNmZiLi5mZWZlMjJjM2Mx NjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gQEAgLTIy MDAsMTIgKzIyMDAsOSBAQCBzdGF0aWMgdm9pZCBza2xfZGlzcGxheV9jb3JlX2luaXQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IMKgCj4gwqAJbXV0ZXhfdW5sb2NrKCZwb3dl cl9kb21haW5zLT5sb2NrKTsKPiDCoAo+IC0JaWYgKCFyZXN1bWUpCj4gLQkJcmV0dXJuOwo+IC0K PiDCoAlza2xfaW5pdF9jZGNsayhkZXZfcHJpdik7Cj4gwqAKPiAtCWlmIChkZXZfcHJpdi0+Y3Ny LmRtY19wYXlsb2FkKQo+ICsJaWYgKHJlc3VtZSAmJiBkZXZfcHJpdi0+Y3NyLmRtY19wYXlsb2Fk KQo+IMKgCQlpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKGRldl9wcml2KTsKPiDCoH0KPiDCoApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK