Re: [PATCH 2/5] drm/i915: Disable the Link training automation support

Manasi Navare
2016-05-25T19:24:25Z

On Mon, May 23, 2016 at 11:10:24AM +0300, Ander Conselvan De Oliveira wrote:
> On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote:
> > Kernel does not have automation support for DP compliance Link
> > training tests. So the Link Training test handler should return
> > a TEST_NAK.
>
> Is this test activated by short or long pulse? The commit message of commit
> 09b1eb130e43 ("drm/i915: Move Displayport test request and sink IRQ logic to
> intel_dp_detect()") suggests the latter. In that case, the order of this and
> patch 1 should be inverted.
>
> Otherwise, for patches 1 and 2:
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
>
>

This test (Link Training test) is activated by a short pulse, however
the patch 09b1eb130e43 only supported EDID tests that get activated
by a long pulse.
> >
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 19a95ed..0961f22 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -4011,7 +4011,7 @@ intel_dp_get_sink_irq_esi(struct intel_dp *intel_dp, u8
> > *sink_irq_vector)
> >
> >  static uint8_t intel_dp_autotest_link_training(struct intel_dp *intel_dp)
> >  {
> > - uint8_t test_result = DP_TEST_ACK;
> > + uint8_t test_result = DP_TEST_NAK;
> >   return test_result;
> >  }
> >