public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t] kms_plane_scaling: Don't try to use second scaler on pipe C
Date: Wed,  1 Jun 2016 15:13:19 -0700	[thread overview]
Message-ID: <1464819199-19292-1-git-send-email-matthew.d.roper@intel.com> (raw)

Gen9 has two scalers on pipes A & B, but only a single scaler on pipe C.
We should bail out of the test early on pipe C so that we don't ask the
kernel to use more scalers than we really have.

Note that this test may still fail (on any pipe) if we're already using
one of the scalers as a panel fitter.  But at least this is an
improvement over the existing state where the test is guaranteed to fail
if run with pipe C active.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92248
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 tests/kms_plane_scaling.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index ad5404d..2b17702 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -264,6 +264,9 @@ static void test_plane_scaling(data_t *d)
 			igt_display_commit2(display, COMMIT_UNIVERSAL);
 		}
 
+		if (pipe == PIPE_C)
+			goto crtcdone;
+
 		/* Set up fb3->plane3 mapping. */
 		d->plane3 = igt_output_get_plane(output, IGT_PLANE_3);
 		igt_plane_set_fb(d->plane3, &d->fb3);
@@ -301,9 +304,11 @@ static void test_plane_scaling(data_t *d)
 			igt_display_commit2(display, COMMIT_UNIVERSAL);
 		}
 
+crtcdone:
 		/* back to single plane mode */
 		igt_plane_set_fb(d->plane2, NULL);
-		igt_plane_set_fb(d->plane3, NULL);
+		if (pipe != PIPE_C)
+			igt_plane_set_fb(d->plane3, NULL);
 		igt_display_commit2(display, COMMIT_UNIVERSAL);
 
 		valid_tests++;
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2016-06-01 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 22:13 Matt Roper [this message]
2016-06-02  8:35 ` [PATCH i-g-t] kms_plane_scaling: Don't try to use second scaler on pipe C Ville Syrjälä
2016-06-02 14:50   ` Matt Roper
2016-06-02 16:56     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464819199-19292-1-git-send-email-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox