From: Dave Gordon <david.s.gordon@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v3 3/7] drm/i915/guc: remove writes to GEN8_DRBREG registers
Date: Mon, 13 Jun 2016 17:57:30 +0100 [thread overview]
Message-ID: <1465837054-16245-4-git-send-email-david.s.gordon@intel.com> (raw)
In-Reply-To: <1465837054-16245-1-git-send-email-david.s.gordon@intel.com>
These registers are not actually writable by the CPU; only the GuC can
actually program them. So let's not do writes that have no effect.
Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_guc_submission.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index 21daaa5..1589fe9 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -252,14 +252,9 @@ static void guc_disable_doorbell(struct intel_guc *guc,
doorbell->db_status = GUC_DOORBELL_DISABLED;
- I915_WRITE(drbreg, I915_READ(drbreg) & ~GEN8_DRB_VALID);
-
value = I915_READ(drbreg);
WARN_ON((value & GEN8_DRB_VALID) != 0);
- I915_WRITE(GEN8_DRBREGU(client->doorbell_id), 0);
- I915_WRITE(drbreg, 0);
-
/* XXX: wait for any interrupts */
/* XXX: wait for workqueue to drain */
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-13 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 16:57 [PATCH v3 0/7] drm/i915/guc: updates to GuC doorbell handling Dave Gordon
2016-06-13 16:57 ` [PATCH v3 1/7] drm/i915/guc: add doorbell map to debugfs/i915_guc_info Dave Gordon
2016-06-13 16:57 ` [PATCH v3 2/7] drm/i915/guc: prefer __set/clear_bit() to bitmap_set/clear() Dave Gordon
2016-06-13 16:57 ` Dave Gordon [this message]
2016-06-13 16:57 ` [PATCH v3 4/7] drm/i915/guc: move guc_ring_doorbell() nearer to callsite Dave Gordon
2016-06-13 16:57 ` [PATCH v3 5/7] drm/i915/guc: refactor doorbell management code Dave Gordon
2016-06-14 12:20 ` Tvrtko Ursulin
2016-06-13 16:57 ` [PATCH v3 6/7] drm/i915/guc: replace assign_doorbell() with select_doorbell_register() Dave Gordon
2016-06-14 12:23 ` Tvrtko Ursulin
2016-06-13 16:57 ` [PATCH v3 7/7] drm/i915/guc: (re)initialise doorbell h/w when enabling GuC submission Dave Gordon
2016-06-14 5:27 ` ✗ Ro.CI.BAT: failure for drm/i915/guc: updates to GuC doorbell handling (rev2) Patchwork
2016-06-14 13:42 ` Dave Gordon
2016-06-14 14:05 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465837054-16245-4-git-send-email-david.s.gordon@intel.com \
--to=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox