From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3] drm/i915/fbc: FBC causes display flicker when VT-d is enabled on Skylake
Date: Wed, 22 Jun 2016 22:18:45 +0000 [thread overview]
Message-ID: <1466633925.3190.13.camel@intel.com> (raw)
In-Reply-To: <20160622203450.GC15943@nuc-i3427.alporthouse.com>
Em Qua, 2016-06-22 às 21:34 +0100, Chris Wilson escreveu:
> On Tue, Jun 21, 2016 at 03:31:25PM +0200, Daniel Vetter wrote:
> >
> > On Tue, Jun 21, 2016 at 08:25:27AM +0100, Chris Wilson wrote:
> > >
> > > Erratum SKL075: Display Flicker May Occur When Both VT-d And FBC
> > > Are Enabled
> > >
> > > "Display flickering may occur when both FBC (Frame Buffer
> > > Compression)
> > > and VT - d (Intel® Virtualization Technology for Directed I/O)
> > > are enabled
> > > and in use by the display controller."
> > >
> > > Ville found the w/a name in the database:
> > > WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl
> > >
> > > v2: Log when the quirk is applied.
> > > v3: Ensure i915.enable_fbc is false when !HAS_FBC()
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Do we know whether this helps on other machines too? I can imagine
> > that
> > the additional lookup latency just plain wreaks havoc everywhere
> > ...
> Yeah, they do tend to play into fifo trouble. Could find anything
> though. But I think we have enough evidence to suggest acking this
> w/a
> and moving forward if we find any others...
From the HSD, it looks like this problem would lead to an underrun, so
the "disable FBC if we ever get an underrun" would at least help
diminish the damage in case the WA is actually valid for the previous
gens.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-22 22:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 21:17 [PATCH 0/4] Enable FBC on SKL, v3 Paulo Zanoni
2016-04-04 21:17 ` [PATCH 1/4] drm/i915/fbc: update busy_bits even for GTT and flip flushes Paulo Zanoni
2016-04-04 21:17 ` [PATCH 2/4] drm/i915/fbc: sanitize i915.enable_fbc during FBC init Paulo Zanoni
2016-04-06 14:19 ` Chris Wilson
2016-04-13 19:01 ` Paulo Zanoni
2016-04-25 8:10 ` Daniel Vetter
2016-04-04 21:17 ` [PATCH 3/4] drm/i915: use ORIGIN_CPU for frontbuffer invalidation on WC mmaps Paulo Zanoni
2016-04-25 8:15 ` [Intel-gfx] " Daniel Vetter
2016-04-25 8:20 ` Chris Wilson
2016-04-25 8:27 ` Daniel Vetter
2016-06-09 18:59 ` Paulo Zanoni
2016-06-17 17:46 ` Paulo Zanoni
2016-04-04 21:17 ` [PATCH 4/4] drm/i915/fbc: enable FBC on gen 9+ too Paulo Zanoni
2016-04-13 19:01 ` Paulo Zanoni
2016-04-25 8:28 ` Daniel Vetter
2016-06-17 16:39 ` [PATCH] drm/i915/fbc: FBC causes display flicker when VT-d is enabled on Skylake Chris Wilson
2016-06-17 19:02 ` Zanoni, Paulo R
2016-06-17 19:23 ` chris
2016-06-17 19:34 ` Ville Syrjälä
2016-06-17 19:45 ` [PATCH v2] " Chris Wilson
2016-06-21 7:25 ` [PATCH v3] " Chris Wilson
2016-06-21 13:31 ` Daniel Vetter
2016-06-22 20:34 ` Chris Wilson
2016-06-22 22:18 ` Zanoni, Paulo R [this message]
2016-06-22 22:15 ` Zanoni, Paulo R
2016-06-23 8:41 ` Jani Nikula
2016-04-04 21:18 ` [PATCH igt 1/3] kms_frontbuffer_tracking: prefer the BLT drawing method Paulo Zanoni
2016-04-04 21:18 ` [PATCH igt 2/3] kms_frontbuffer_tracking: recreate the FBs at every subtest Paulo Zanoni
2016-04-04 21:18 ` [PATCH igt 3/3] kms_frontbuffer_tracking: properly handle mixing GTT and WC mmaps Paulo Zanoni
2016-04-06 5:06 ` [PATCH 0/4] Enable FBC on SKL, v3 Thulasimani, Sivakumar
2016-04-06 13:54 ` Zanoni, Paulo R
2016-04-06 16:11 ` Thulasimani, Sivakumar
2016-04-14 14:53 ` ✓ Fi.CI.BAT: success for Enable FBC on SKL (rev4) Patchwork
2016-06-10 5:54 ` ✓ Ro.CI.BAT: success for Enable FBC on SKL (rev5) Patchwork
2016-06-17 16:45 ` ✗ Ro.CI.BAT: failure for Enable FBC on SKL (rev6) Patchwork
2016-06-18 5:48 ` ✗ Ro.CI.BAT: failure for Enable FBC on SKL (rev8) Patchwork
2016-06-21 7:30 ` ✗ Ro.CI.BAT: failure for Enable FBC on SKL (rev9) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-08-04 7:14 [PATCH v2] drm/i915/fbc: FBC causes display flicker when VT-d is enabled on Skylake Ville Syrjälä
2016-08-04 7:43 ` [PATCH v3] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466633925.3190.13.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).