Re: [PATCH 2/4] drm/i915/lpt: Avoid early timeout during FDI PHY reset

Imre Deak
2016-06-28T11:03:59Z

On ti, 2016-06-28 at 11:50 +0100, Chris Wilson wrote:
> On Tue, Jun 28, 2016 at 01:37:31PM +0300, Imre Deak wrote:
> > Since wait_for_atomic doesn't re-check the wait-for condition after
> > expiry of the timeout it can fail when called from non-atomic
> > context
> > even if the condition is set correctly before the expiry. Fix this
> > by
> > using the non-atomic wait_for instead.
>
> Same point as patch 1. If the bug is using the wrong function, ...
> The only question is whether you do have an atomic context, in which
> case we need to reinspect the notion of "there is only at most 3
> non-preemptible instructions between the COND and the timeout"...

These functions are only called from non-atomic context.

--Imre