From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915/lpt: Avoid early timeout during FDI PHY reset
Date: Tue, 28 Jun 2016 14:03:57 +0300 [thread overview]
Message-ID: <1467111837.20290.23.camel@intel.com> (raw)
In-Reply-To: <20160628105048.GC10917@nuc-i3427.alporthouse.com>
On ti, 2016-06-28 at 11:50 +0100, Chris Wilson wrote:
> On Tue, Jun 28, 2016 at 01:37:31PM +0300, Imre Deak wrote:
> > Since wait_for_atomic doesn't re-check the wait-for condition after
> > expiry of the timeout it can fail when called from non-atomic
> > context
> > even if the condition is set correctly before the expiry. Fix this
> > by
> > using the non-atomic wait_for instead.
>
> Same point as patch 1. If the bug is using the wrong function, ...
> The only question is whether you do have an atomic context, in which
> case we need to reinspect the notion of "there is only at most 3
> non-preemptible instructions between the COND and the timeout"...
These functions are only called from non-atomic context.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-28 11:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 10:37 [PATCH 0/4] drm/i915: Avoid early timeout due to wait_for_atomic Imre Deak
2016-06-28 10:37 ` [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable Imre Deak
2016-06-28 10:48 ` Chris Wilson
2016-06-28 11:00 ` Imre Deak
2016-06-28 11:05 ` Tvrtko Ursulin
2016-06-28 11:11 ` Chris Wilson
2016-06-28 11:16 ` Imre Deak
2016-06-28 11:21 ` Tvrtko Ursulin
2016-06-28 11:26 ` Tvrtko Ursulin
2016-06-28 10:37 ` [PATCH 2/4] drm/i915/lpt: Avoid early timeout during FDI PHY reset Imre Deak
2016-06-28 10:50 ` Chris Wilson
2016-06-28 11:03 ` Imre Deak [this message]
2016-06-28 11:12 ` Tvrtko Ursulin
2016-06-28 10:37 ` [PATCH 3/4] drm/i915/hsw: Avoid early timeout during LCPLL disable/restore Imre Deak
2016-06-28 11:17 ` Tvrtko Ursulin
2016-06-28 10:37 ` [PATCH 4/4] drm/i915: Avoid early timeout during AUX transfers Imre Deak
2016-06-28 11:19 ` Tvrtko Ursulin
2016-06-28 11:00 ` ✓ Ro.CI.BAT: success for drm/i915: Avoid early timeout due to wait_for_atomic Patchwork
2016-06-28 19:17 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467111837.20290.23.camel@intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox