Re: [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

Tvrtko Ursulin
2016-06-29T15:42:02Z

On 29/06/16 16:34, Chris Wilson wrote:
> On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Replace per-engine initialization with a common half-programatic,
>> half-data driven code for ease of maintenance and compactness.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> This is the biggest pill to swallow (since our 5x5 table is only
> sparsely populated), but it looks correct, and more importantly easier to
> read.

Yeah I was out of ideas on how to improve it. Fresh mind needed to try
and spot a pattern in how MI_SEMAPHORE_SYNC_* and GEN6_*SYNC map to bits
and registers respectively, and write it as a function.

> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks!

Regards,

Tvrtko