Re: linux-firmware-i915 pull request (bxt dmc, kbl dmc)

Vivi, Rodrigo
2016-08-02T20:48:09Z

On Tue, 2016-08-02 at 14:04 +0300, Jani Nikula wrote:
> On Sat, 02 Jul 2016, "Vivi, Rodrigo" <rodrigo.vivi@intel.com> wrote:
> >
> > Hi,
> >
> > Please consider pulling i915 updates to linux-firmware.git
> >
> >
> > The following changes since commit
> > 040c24514b94fcdbd6308d986d1bde59a704a21a:
> >
> >   linux-firmware: intel: Update Broxton audio firmware (2016-06-29
> > 14:20:20 +0530)
> >
> > are available in the git repository at:
> >
> >   git://people.freedesktop.org/~vivijim/linux-firmware-i915 master
> >
> > for you to fetch changes up to
> > 19b71af5326bf28fe62ac2b1607b5e18d4b0eeb6:
> >
> >   linux-firmware/i915: Step away from symbolic links and clean up
> > repo.
> > (2016-07-01 16:07:52 -0700)
> >
> > ----------------------------------------------------------------
> > Rodrigo Vivi (3):
> >       linux-firmware: New minor DMC release for Broxton - ver1_07
> >       linux-firmware: First DMC image for Kabylake.
> >       linux-firmware/i915: Step away from symbolic links and clean
> > up
> > repo.
> >
> >  WHENCE                                            |  14 +++++-----
> > ----
> >  i915/bxt_dmc_ver1.bin                             |   2 +-
> >  i915/bxt_dmc_ver1_04.bin                          | Bin 5872 -> 0
> > bytes
> >  i915/bxt_dmc_ver1_05.bin                          | Bin 5872 -> 0
> > bytes
> >  i915/{bxt_dmc_ver1_06.bin => bxt_dmc_ver1_07.bin} | Bin 8380 ->
> > 8380
> > bytes
> >  i915/kbl_dmc_ver1.bin                             |   1 +
> >  i915/kbl_dmc_ver1_01.bin                          | Bin 0 -> 8616
> > bytes
> >  i915/skl_dmc_ver1_23.bin                          | Bin 8824 -> 0
> > bytes
> >  i915/skl_guc_ver1.bin                             | Bin 21 ->
> > 109636
> > bytes
> >  i915/skl_guc_ver1_1059.bin                        | Bin 109636 ->
> > 0
> > bytes
> >  i915/skl_guc_ver4.bin                             | Bin 18 ->
> > 128320
> > bytes
> >  i915/skl_guc_ver4_3.bin                           | Bin 128320 ->
> > 0
> > bytes
> >  12 files changed, 7 insertions(+), 10 deletions(-)
> >  delete mode 100644 i915/bxt_dmc_ver1_04.bin
> >  delete mode 100644 i915/bxt_dmc_ver1_05.bin
> >  rename i915/{bxt_dmc_ver1_06.bin => bxt_dmc_ver1_07.bin} (64%)
> >  create mode 120000 i915/kbl_dmc_ver1.bin
> >  create mode 100644 i915/kbl_dmc_ver1_01.bin
> >  delete mode 100644 i915/skl_dmc_ver1_23.bin
> >  mode change 120000 => 100644 i915/skl_guc_ver1.bin
> >  delete mode 100644 i915/skl_guc_ver1_1059.bin
> >  mode change 120000 => 100644 i915/skl_guc_ver4.bin
> >  delete mode 100644 i915/skl_guc_ver4_3.bin
> Why are you deleting old versions?

Mainly to keep it clean. OSVs pack that entire repo, I don't want i915
taking unnecessary space from final users.

I believe this is another point in favor of bringing the sym links
back.

But also because we need to remove any firmware that we know it is bad
and that would break the user. If it was blacklisted it was removed
from repo.

Yet another reason for symbolic link. If we know the firmware is bad it
is bad for previous versions as well, but if we stay with the version
hardcoded we are forcing the user to stay with a firmware that we know
it is bad.

>
> BR,
> Jani.
>
> >
> >
> > Thanks,
> > Rodrigo.
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> --
> Jani Nikula, Intel Open Source Technology Center