From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 32/44] drm/i915: Move module init/exit to i915_pci.c Date: Tue, 12 Jul 2016 13:45:02 +0300 Message-ID: <1468320302.5866.3.camel@linux.intel.com> References: <1465993109-19523-1-git-send-email-chris@chris-wilson.co.uk> <1465993109-19523-33-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 85D4D6E12E for ; Tue, 12 Jul 2016 10:45:07 +0000 (UTC) In-Reply-To: <1465993109-19523-33-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24ga2UsIDIwMTYtMDYtMTUgYXQgMTM6MTggKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBU aGUgbW9kdWxlIGluaXQvZXhpdCByb3V0aW5lcyBhcmUgYSB3cmFwcGVyIGFyb3VuZCB0aGUgUENJ IGRldmljZQo+IGluaXQvZXhpdCwgc28gbW92ZSB0aGVtIGFjcm9zcy4KPiAKPiBOb3RlIHRoYXQg aW4gb3JkZXIgdG8gYXZvaWQgZXhwb3J0aW5nIHRoZSBkcml2ZXIgc3RydWN0LCBpbnN0ZWFkIG9m Cj4gbWFuaXB1bGF0aW5nIGRyaXZlci5mZWF0dXJlcyBpbnNpZGUgaTkxNV9pbml0IHdlIGluc3Rl YWQgb3B0IHRvIHNpbXBseQo+IGV4aXQgaWYgaTkxNS5tb2Rlc2V0IGlzIGRpc2FibGVkLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBKb29uYXMg TGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog Sm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgoKPiAtLS0K PiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCA1MSArKystLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9w Y2kuYyB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+IMKgMiBmaWxl cyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCA0OSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmMKPiBpbmRleCBmNjU1NTZiOTQ5NzguLjg4MzZhM2QyNDQ2MCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IEBAIC0yOCw3ICsyOCw2IEBACj4gwqAgKi8KPiDCoAo+ IMKgI2luY2x1ZGUgCj4gLSNpbmNsdWRlIAo+IMKgI2luY2x1ZGUgCj4gwqAjaW5jbHVkZSAKPiDC oCNpbmNsdWRlIAo+IEBAIC0xNTg3LDYgKzE1ODYsOSBAQCBpbnQgaTkxNV9kcml2ZXJfbG9hZChz dHJ1Y3QgcGNpX2RldiAqcGRldiwgY29uc3Qgc3RydWN0IHBjaV9kZXZpY2VfaWQgKmVudCkKPiDC oAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXY7Cj4gwqAJaW50IHJldDsKPiDCoAo+ ICsJaWYgKGk5MTUubnVjbGVhcl9wYWdlZmxpcCkKPiArCQlkcml2ZXIuZHJpdmVyX2ZlYXR1cmVz IHw9IERSSVZFUl9BVE9NSUM7Cj4gKwo+IMKgCXJldCA9IDA7Cj4gwqAJZGV2X3ByaXYgPSBremFs bG9jKHNpemVvZigqZGV2X3ByaXYpLCBHRlBfS0VSTkVMKTsKPiDCoAlpZiAoZGV2X3ByaXYpCj4g QEAgLTMwMTMsNTAgKzMwMTUsMyBAQCBzdGF0aWMgc3RydWN0IGRybV9kcml2ZXIgZHJpdmVyID0g ewo+IMKgCS5taW5vciA9IERSSVZFUl9NSU5PUiwKPiDCoAkucGF0Y2hsZXZlbCA9IERSSVZFUl9Q QVRDSExFVkVMLAo+IMKgfTsKPiAtCj4gLXN0YXRpYyBpbnQgX19pbml0IGk5MTVfaW5pdCh2b2lk KQo+IC17Cj4gLQlleHRlcm4gc3RydWN0IHBjaV9kcml2ZXIgaTkxNV9wY2lfZHJpdmVyOwo+IC0K PiAtCS8qCj4gLQnCoCogRW5hYmxlIEtNUyBieSBkZWZhdWx0LCB1bmxlc3MgZXhwbGljaXRseSBv dmVycmlkZW4gYnkKPiAtCcKgKiBlaXRoZXIgdGhlIGk5MTUubW9kZXNldCBwcmFyYW1ldGVyIG9y IGJ5IHRoZQo+IC0JwqAqIHZnYV90ZXh0X21vZGVfZm9yY2UgYm9vdCBvcHRpb24uCj4gLQnCoCov Cj4gLQo+IC0JaWYgKGk5MTUubW9kZXNldCA9PSAwKQo+IC0JCWRyaXZlci5kcml2ZXJfZmVhdHVy ZXMgJj0gfkRSSVZFUl9NT0RFU0VUOwo+IC0KPiAtCWlmICh2Z2Fjb25fdGV4dF9mb3JjZSgpICYm IGk5MTUubW9kZXNldCA9PSAtMSkKPiAtCQlkcml2ZXIuZHJpdmVyX2ZlYXR1cmVzICY9IH5EUklW RVJfTU9ERVNFVDsKPiAtCj4gLQlpZiAoIShkcml2ZXIuZHJpdmVyX2ZlYXR1cmVzICYgRFJJVkVS X01PREVTRVQpKSB7Cj4gLQkJLyogU2lsZW50bHkgZmFpbCBsb2FkaW5nIHRvIG5vdCB1cHNldCB1 c2Vyc3BhY2UuICovCj4gLQkJRFJNX0RFQlVHX0RSSVZFUigiS01TIGFuZCBVTVMgZGlzYWJsZWQu XG4iKTsKPiAtCQlyZXR1cm4gMDsKPiAtCX0KPiAtCj4gLQlpZiAoaTkxNS5udWNsZWFyX3BhZ2Vm bGlwKQo+IC0JCWRyaXZlci5kcml2ZXJfZmVhdHVyZXMgfD0gRFJJVkVSX0FUT01JQzsKPiAtCj4g LQlyZXR1cm4gZHJtX3BjaV9pbml0KCZkcml2ZXIsICZpOTE1X3BjaV9kcml2ZXIpOwo+IC19Cj4g LQo+IC1zdGF0aWMgdm9pZCBfX2V4aXQgaTkxNV9leGl0KHZvaWQpCj4gLXsKPiAtCWV4dGVybiBz dHJ1Y3QgcGNpX2RyaXZlciBpOTE1X3BjaV9kcml2ZXI7Cj4gLQo+IC0JaWYgKCEoZHJpdmVyLmRy aXZlcl9mZWF0dXJlcyAmIERSSVZFUl9NT0RFU0VUKSkKPiAtCQlyZXR1cm47IC8qIE5ldmVyIGxv YWRlZCBhIGRyaXZlci4gKi8KPiAtCj4gLQlkcm1fcGNpX2V4aXQoJmRyaXZlciwgJmk5MTVfcGNp X2RyaXZlcik7Cj4gLX0KPiAtCj4gLW1vZHVsZV9pbml0KGk5MTVfaW5pdCk7Cj4gLW1vZHVsZV9l eGl0KGk5MTVfZXhpdCk7Cj4gLQo+IC1NT0RVTEVfQVVUSE9SKCJUdW5nc3RlbiBHcmFwaGljcywg SW5jLiIpOwo+IC1NT0RVTEVfQVVUSE9SKCJJbnRlbCBDb3Jwb3JhdGlvbiIpOwo+IC0KPiAtTU9E VUxFX0RFU0NSSVBUSU9OKERSSVZFUl9ERVNDKTsKPiAtTU9EVUxFX0xJQ0VOU0UoIkdQTCBhbmQg YWRkaXRpb25hbCByaWdodHMiKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9wY2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiBpbmRleCA5YWEw N2YzOGNhZWEuLjE0ZmM0NTZiYzYzNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3BjaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+IEBA IC0yMiw2ICsyMiw3IEBACj4gwqAgKgo+IMKgICovCj4gwqAKPiArI2luY2x1ZGUgCj4gwqAjaW5j bHVkZSAKPiDCoCNpbmNsdWRlIAo+IMKgCj4gQEAgLTQ1MiwxMCArNDUzLDUyIEBAIHN0YXRpYyB2 b2lkIGk5MTVfcGNpX3JlbW92ZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKPiDCoAo+IMKgZXh0ZXJu IGNvbnN0IHN0cnVjdCBkZXZfcG1fb3BzIGk5MTVfcG1fb3BzOwo+IMKgCj4gLXN0cnVjdCBwY2lf ZHJpdmVyIGk5MTVfcGNpX2RyaXZlciA9IHsKPiArc3RhdGljIHN0cnVjdCBwY2lfZHJpdmVyIGk5 MTVfcGNpX2RyaXZlciA9IHsKPiDCoAkubmFtZSA9IERSSVZFUl9OQU1FLAo+IMKgCS5pZF90YWJs ZSA9IHBjaWlkbGlzdCwKPiDCoAkucHJvYmUgPSBpOTE1X3BjaV9wcm9iZSwKPiDCoAkucmVtb3Zl ID0gaTkxNV9wY2lfcmVtb3ZlLAo+IMKgCS5kcml2ZXIucG0gPSAmaTkxNV9wbV9vcHMsCj4gwqB9 Owo+ICsKPiArc3RhdGljIGludCBfX2luaXQgaTkxNV9pbml0KHZvaWQpCj4gK3sKPiArCWJvb2wg dXNlX2ttcyA9IHRydWU7Cj4gKwo+ICsJLyoKPiArCcKgKiBFbmFibGUgS01TIGJ5IGRlZmF1bHQs IHVubGVzcyBleHBsaWNpdGx5IG92ZXJyaWRlbiBieQo+ICsJwqAqIGVpdGhlciB0aGUgaTkxNS5t b2Rlc2V0IHByYXJhbWV0ZXIgb3IgYnkgdGhlCj4gKwnCoCogdmdhX3RleHRfbW9kZV9mb3JjZSBi b290IG9wdGlvbi4KPiArCcKgKi8KPiArCj4gKwlpZiAoaTkxNS5tb2Rlc2V0ID09IDApCj4gKwkJ dXNlX2ttcyA9IGZhbHNlOwo+ICsKPiArCWlmICh2Z2Fjb25fdGV4dF9mb3JjZSgpICYmIGk5MTUu bW9kZXNldCA9PSAtMSkKPiArCQl1c2Vfa21zID0gZmFsc2U7Cj4gKwo+ICsJaWYgKCF1c2Vfa21z KSB7Cj4gKwkJLyogU2lsZW50bHkgZmFpbCBsb2FkaW5nIHRvIG5vdCB1cHNldCB1c2Vyc3BhY2Uu ICovCj4gKwkJRFJNX0RFQlVHX0RSSVZFUigiS01TIGFuZCBVTVMgZGlzYWJsZWQuXG4iKTsKPiAr CQlyZXR1cm4gMDsKPiArCX0KPiArCj4gKwlyZXR1cm4gcGNpX3JlZ2lzdGVyX2RyaXZlcigmaTkx NV9wY2lfZHJpdmVyKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgX19leGl0IGk5MTVfZXhpdCh2 b2lkKQo+ICt7Cj4gKwlpZiAoIWk5MTVfcGNpX2RyaXZlci5kcml2ZXIub3duZXIpCj4gKwkJcmV0 dXJuOwo+ICsKPiArCXBjaV91bnJlZ2lzdGVyX2RyaXZlcigmaTkxNV9wY2lfZHJpdmVyKTsKPiAr fQo+ICsKPiArbW9kdWxlX2luaXQoaTkxNV9pbml0KTsKPiArbW9kdWxlX2V4aXQoaTkxNV9leGl0 KTsKPiArCj4gK01PRFVMRV9BVVRIT1IoIlR1bmdzdGVuIEdyYXBoaWNzLCBJbmMuIik7Cj4gK01P RFVMRV9BVVRIT1IoIkludGVsIENvcnBvcmF0aW9uIik7Cj4gKwo+ICtNT0RVTEVfREVTQ1JJUFRJ T04oRFJJVkVSX0RFU0MpOwo+ICtNT0RVTEVfTElDRU5TRSgiR1BMIGFuZCBhZGRpdGlvbmFsIHJp Z2h0cyIpOwotLSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy CkludGVsIENvcnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=