[PATCH] drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

[PATCH] drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

[Zhi Wang]

The access right of kernel param "i915.enable_gvt" should be read-only as
it only applies during module load (and is not *runtime* writable).

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
---
 drivers/gpu/drm/i915/i915_params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 7effe68..8b13bfa 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600
 MODULE_PARM_DESC(enable_dpcd_backlight,
 	"Enable support for DPCD backlight control (default:false)");
 
-module_param_named(enable_gvt, i915.enable_gvt, bool, 0600);
+module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
 MODULE_PARM_DESC(enable_gvt,
 	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Ro.CI.BAT: success for drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

[Patchwork]

== Series Details ==

Series: drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.
URL   : https://patchwork.freedesktop.org/series/8922/
State : success

== Summary ==

Series 8922v1 drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.
http://patchwork.freedesktop.org/api/1.0/series/8922/revisions/1/mbox


fi-snb-i7-2600   total:223  pass:20   dwarn:0   dfail:0   fail:0   skip:203
ro-bdw-i5-5250u  total:223  pass:20   dwarn:0   dfail:0   fail:0   skip:203
ro-bdw-i7-5557U  total:223  pass:20   dwarn:0   dfail:0   fail:0   skip:203
ro-hsw-i3-4010u  total:223  pass:18   dwarn:0   dfail:0   fail:0   skip:205
ro-hsw-i7-4770r  total:223  pass:18   dwarn:0   dfail:0   fail:0   skip:205
ro-ilk-i7-620lm  total:223  pass:7    dwarn:0   dfail:0   fail:0   skip:216
ro-skl3-i5-6260u total:223  pass:20   dwarn:0   dfail:0   fail:0   skip:203
fi-hsw-i7-4770k failed to connect after reboot
fi-skl-i5-6260u failed to connect after reboot
fi-skl-i7-6700k failed to connect after reboot
ro-bdw-i7-5600u failed to connect after reboot
ro-bsw-n3050 failed to connect after reboot
ro-byt-n2820 failed to connect after reboot
ro-ilk1-i5-650 failed to connect after reboot
ro-ivb2-i7-3770 failed to connect after reboot
ro-ivb-i7-3770 failed to connect after reboot
ro-snb-i7-2620M failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1236/

edc0e9e drm-intel-nightly: 2016y-06m-20d-09h-47m-30s UTC integration manifest
e230193 drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Ro.CI.BAT: success for drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

[Chris Wilson]

On Mon, Jun 20, 2016 at 12:31:35PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.
> URL   : https://patchwork.freedesktop.org/series/8922/
> State : success
> 
> == Summary ==
> 
> Series 8922v1 drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.
> http://patchwork.freedesktop.org/api/1.0/series/8922/revisions/1/mbox
> 
> 
> fi-snb-i7-2600   total:223  pass:20   dwarn:0   dfail:0   fail:0   skip:203

I feel confident in pushing this one-liner without CI...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

[Joonas Lahtinen]

On ma, 2016-06-20 at 08:17 -0400, Zhi Wang wrote:
> The access right of kernel param "i915.enable_gvt" should be read-only as
> it only applies during module load (and is not *runtime* writable).
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Maybe also add,

Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>

> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 7effe68..8b13bfa 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600
>  MODULE_PARM_DESC(enable_dpcd_backlight,
>  	"Enable support for DPCD backlight control (default:false)");
>  
> -module_param_named(enable_gvt, i915.enable_gvt, bool, 0600);
> +module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
>  MODULE_PARM_DESC(enable_gvt,
>  	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

[Zhi Wang]

Thanks! :P. Welcome back.

On 07/12/16 18:50, Joonas Lahtinen wrote:
> On ma, 2016-06-20 at 08:17 -0400, Zhi Wang wrote:
>> The access right of kernel param "i915.enable_gvt" should be read-only as
>> it only applies during module load (and is not *runtime* writable).
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Maybe also add,
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
>
>> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_params.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
>> index 7effe68..8b13bfa 100644
>> --- a/drivers/gpu/drm/i915/i915_params.c
>> +++ b/drivers/gpu/drm/i915/i915_params.c
>> @@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600
>>   MODULE_PARM_DESC(enable_dpcd_backlight,
>>   	"Enable support for DPCD backlight control (default:false)");
>>
>> -module_param_named(enable_gvt, i915.enable_gvt, bool, 0600);
>> +module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
>>   MODULE_PARM_DESC(enable_gvt,
>>   	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx