Re: [PATCH v3 6/6] drm/i915/huc: Add BXT HuC Loading Support

Xiang, Haihao
2016-07-13T08:02:41Z

Hi Rodrigo,

We will use HuC on BXT.

Thanks
Haihao

> vaapi-intel-driver, the userspace component here is only using HuC
> for
> SKL for now, so I believe this one will be on hold for now, right?
>
>
>
> On Wed, 2016-07-06 at 15:24 +0100, Peter Antoine wrote:
> > This patch adds the HuC Loading for the BXT.
> > Version 1.7 of the HuC firmware.
> >
> > v2: rebased.
> > v3: rebased.
> >     changed file name to match the install package format.
> >
> > Signed-off-by: Peter Antoine <peter.antoine@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_huc_loader.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_huc_loader.c
> > b/drivers/gpu/drm/i915/intel_huc_loader.c
> > index 96cd9d8..c6d53b3 100644
> > --- a/drivers/gpu/drm/i915/intel_huc_loader.c
> > +++ b/drivers/gpu/drm/i915/intel_huc_loader.c
> > @@ -49,6 +49,9 @@
> >  #define I915_SKL_HUC_UCODE "i915/skl_huc_ver01_07_1398.bin"
> >  MODULE_FIRMWARE(I915_SKL_HUC_UCODE);
> >
> > +#define I915_BXT_HUC_UCODE "i915/bxt_huc_ver01_07_1398.bin"
> > +MODULE_FIRMWARE(I915_BXT_HUC_UCODE);
> > +
> >  /**
> >   * intel_huc_load_ucode() - DMA's the firmware
> >   * @dev: the drm device
> > @@ -157,6 +160,10 @@ void intel_huc_init(struct drm_device *dev)
> >   fw_path = I915_SKL_HUC_UCODE;
> >   huc_fw->major_ver_wanted = 1;
> >   huc_fw->minor_ver_wanted = 7;
> > + } else if (IS_BROXTON(dev_priv)) {
> > + fw_path = I915_BXT_HUC_UCODE;
> > + huc_fw->major_ver_wanted = 1;
> > + huc_fw->minor_ver_wanted = 7;
> >   }
> >
> >   if (fw_path == NULL)
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx