Re: [PATCH v3 1/6] drm/i915/guc: Make the GuC fw loading helper functions general

Dave Gordon
2016-08-11T10:54:26Z

On 11/08/16 11:49, Dave Gordon wrote:
> On 06/07/16 15:24, Peter Antoine wrote:
>> Rename some of the GuC fw loading code to make them more general. We
>> will utilise them for HuC loading as well.
>> s/intel_guc_fw/intel_uc_fw/g
>> s/GUC_FIRMWARE/UC_FIRMWARE/g
>>
>> Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,
>> such as 'guc' or 'guc_fw' either is renamed to 'uc' or removed for
>> same purpose.
>>
>> v2: rebased on top of nightly.
>> reapplied the search/replace as upstream code as changed.
>> v3: rebased again on drm-nightly.
>>
>> Signed-off-by: Alex Dai <yu.dai@intel.com>
>> Signed-off-by: Peter Antoine <peter.antoine@intel.com>
>> Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
>
> R-b can carry over again, but this will need (ANOTHER!) rebase as Chris
> has nuked one of the functions called below.
>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 12 +--
>> drivers/gpu/drm/i915/i915_guc_submission.c | 4 +-
>> drivers/gpu/drm/i915/intel_guc.h | 39 ++++----
>> drivers/gpu/drm/i915/intel_guc_loader.c | 146
>> ++++++++++++++---------------
>> 4 files changed, 101 insertions(+), 100 deletions(-)

Ignore previous message, replied to wrong version :(

.Dave.