Re: [PATCH v3 5/6] drm/i915/huc: Support HuC authentication

Dave Gordon
2016-07-29T12:39:56Z

On 29/07/16 12:33, Dave Gordon wrote:
> On 06/07/16 15:24, Peter Antoine wrote:
>> The HuC authentication is done by host2guc call. The HuC RSA keys
>> are sent to GuC for authentication.
>>
>> v2: rebased on top of drm-intel-nightly.
>> changed name format and upped version 1.7.
>> v3: rebased on top of drm-intel-nightly.
>>
>> Signed-off-by: Alex Dai <yu.dai@intel.com>
>> Signed-off-by: Peter Antoine <peter.antoine@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_guc_submission.c | 65
>> ++++++++++++++++++++++++++++++
>> drivers/gpu/drm/i915/intel_guc_fwif.h | 1 +
>> drivers/gpu/drm/i915/intel_guc_loader.c | 2 +
>> 3 files changed, 68 insertions(+)
>
> No obvious problems here.

On second thoughts ...

>> + ret = host2guc_action(guc, data, ARRAY_SIZE(data));
>> + if (ret) {
>> + DRM_ERROR("HuC: GuC did not ack Auth request\n");
>> + goto out;
>> + }
>> +
>> + /* Check authentication status, it should be done by now */
>> + ret = wait_for_atomic(
>> + (I915_READ(HUC_STATUS2) & HUC_FW_VERIFIED) > 0, 50);
>> + if (ret) {
>> + DRM_ERROR("HuC: Authentication failed\n");
>> + goto out;
>> + }

... there's another wait_for_atomic() here :(

.Dave.