* [PATCH] drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
@ 2016-07-05 12:00 Matthew Auld
2016-07-05 12:18 ` Chris Wilson
2016-07-05 13:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 5+ messages in thread
From: Matthew Auld @ 2016-07-05 12:00 UTC (permalink / raw)
To: intel-gfx
This should already be handled by drm_gem_object_release, which is
called later on.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 20123c0..9dc274c 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4908,7 +4908,6 @@ void i915_gem_free_object(struct drm_gem_object *gem_obj)
if (discard_backing_storage(obj))
obj->madv = I915_MADV_DONTNEED;
i915_gem_object_put_pages(obj);
- i915_gem_object_free_mmap_offset(obj);
BUG_ON(obj->pages);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
2016-07-05 12:00 [PATCH] drm/i915: remove superfluous i915_gem_object_free_mmap_offset call Matthew Auld
@ 2016-07-05 12:18 ` Chris Wilson
2016-07-05 13:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
1 sibling, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2016-07-05 12:18 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
On Tue, Jul 05, 2016 at 01:00:19PM +0100, Matthew Auld wrote:
> This should already be handled by drm_gem_object_release, which is
> called later on.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
2016-07-05 12:00 [PATCH] drm/i915: remove superfluous i915_gem_object_free_mmap_offset call Matthew Auld
2016-07-05 12:18 ` Chris Wilson
@ 2016-07-05 13:21 ` Patchwork
2016-07-14 12:14 ` Matthew Auld
1 sibling, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-07-05 13:21 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
URL : https://patchwork.freedesktop.org/series/9516/
State : failure
== Summary ==
Series 9516v1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
http://patchwork.freedesktop.org/api/1.0/series/9516/revisions/1/mbox
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-cmd:
pass -> FAIL (ro-byt-n2820)
Subgroup basic-batch-kernel-default-wb:
pass -> DMESG-FAIL (ro-bdw-i7-5557U)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
skip -> DMESG-WARN (ro-bdw-i7-5557U)
Subgroup suspend-read-crc-pipe-c:
pass -> SKIP (fi-skl-i5-6260u)
fi-kbl-qkkr total:234 pass:162 dwarn:28 dfail:1 fail:2 skip:41
fi-skl-i5-6260u total:234 pass:204 dwarn:0 dfail:1 fail:2 skip:27
fi-skl-i7-6700k total:234 pass:191 dwarn:0 dfail:1 fail:2 skip:40
fi-snb-i7-2600 total:234 pass:178 dwarn:0 dfail:0 fail:2 skip:54
ro-bdw-i5-5250u total:229 pass:204 dwarn:1 dfail:1 fail:0 skip:23
ro-bdw-i7-5557U total:229 pass:203 dwarn:2 dfail:2 fail:0 skip:22
ro-bdw-i7-5600u total:229 pass:190 dwarn:0 dfail:1 fail:0 skip:38
ro-byt-n2820 total:229 pass:180 dwarn:0 dfail:1 fail:3 skip:45
ro-hsw-i3-4010u total:229 pass:197 dwarn:0 dfail:1 fail:0 skip:31
ro-hsw-i7-4770r total:229 pass:197 dwarn:0 dfail:1 fail:0 skip:31
ro-ilk-i7-620lm total:229 pass:157 dwarn:0 dfail:1 fail:1 skip:70
ro-ilk1-i5-650 total:224 pass:157 dwarn:0 dfail:1 fail:1 skip:65
ro-ivb-i7-3770 total:229 pass:188 dwarn:0 dfail:1 fail:0 skip:40
ro-skl3-i5-6260u total:229 pass:208 dwarn:1 dfail:1 fail:0 skip:19
ro-snb-i7-2620M total:229 pass:179 dwarn:0 dfail:1 fail:1 skip:48
ro-bsw-n3050 failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1418/
2a6e307 drm-intel-nightly: 2016y-07m-05d-11h-50m-09s UTC integration manifest
61651dc drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
2016-07-05 13:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-07-14 12:14 ` Matthew Auld
2016-07-14 13:14 ` Joonas Lahtinen
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Auld @ 2016-07-14 12:14 UTC (permalink / raw)
To: Intel Graphics Development
On 5 July 2016 at 14:21, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
> URL : https://patchwork.freedesktop.org/series/9516/
> State : failure
>
> == Summary ==
>
> Series 9516v1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
> http://patchwork.freedesktop.org/api/1.0/series/9516/revisions/1/mbox
>
> Test gem_exec_flush:
> Subgroup basic-batch-kernel-default-cmd:
> pass -> FAIL (ro-byt-n2820)
https://bugs.freedesktop.org/show_bug.cgi?id=95372
> Subgroup basic-batch-kernel-default-wb:
> pass -> DMESG-FAIL (ro-bdw-i7-5557U)
Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96927
> Test kms_pipe_crc_basic:
> Subgroup suspend-read-crc-pipe-a:
> skip -> DMESG-WARN (ro-bdw-i7-5557U)
Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96913
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
2016-07-14 12:14 ` Matthew Auld
@ 2016-07-14 13:14 ` Joonas Lahtinen
0 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2016-07-14 13:14 UTC (permalink / raw)
To: Matthew Auld, Intel Graphics Development
Merged, thanks for the patch and review.
Regards, Joonas
On to, 2016-07-14 at 13:14 +0100, Matthew Auld wrote:
> On 5 July 2016 at 14:21, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> >
> > == Series Details ==
> >
> > Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
> > URL : https://patchwork.freedesktop.org/series/9516/
> > State : failure
> >
> > == Summary ==
> >
> > Series 9516v1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
> > http://patchwork.freedesktop.org/api/1.0/series/9516/revisions/1/mbox
> >
> > Test gem_exec_flush:
> > Subgroup basic-batch-kernel-default-cmd:
> > pass -> FAIL (ro-byt-n2820)
> https://bugs.freedesktop.org/show_bug.cgi?id=95372
>
> >
> > Subgroup basic-batch-kernel-default-wb:
> > pass -> DMESG-FAIL (ro-bdw-i7-5557U)
> Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96927
>
> >
> > Test kms_pipe_crc_basic:
> > Subgroup suspend-read-crc-pipe-a:
> > skip -> DMESG-WARN (ro-bdw-i7-5557U)
> Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96913
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-14 13:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-05 12:00 [PATCH] drm/i915: remove superfluous i915_gem_object_free_mmap_offset call Matthew Auld
2016-07-05 12:18 ` Chris Wilson
2016-07-05 13:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-14 12:14 ` Matthew Auld
2016-07-14 13:14 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox