From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 5/7] drm/i915: Use & instead if == to check for rotations Date: Wed, 20 Jul 2016 17:01:00 +0300 Message-ID: <1469023260.11191.13.camel@linux.intel.com> References: <1469020693-24356-1-git-send-email-ville.syrjala@linux.intel.com> <1469020693-24356-6-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1469020693-24356-6-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24ga2UsIDIwMTYtMDctMjAgYXQgMTY6MTggKzAzMDAsIHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tIHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gCj4gVXNpbmcgPT0gdG8gY2hlY2sgZm9yIDE4MCBkZWdyZWUgcm90YXRp b24gb25seSB3b3JrcyBhcyBsb25nIGFzIHRoZQo+IHJlZmxlY3Rpb24gYml0cyBhcmVuJ3Qgc2V0 LiBUaGF0IHdpbGwgY2hhbmdlIHNvb24gZW5vdWdoIGZvciBDSFYsIHNvCj4gbGV0J3Mgc3RvcCBk b2luZyB0aGluZ3MgdGhlIHdyb25nIHdheS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEpvb25h cyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KClJlYWRpbmcgdGhy b3VnaCB0aGUgcGF0Y2ggbWFrZXMgbWUgd2FubmEgZG8gdGhlIGNoYW5nZTsKCiNkZWZpbmUgRFJN X1JPVEFURV8xODAgQklUKHgpCgpldmVuIG1vcmUuIE1heWJlIHdpdGggY29jY2luZWxsZS4KClJl Z2FyZHMsIEpvb25hcwoKPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDkgKysrKystLS0tCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUu Y8KgwqB8IDYgKysrLS0tCj4gwqAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXgg OTNlY2IyNTljNWNlLi43OWMxYThiODlkMWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gQEAgLTI2ODgsNyArMjY4OCw3IEBAIHN0YXRpYyB2b2lkIGk5eHhfdXBkYXRl X3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcHJpbWFyeSwKPiDCoAkJaW50ZWxfY3J0 Yy0+ZHNwYWRkcl9vZmZzZXQgPSBsaW5lYXJfb2Zmc2V0Owo+IMKgCX0KPiDCoAo+IC0JaWYgKHJv dGF0aW9uID09IEJJVChEUk1fUk9UQVRFXzE4MCkpIHsKPiArCWlmIChyb3RhdGlvbiAmIEJJVChE Uk1fUk9UQVRFXzE4MCkpIHsKPiDCoAkJZHNwY250ciB8PSBESVNQUExBTkVfUk9UQVRFXzE4MDsK PiDCoAo+IMKgCQl4ICs9IChjcnRjX3N0YXRlLT5waXBlX3NyY193IC0gMSk7Cj4gQEAgLTI3OTEs NyArMjc5MSw4IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3VwZGF0ZV9wcmltYXJ5X3BsYW5lKHN0 cnVjdCBkcm1fcGxhbmUgKnByaW1hcnksCj4gwqAJCWludGVsX2NvbXB1dGVfdGlsZV9vZmZzZXQo JngsICZ5LCBmYiwgMCwKPiDCoAkJCQkJwqDCoGZiLT5waXRjaGVzWzBdLCByb3RhdGlvbik7Cj4g wqAJbGluZWFyX29mZnNldCAtPSBpbnRlbF9jcnRjLT5kc3BhZGRyX29mZnNldDsKPiAtCWlmIChy b3RhdGlvbiA9PSBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gKwo+ICsJaWYgKHJvdGF0aW9uICYg QklUKERSTV9ST1RBVEVfMTgwKSkgewo+IMKgCQlkc3BjbnRyIHw9IERJU1BQTEFORV9ST1RBVEVf MTgwOwo+IMKgCj4gwqAJCWlmICghSVNfSEFTV0VMTChkZXYpICYmICFJU19CUk9BRFdFTEwoZGV2 KSkgewo+IEBAIC0xMDI2Myw3ICsxMDI2NCw3IEBAIHN0YXRpYyB2b2lkIGk5eHhfdXBkYXRlX2N1 cnNvcihzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIHUzMiBiYXNlLAo+IMKgCQlpZiAoSEFTX0RESShk ZXYpKQo+IMKgCQkJY250bCB8PSBDVVJTT1JfUElQRV9DU0NfRU5BQkxFOwo+IMKgCj4gLQkJaWYg KHBsYW5lX3N0YXRlLT5iYXNlLnJvdGF0aW9uID09IEJJVChEUk1fUk9UQVRFXzE4MCkpCj4gKwkJ aWYgKHBsYW5lX3N0YXRlLT5iYXNlLnJvdGF0aW9uICYgQklUKERSTV9ST1RBVEVfMTgwKSkKPiDC oAkJCWNudGwgfD0gQ1VSU09SX1JPVEFURV8xODA7Cj4gwqAJfQo+IMKgCj4gQEAgLTEwMzA5LDcg KzEwMzEwLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y191cGRhdGVfY3Vyc29yKHN0cnVjdCBk cm1fY3J0YyAqY3J0YywKPiDCoAo+IMKgCQkvKiBJTEsrIGRvIHRoaXMgYXV0b21hZ2ljYWxseSAq Lwo+IMKgCQlpZiAoSEFTX0dNQ0hfRElTUExBWShkZXYpICYmCj4gLQkJwqDCoMKgwqBwbGFuZV9z dGF0ZS0+YmFzZS5yb3RhdGlvbiA9PSBCSVQoRFJNX1JPVEFURV8xODApKSB7Cj4gKwkJwqDCoMKg wqBwbGFuZV9zdGF0ZS0+YmFzZS5yb3RhdGlvbiAmIEJJVChEUk1fUk9UQVRFXzE4MCkpIHsKPiDC oAkJCWJhc2UgKz0gKHBsYW5lX3N0YXRlLT5iYXNlLmNydGNfaCAqCj4gwqAJCQkJwqBwbGFuZV9z dGF0ZS0+YmFzZS5jcnRjX3cgLSAxKSAqIDQ7Cj4gwqAJCX0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9zcHJpdGUuYwo+IGluZGV4IGJjNDFjMWJiYTA0Yy4uNmI4MTVkNTdkNzVhIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBAQCAtNDQ0LDcgKzQ0NCw3IEBAIHZsdl91cGRh dGVfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqZHBsYW5lLAo+IMKgCQkJCQkJwqDCoMKgZmItPnBp dGNoZXNbMF0sIHJvdGF0aW9uKTsKPiDCoAlsaW5lYXJfb2Zmc2V0IC09IHNwcnN1cmZfb2Zmc2V0 Owo+IMKgCj4gLQlpZiAocm90YXRpb24gPT0gQklUKERSTV9ST1RBVEVfMTgwKSkgewo+ICsJaWYg KHJvdGF0aW9uICYgQklUKERSTV9ST1RBVEVfMTgwKSkgewo+IMKgCQlzcHJjdGwgfD0gU1BfUk9U QVRFXzE4MDsKPiDCoAo+IMKgCQl4ICs9IHNyY193Owo+IEBAIC01NzcsNyArNTc3LDcgQEAgaXZi X3VwZGF0ZV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiDCoAkJCQkJCcKgwqDCoGZi LT5waXRjaGVzWzBdLCByb3RhdGlvbik7Cj4gwqAJbGluZWFyX29mZnNldCAtPSBzcHJzdXJmX29m ZnNldDsKPiDCoAo+IC0JaWYgKHJvdGF0aW9uID09IEJJVChEUk1fUk9UQVRFXzE4MCkpIHsKPiAr CWlmIChyb3RhdGlvbiAmIEJJVChEUk1fUk9UQVRFXzE4MCkpIHsKPiDCoAkJc3ByY3RsIHw9IFNQ UklURV9ST1RBVEVfMTgwOwo+IMKgCj4gwqAJCS8qIEhTVyBhbmQgQkRXIGRvZXMgdGhpcyBhdXRv bWFnaWNhbGx5IGluIGhhcmR3YXJlICovCj4gQEAgLTcxNCw3ICs3MTQsNyBAQCBpbGtfdXBkYXRl X3BsYW5lKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+IMKgCQkJCQkJwqDCoMKgZmItPnBpdGNo ZXNbMF0sIHJvdGF0aW9uKTsKPiDCoAlsaW5lYXJfb2Zmc2V0IC09IGR2c3N1cmZfb2Zmc2V0Owo+ IMKgCj4gLQlpZiAocm90YXRpb24gPT0gQklUKERSTV9ST1RBVEVfMTgwKSkgewo+ICsJaWYgKHJv dGF0aW9uICYgQklUKERSTV9ST1RBVEVfMTgwKSkgewo+IMKgCQlkdnNjbnRyIHw9IERWU19ST1RB VEVfMTgwOwo+IMKgCj4gwqAJCXggKz0gc3JjX3c7Ci0tIApKb29uYXMgTGFodGluZW4KT3BlbiBT b3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9yYXRpb24KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==