Re: [PATCH] drm/i915: Rename engine->semaphore.sync_to, engine->sempahore.signal locals

Joonas Lahtinen
2016-07-22T09:38:59Z

On pe, 2016-07-22 at 10:31 +0100, Chris Wilson wrote:
> On Fri, Jul 22, 2016 at 12:28:11PM +0300, Joonas Lahtinen wrote:
> >
> > On pe, 2016-07-22 at 10:14 +0100, Chris Wilson wrote:
> > >
> > >   /* When the !RCS engines idle waiting upon a semaphore, they lose their
> > >    * pagetables and we must reload them before executing the batch.
> > >    * We do this on the i915_switch_context() following the wait and
> > >    * before the dispatch.
> > >    */
> > > - ppgtt = wait->ctx->ppgtt;
> > > - if (ppgtt && wait->engine->id != RCS)
> > > - ppgtt->pd_dirty_rings |= intel_engine_flag(wait->engine);
> > > + ppgtt = req->ctx->ppgtt;
> > This assignment could still be lifted up.
> I'm not a huge believe in gcc's live range analysis :)

It's Open Source :P We can optimize the culprit once there is need.

> -Chris
> >
> >
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation