Re: [PATCH 01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit

Chris Wilson
2016-07-21T12:09:43Z

On Thu, Jul 21, 2016 at 02:26:19PM +0300, Joonas Lahtinen wrote:
> On ke, 2016-07-20 at 14:11 +0100, Chris Wilson wrote:
> > Both perform the same actions with more or less indirection, so just
> > unify the code.
> >
>
> Don't really like removing the engine = req->engine aliases, but seems
> like req->engine is used plenty already. And assuming this was a
> mechanical change with no hidden functional changes. Then,

I've added some engine = req->engine where there was repetition within
the funcion.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre