Re: [PATCH] drm/i915/dmc: Accept symbolic link in firmware name

chris
2016-07-11T12:39:13Z

On Mon, Jul 11, 2016 at 02:23:48PM +0300, Imre Deak wrote:
> On to, 2016-07-07 at 17:57 +0300, Mika Kuoppala wrote:
> > "Vivi, Rodrigo" <rodrigo.vivi@intel.com> writes:
> >
> > > Nak.
> > >
> > > I don't intend to update the symbolic links on linux-firmware.git
> > > repository anymore so if we receive a new minor version update we
> > > are
> > > not going to load.
> > >
> > > I was the one advocating in the favor for the symbolic link
> > > flexibility
> > > but I lost the discussions for the stability and validation etc.
> > >
> >
> > And I was one advocating in favor of getting rid of symlink. But the
> > filename versioning is superfluous as the contents has the version
> > info
> > which we can solely rely to not run something we dont want.
> >
> > So I am not sure what we lose in stability and validation front
> > with the strict version check.
>
> Bisection is more cumbersome with a symlink.

Did you miss a without there? Because when bisecting the kernel it's
harder without the symlink as the build breaks otherwise and the runtime
is not bisectable either.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre