From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 13/18] drm/i915: Stop passing caller's num_dwords to engine->semaphore.signal() Date: Fri, 22 Jul 2016 11:15:59 +0300 Message-ID: <1469175359.5916.14.camel@linux.intel.com> References: <1469020330-1071-1-git-send-email-chris@chris-wilson.co.uk> <1469020330-1071-14-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 68D696EAC5 for ; Fri, 22 Jul 2016 08:16:02 +0000 (UTC) In-Reply-To: <1469020330-1071-14-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24ga2UsIDIwMTYtMDctMjAgYXQgMTQ6MTIgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBS YXRoZXIgdGhhbiBwYXNzIGluIHRoZSBudW1fZHdvcmRzIHRoYXQgdGhlIGNhbGxlciB3aXNoZXMg dG8gdXNlIGFmdGVyCj4gdGhlIHNpZ25hbCBjb21tYW5kIHBhY2tldCwgc3BsaXQgdGhlIGJyZWFk Y3J1bWIgZW1pc3Npb24gaW50byB0d28gcGhhc2VzCj4gYW5kIGhhdmUgYm90aCB0aGUgc2lnbmFs IGFuZCBicmVhZGNydW1iIGluZGl2aWRpdWFsbHkgYWNxdWlyZSBzcGFjZSBvbgo+IHRoZSByaW5n LiBUaGlzIG1ha2VzIHRoZSBpbnRlcmZhY2Ugc2ltcGxlciBmb3IgdGhlIHJlYWRlciwgYW5kIHdp bGwKPiBzaW1wbGlmeSBmb3IgcGF0Y2hlcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3JpbmdidWZmZXIuYyB8IDUxICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIHzCoMKgNCAr LS0KPiDCoDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IDkwN2Q5 MzNkNjJhYS4uOWM2Njc0NWZjOGQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp bmdidWZmZXIuYwo+IEBAIC0xMzA4LDEwICsxMzA4LDggQEAgc3RhdGljIHZvaWQgcmVuZGVyX3Jp bmdfY2xlYW51cChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gwqAJaW50ZWxfZmlu aV9waXBlX2NvbnRyb2woZW5naW5lKTsKPiDCoH0KPiDCoAo+IC1zdGF0aWMgaW50IGdlbjhfcmNz X3NpZ25hbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnNpZ25hbGxlcl9yZXEsCj4gLQkJ CcKgwqDCoHVuc2lnbmVkIGludCBudW1fZHdvcmRzKQo+ICtzdGF0aWMgaW50IGdlbjhfcmNzX3Np Z25hbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnNpZ25hbGxlcl9yZXEpCj4gwqB7Cj4g LSNkZWZpbmUgTUJPWF9VUERBVEVfRFdPUkRTIDgKPiDCoAlzdHJ1Y3QgaW50ZWxfcmluZyAqc2ln bmFsbGVyID0gc2lnbmFsbGVyX3JlcS0+cmluZzsKPiDCoAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSBzaWduYWxsZXJfcmVxLT5pOTE1Owo+IMKgCXN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKndhaXRlcjsKPiBAQCAtMTMxOSwxMCArMTMxNyw3IEBAIHN0YXRpYyBpbnQgZ2VuOF9y Y3Nfc2lnbmFsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSwKPiDC oAlpbnQgcmV0LCBudW1fcmluZ3M7Cj4gwqAKPiDCoAludW1fcmluZ3MgPSBod2VpZ2h0MzIoSU5U RUxfSU5GTyhkZXZfcHJpdiktPnJpbmdfbWFzayk7Cj4gLQludW1fZHdvcmRzICs9IChudW1fcmlu Z3MtMSkgKiBNQk9YX1VQREFURV9EV09SRFM7Cj4gLSN1bmRlZiBNQk9YX1VQREFURV9EV09SRFMK PiAtCj4gLQlyZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHNpZ25hbGxlcl9yZXEsIG51bV9kd29yZHMp Owo+ICsJcmV0ID0gaW50ZWxfcmluZ19iZWdpbihzaWduYWxsZXJfcmVxLCAobnVtX3JpbmdzLTEp ICogOCk7CgpNYWdpYyBudW1iZXIuIEp1c3QgbWFrZSB0aGUgZGVmaW5lcyBHRU4/Xz9DU19NQk9Y X1VQREFURV9EV09SRFM/wqAKPiDCoAlpZiAocmV0KQo+IMKgCQlyZXR1cm4gcmV0Owo+IMKgCj4g QEAgLTEzNDYsMTQgKzEzNDEsMTMgQEAgc3RhdGljIGludCBnZW44X3Jjc19zaWduYWwoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxLAo+IMKgCQkJCU1JX1NFTUFQSE9S RV9UQVJHRVQod2FpdGVyLT5od19pZCkpOwo+IMKgCQlpbnRlbF9yaW5nX2VtaXQoc2lnbmFsbGVy LCAwKTsKPiDCoAl9Cj4gKwlpbnRlbF9yaW5nX2FkdmFuY2Uoc2lnbmFsbGVyKTsKPiDCoAo+IMKg CXJldHVybiAwOwo+IMKgfQo+IMKgCj4gLXN0YXRpYyBpbnQgZ2VuOF94Y3Nfc2lnbmFsKHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSwKPiAtCQkJwqDCoMKgdW5zaWdu ZWQgaW50IG51bV9kd29yZHMpCj4gK3N0YXRpYyBpbnQgZ2VuOF94Y3Nfc2lnbmFsKHN0cnVjdCBk cm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSkKPiDCoHsKPiAtI2RlZmluZSBNQk9Y X1VQREFURV9EV09SRFMgNgo+IMKgCXN0cnVjdCBpbnRlbF9yaW5nICpzaWduYWxsZXIgPSBzaWdu YWxsZXJfcmVxLT5yaW5nOwo+IMKgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHNpZ25hbGxlcl9yZXEtPmk5MTU7Cj4gwqAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqd2FpdGVy Owo+IEBAIC0xMzYxLDEwICsxMzU1LDcgQEAgc3RhdGljIGludCBnZW44X3hjc19zaWduYWwoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxLAo+IMKgCWludCByZXQsIG51 bV9yaW5nczsKPiDCoAo+IMKgCW51bV9yaW5ncyA9IGh3ZWlnaHQzMihJTlRFTF9JTkZPKGRldl9w cml2KS0+cmluZ19tYXNrKTsKPiAtCW51bV9kd29yZHMgKz0gKG51bV9yaW5ncy0xKSAqIE1CT1hf VVBEQVRFX0RXT1JEUzsKPiAtI3VuZGVmIE1CT1hfVVBEQVRFX0RXT1JEUwo+IC0KPiAtCXJldCA9 IGludGVsX3JpbmdfYmVnaW4oc2lnbmFsbGVyX3JlcSwgbnVtX2R3b3Jkcyk7Cj4gKwlyZXQgPSBp bnRlbF9yaW5nX2JlZ2luKHNpZ25hbGxlcl9yZXEsIChudW1fcmluZ3MtMSkgKiA2KTsKCk1hZ2lj IG51bWJlciwgc2VlIGFib3ZlLgoKPiDCoAlpZiAocmV0KQo+IMKgCQlyZXR1cm4gcmV0Owo+IMKg Cj4gQEAgLTEzODYsMTIgKzEzNzcsMTIgQEAgc3RhdGljIGludCBnZW44X3hjc19zaWduYWwoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxLAo+IMKgCQkJCU1JX1NFTUFQ SE9SRV9UQVJHRVQod2FpdGVyLT5od19pZCkpOwo+IMKgCQlpbnRlbF9yaW5nX2VtaXQoc2lnbmFs bGVyLCAwKTsKPiDCoAl9Cj4gKwlpbnRlbF9yaW5nX2FkdmFuY2Uoc2lnbmFsbGVyKTsKPiDCoAo+ IMKgCXJldHVybiAwOwo+IMKgfQo+IMKgCj4gLXN0YXRpYyBpbnQgZ2VuNl9zaWduYWwoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxLAo+IC0JCcKgwqDCoMKgwqDCoMKg dW5zaWduZWQgaW50IG51bV9kd29yZHMpCj4gK3N0YXRpYyBpbnQgZ2VuNl9zaWduYWwoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxKQo+IMKgewo+IMKgCXN0cnVjdCBp bnRlbF9yaW5nICpzaWduYWxsZXIgPSBzaWduYWxsZXJfcmVxLT5yaW5nOwo+IMKgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHNpZ25hbGxlcl9yZXEtPmk5MTU7Cj4gQEAgLTEz OTksMTIgKzEzOTAsOCBAQCBzdGF0aWMgaW50IGdlbjZfc2lnbmFsKHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSwKPiDCoAllbnVtIGludGVsX2VuZ2luZV9pZCBpZDsK PiDCoAlpbnQgcmV0LCBudW1fcmluZ3M7Cj4gwqAKPiAtI2RlZmluZSBNQk9YX1VQREFURV9EV09S RFMgMwo+IMKgCW51bV9yaW5ncyA9IGh3ZWlnaHQzMihJTlRFTF9JTkZPKGRldl9wcml2KS0+cmlu Z19tYXNrKTsKPiAtCW51bV9kd29yZHMgKz0gcm91bmRfdXAoKG51bV9yaW5ncy0xKSAqIE1CT1hf VVBEQVRFX0RXT1JEUywgMik7Cj4gLSN1bmRlZiBNQk9YX1VQREFURV9EV09SRFMKPiAtCj4gLQly ZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHNpZ25hbGxlcl9yZXEsIG51bV9kd29yZHMpOwo+ICsJcmV0 ID0gaW50ZWxfcmluZ19iZWdpbihzaWduYWxsZXJfcmVxLCByb3VuZF91cCgobnVtX3JpbmdzLTEp ICogMywgMikpOwoKTWFnaWMuCgo+IMKgCWlmIChyZXQpCj4gwqAJCXJldHVybiByZXQ7Cj4gwqAK PiBAQCAtMTQyMiw2ICsxNDA5LDcgQEAgc3RhdGljIGludCBnZW42X3NpZ25hbChzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnNpZ25hbGxlcl9yZXEsCj4gwqAJLyogSWYgbnVtX2R3b3JkcyB3 YXMgcm91bmRlZCwgbWFrZSBzdXJlIHRoZSB0YWlsIHBvaW50ZXIgaXMgY29ycmVjdCAqLwo+IMKg CWlmIChudW1fcmluZ3MgJSAyID09IDApCj4gwqAJCWludGVsX3JpbmdfZW1pdChzaWduYWxsZXIs IE1JX05PT1ApOwo+ICsJaW50ZWxfcmluZ19hZHZhbmNlKHNpZ25hbGxlcik7Cj4gwqAKPiDCoAly ZXR1cm4gMDsKPiDCoH0KPiBAQCAtMTQzOSwxMSArMTQyNywxMyBAQCBzdGF0aWMgaW50IGdlbjZf ZW1pdF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQo+IMKgCXN0cnVj dCBpbnRlbF9yaW5nICpyaW5nID0gcmVxLT5yaW5nOwo+IMKgCWludCByZXQ7Cj4gwqAKPiAtCWlm IChyZXEtPmVuZ2luZS0+c2VtYXBob3JlLnNpZ25hbCkKPiAtCQlyZXQgPSByZXEtPmVuZ2luZS0+ c2VtYXBob3JlLnNpZ25hbChyZXEsIDQpOwo+IC0JZWxzZQo+IC0JCXJldCA9IGludGVsX3Jpbmdf YmVnaW4ocmVxLCA0KTsKPiArCWlmIChyZXEtPmVuZ2luZS0+c2VtYXBob3JlLnNpZ25hbCkgewo+ ICsJCXJldCA9IHJlcS0+ZW5naW5lLT5zZW1hcGhvcmUuc2lnbmFsKHJlcSk7Cj4gKwkJaWYgKHJl dCkKPiArCQkJcmV0dXJuIHJldDsKPiArCX0KPiDCoAoKQW4gYWxpYXMgImVuZ2luZSIgd291bGQg YmUgY29vbCB3aGlsZSB0b3VjaGluZywgaXQgaXMgdGhlcmUgZm9yIHJpbmcsCnRvby4KCj4gKwly ZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHJlcSwgNCk7CgpNYWdpYy4KCj4gwqAJaWYgKHJldCkKPiDC oAkJcmV0dXJuIHJldDsKPiDCoAo+IEBAIC0xNDY0LDEwICsxNDU0LDEzIEBAIHN0YXRpYyBpbnQg Z2VuOF9yZW5kZXJfZW1pdF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx KQo+IMKgCXN0cnVjdCBpbnRlbF9yaW5nICpyaW5nID0gcmVxLT5yaW5nOwo+IMKgCWludCByZXQ7 Cj4gwqAKPiAtCWlmIChlbmdpbmUtPnNlbWFwaG9yZS5zaWduYWwpCj4gLQkJcmV0ID0gZW5naW5l LT5zZW1hcGhvcmUuc2lnbmFsKHJlcSwgOCk7Cj4gLQllbHNlCj4gLQkJcmV0ID0gaW50ZWxfcmlu Z19iZWdpbihyZXEsIDgpOwo+ICsJaWYgKGVuZ2luZS0+c2VtYXBob3JlLnNpZ25hbCkgewo+ICsJ CXJldCA9IGVuZ2luZS0+c2VtYXBob3JlLnNpZ25hbChyZXEpOwo+ICsJCWlmIChyZXQpCj4gKwkJ CXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJcmV0ID0gaW50ZWxfcmluZ19iZWdpbihyZXEsIDgp OwoKUHJlLWV4aXN0aW5nIG1hZ2ljLCBubyBleGN1c2Ugbm90IHRvIGNvbnZlcnQuCgpSZWdhcmRz LCBKb29uYXMKCj4gwqAJaWYgKHJldCkKPiDCoAkJcmV0dXJuIHJldDsKPiDCoAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCA4NTZiNzMyZGRiYmQuLjA4ZTg2 MjA0YTNkNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVm ZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBA QCAtMjc4LDkgKzI3OCw3IEBAIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mgewo+IMKgCQlpbnQJKCpz eW5jX3RvKShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnRvX3JlcSwKPiDCoAkJCQnCoMKg wqBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpmcm9tLAo+IMKgCQkJCcKgwqDCoHUzMiBzZXFubyk7 Cj4gLQkJaW50CSgqc2lnbmFsKShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnNpZ25hbGxl cl9yZXEsCj4gLQkJCQnCoMKgLyogbnVtX2R3b3JkcyBuZWVkZWQgYnkgY2FsbGVyICovCj4gLQkJ CQnCoMKgdW5zaWduZWQgaW50IG51bV9kd29yZHMpOwo+ICsJCWludAkoKnNpZ25hbCkoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxKTsKPiDCoAl9IHNlbWFwaG9yZTsK PiDCoAo+IMKgCS8qIEV4ZWNsaXN0cyAqLwotLSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNl IFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=