From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 24/31] drm/i915: Stop passing caller's num_dwords to engine->semaphore.signal() Date: Mon, 25 Jul 2016 12:53:53 +0300 Message-ID: <1469440433.5495.43.camel@linux.intel.com> References: <1469432687-22756-1-git-send-email-chris@chris-wilson.co.uk> <1469432687-22756-25-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C20C6E35C for ; Mon, 25 Jul 2016 09:53:56 +0000 (UTC) In-Reply-To: <1469432687-22756-25-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gbWEsIDIwMTYtMDctMjUgYXQgMDg6NDQgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBS YXRoZXIgdGhhbiBwYXNzIGluIHRoZSBudW1fZHdvcmRzIHRoYXQgdGhlIGNhbGxlciB3aXNoZXMg dG8gdXNlIGFmdGVyCj4gdGhlIHNpZ25hbCBjb21tYW5kIHBhY2tldCwgc3BsaXQgdGhlIGJyZWFk Y3J1bWIgZW1pc3Npb24gaW50byB0d28gcGhhc2VzCj4gYW5kIGhhdmUgYm90aCB0aGUgc2lnbmFs IGFuZCBicmVhZGNydW1iIGluZGl2aWRpdWFsbHkgYWNxdWlyZSBzcGFjZSBvbgo+IHRoZSByaW5n LiBUaGlzIG1ha2VzIHRoZSBpbnRlcmZhY2Ugc2ltcGxlciBmb3IgdGhlIHJlYWRlciwgYW5kIHdp bGwKPiBzaW1wbGlmeSBmb3IgcGF0Y2hlcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KClJldmlld2VkLWJ5OiBKb29uYXMgTGFodGlu ZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+IMKgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgNTEgKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgg fMKgwqA0ICstLQo+IMKgMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAzMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu Z2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5k ZXggMmZhN2RiNTMzMWMzLi42OGRmNjg5YTlkMWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTEzMjIsMTAgKzEzMjIsOCBAQCBzdGF0aWMgdm9pZCBy ZW5kZXJfcmluZ19jbGVhbnVwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiDCoAlp bnRlbF9maW5pX3BpcGVfY29udHJvbChlbmdpbmUpOwo+IMKgfQo+IMKgCj4gLXN0YXRpYyBpbnQg Z2VuOF9yY3Nfc2lnbmFsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3Jl cSwKPiAtCQkJwqDCoMKgdW5zaWduZWQgaW50IG51bV9kd29yZHMpCj4gK3N0YXRpYyBpbnQgZ2Vu OF9yY3Nfc2lnbmFsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSkK PiDCoHsKPiAtI2RlZmluZSBNQk9YX1VQREFURV9EV09SRFMgOAo+IMKgCXN0cnVjdCBpbnRlbF9y aW5nICpzaWduYWxsZXIgPSBzaWduYWxsZXJfcmVxLT5yaW5nOwo+IMKgCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IHNpZ25hbGxlcl9yZXEtPmk5MTU7Cj4gwqAJc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqd2FpdGVyOwo+IEBAIC0xMzMzLDEwICsxMzMxLDcgQEAgc3RhdGljIGlu dCBnZW44X3Jjc19zaWduYWwoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJf cmVxLAo+IMKgCWludCByZXQsIG51bV9yaW5nczsKPiDCoAo+IMKgCW51bV9yaW5ncyA9IGh3ZWln aHQzMihJTlRFTF9JTkZPKGRldl9wcml2KS0+cmluZ19tYXNrKTsKPiAtCW51bV9kd29yZHMgKz0g KG51bV9yaW5ncy0xKSAqIE1CT1hfVVBEQVRFX0RXT1JEUzsKPiAtI3VuZGVmIE1CT1hfVVBEQVRF X0RXT1JEUwo+IC0KPiAtCXJldCA9IGludGVsX3JpbmdfYmVnaW4oc2lnbmFsbGVyX3JlcSwgbnVt X2R3b3Jkcyk7Cj4gKwlyZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHNpZ25hbGxlcl9yZXEsIChudW1f cmluZ3MtMSkgKiA4KTsKPiDCoAlpZiAocmV0KQo+IMKgCQlyZXR1cm4gcmV0Owo+IMKgCj4gQEAg LTEzNjAsMTQgKzEzNTUsMTMgQEAgc3RhdGljIGludCBnZW44X3Jjc19zaWduYWwoc3RydWN0IGRy bV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxLAo+IMKgCQkJCU1JX1NFTUFQSE9SRV9U QVJHRVQod2FpdGVyLT5od19pZCkpOwo+IMKgCQlpbnRlbF9yaW5nX2VtaXQoc2lnbmFsbGVyLCAw KTsKPiDCoAl9Cj4gKwlpbnRlbF9yaW5nX2FkdmFuY2Uoc2lnbmFsbGVyKTsKPiDCoAo+IMKgCXJl dHVybiAwOwo+IMKgfQo+IMKgCj4gLXN0YXRpYyBpbnQgZ2VuOF94Y3Nfc2lnbmFsKHN0cnVjdCBk cm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSwKPiAtCQkJwqDCoMKgdW5zaWduZWQg aW50IG51bV9kd29yZHMpCj4gK3N0YXRpYyBpbnQgZ2VuOF94Y3Nfc2lnbmFsKHN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSkKPiDCoHsKPiAtI2RlZmluZSBNQk9YX1VQ REFURV9EV09SRFMgNgo+IMKgCXN0cnVjdCBpbnRlbF9yaW5nICpzaWduYWxsZXIgPSBzaWduYWxs ZXJfcmVxLT5yaW5nOwo+IMKgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHNp Z25hbGxlcl9yZXEtPmk5MTU7Cj4gwqAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqd2FpdGVyOwo+ IEBAIC0xMzc1LDEwICsxMzY5LDcgQEAgc3RhdGljIGludCBnZW44X3hjc19zaWduYWwoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxLAo+IMKgCWludCByZXQsIG51bV9y aW5nczsKPiDCoAo+IMKgCW51bV9yaW5ncyA9IGh3ZWlnaHQzMihJTlRFTF9JTkZPKGRldl9wcml2 KS0+cmluZ19tYXNrKTsKPiAtCW51bV9kd29yZHMgKz0gKG51bV9yaW5ncy0xKSAqIE1CT1hfVVBE QVRFX0RXT1JEUzsKPiAtI3VuZGVmIE1CT1hfVVBEQVRFX0RXT1JEUwo+IC0KPiAtCXJldCA9IGlu dGVsX3JpbmdfYmVnaW4oc2lnbmFsbGVyX3JlcSwgbnVtX2R3b3Jkcyk7Cj4gKwlyZXQgPSBpbnRl bF9yaW5nX2JlZ2luKHNpZ25hbGxlcl9yZXEsIChudW1fcmluZ3MtMSkgKiA2KTsKPiDCoAlpZiAo cmV0KQo+IMKgCQlyZXR1cm4gcmV0Owo+IMKgCj4gQEAgLTE0MDAsMTIgKzEzOTEsMTIgQEAgc3Rh dGljIGludCBnZW44X3hjc19zaWduYWwoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWdu YWxsZXJfcmVxLAo+IMKgCQkJCU1JX1NFTUFQSE9SRV9UQVJHRVQod2FpdGVyLT5od19pZCkpOwo+ IMKgCQlpbnRlbF9yaW5nX2VtaXQoc2lnbmFsbGVyLCAwKTsKPiDCoAl9Cj4gKwlpbnRlbF9yaW5n X2FkdmFuY2Uoc2lnbmFsbGVyKTsKPiDCoAo+IMKgCXJldHVybiAwOwo+IMKgfQo+IMKgCj4gLXN0 YXRpYyBpbnQgZ2VuNl9zaWduYWwoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxs ZXJfcmVxLAo+IC0JCcKgwqDCoMKgwqDCoMKgdW5zaWduZWQgaW50IG51bV9kd29yZHMpCj4gK3N0 YXRpYyBpbnQgZ2VuNl9zaWduYWwoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxs ZXJfcmVxKQo+IMKgewo+IMKgCXN0cnVjdCBpbnRlbF9yaW5nICpzaWduYWxsZXIgPSBzaWduYWxs ZXJfcmVxLT5yaW5nOwo+IMKgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHNp Z25hbGxlcl9yZXEtPmk5MTU7Cj4gQEAgLTE0MTMsMTIgKzE0MDQsOCBAQCBzdGF0aWMgaW50IGdl bjZfc2lnbmFsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqc2lnbmFsbGVyX3JlcSwKPiDC oAllbnVtIGludGVsX2VuZ2luZV9pZCBpZDsKPiDCoAlpbnQgcmV0LCBudW1fcmluZ3M7Cj4gwqAK PiAtI2RlZmluZSBNQk9YX1VQREFURV9EV09SRFMgMwo+IMKgCW51bV9yaW5ncyA9IGh3ZWlnaHQz MihJTlRFTF9JTkZPKGRldl9wcml2KS0+cmluZ19tYXNrKTsKPiAtCW51bV9kd29yZHMgKz0gcm91 bmRfdXAoKG51bV9yaW5ncy0xKSAqIE1CT1hfVVBEQVRFX0RXT1JEUywgMik7Cj4gLSN1bmRlZiBN Qk9YX1VQREFURV9EV09SRFMKPiAtCj4gLQlyZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHNpZ25hbGxl cl9yZXEsIG51bV9kd29yZHMpOwo+ICsJcmV0ID0gaW50ZWxfcmluZ19iZWdpbihzaWduYWxsZXJf cmVxLCByb3VuZF91cCgobnVtX3JpbmdzLTEpICogMywgMikpOwo+IMKgCWlmIChyZXQpCj4gwqAJ CXJldHVybiByZXQ7Cj4gwqAKPiBAQCAtMTQzNiw2ICsxNDIzLDcgQEAgc3RhdGljIGludCBnZW42 X3NpZ25hbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnNpZ25hbGxlcl9yZXEsCj4gwqAJ LyogSWYgbnVtX2R3b3JkcyB3YXMgcm91bmRlZCwgbWFrZSBzdXJlIHRoZSB0YWlsIHBvaW50ZXIg aXMgY29ycmVjdCAqLwo+IMKgCWlmIChudW1fcmluZ3MgJSAyID09IDApCj4gwqAJCWludGVsX3Jp bmdfZW1pdChzaWduYWxsZXIsIE1JX05PT1ApOwo+ICsJaW50ZWxfcmluZ19hZHZhbmNlKHNpZ25h bGxlcik7Cj4gwqAKPiDCoAlyZXR1cm4gMDsKPiDCoH0KPiBAQCAtMTQ1NCwxMSArMTQ0MiwxMyBA QCBzdGF0aWMgaW50IGdlbjZfZW1pdF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVz dCAqcmVxKQo+IMKgCXN0cnVjdCBpbnRlbF9yaW5nICpyaW5nID0gcmVxLT5yaW5nOwo+IMKgCWlu dCByZXQ7Cj4gwqAKPiAtCWlmIChlbmdpbmUtPnNlbWFwaG9yZS5zaWduYWwpCj4gLQkJcmV0ID0g ZW5naW5lLT5zZW1hcGhvcmUuc2lnbmFsKHJlcSwgNCk7Cj4gLQllbHNlCj4gLQkJcmV0ID0gaW50 ZWxfcmluZ19iZWdpbihyZXEsIDQpOwo+ICsJaWYgKGVuZ2luZS0+c2VtYXBob3JlLnNpZ25hbCkg ewo+ICsJCXJldCA9IGVuZ2luZS0+c2VtYXBob3JlLnNpZ25hbChyZXEpOwo+ICsJCWlmIChyZXQp Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gwqAKPiArCXJldCA9IGludGVsX3JpbmdfYmVnaW4o cmVxLCA0KTsKPiDCoAlpZiAocmV0KQo+IMKgCQlyZXR1cm4gcmV0Owo+IMKgCj4gQEAgLTE0Nzks MTAgKzE0NjksMTMgQEAgc3RhdGljIGludCBnZW44X3JlbmRlcl9lbWl0X3JlcXVlc3Qoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEpCj4gwqAJc3RydWN0IGludGVsX3JpbmcgKnJpbmcg PSByZXEtPnJpbmc7Cj4gwqAJaW50IHJldDsKPiDCoAo+IC0JaWYgKGVuZ2luZS0+c2VtYXBob3Jl LnNpZ25hbCkKPiAtCQlyZXQgPSBlbmdpbmUtPnNlbWFwaG9yZS5zaWduYWwocmVxLCA4KTsKPiAt CWVsc2UKPiAtCQlyZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHJlcSwgOCk7Cj4gKwlpZiAoZW5naW5l LT5zZW1hcGhvcmUuc2lnbmFsKSB7Cj4gKwkJcmV0ID0gZW5naW5lLT5zZW1hcGhvcmUuc2lnbmFs KHJlcSk7Cj4gKwkJaWYgKHJldCkKPiArCQkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwlyZXQg PSBpbnRlbF9yaW5nX2JlZ2luKHJlcSwgOCk7Cj4gwqAJaWYgKHJldCkKPiDCoAkJcmV0dXJuIHJl dDsKPiDCoAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVm ZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCBm ZGYwODU0OTVlM2EuLmExMzdmZDIxOGM4MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmgKPiBAQCAtMjc4LDkgKzI3OCw3IEBAIHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3Mgewo+IMKgCQlpbnQJKCpzeW5jX3RvKShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnRv X3JlcSwKPiDCoAkJCQnCoMKgwqBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpmcm9tLAo+IMKgCQkJ CcKgwqDCoHUzMiBzZXFubyk7Cj4gLQkJaW50CSgqc2lnbmFsKShzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKnNpZ25hbGxlcl9yZXEsCj4gLQkJCQnCoMKgLyogbnVtX2R3b3JkcyBuZWVkZWQg YnkgY2FsbGVyICovCj4gLQkJCQnCoMKgdW5zaWduZWQgaW50IG51bV9kd29yZHMpOwo+ICsJCWlu dAkoKnNpZ25hbCkoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpzaWduYWxsZXJfcmVxKTsK PiDCoAl9IHNlbWFwaG9yZTsKPiDCoAo+IMKgCS8qIEV4ZWNsaXN0cyAqLwotLSAKSm9vbmFzIExh aHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0aW9uCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=