Re: [PATCH 33/55] drm/i915: Store owning file on the i915_address_space

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On ma, 2016-07-25 at 18:32 +0100, Chris Wilson wrote:
> -static int __hw_ppgtt_init(struct drm_device *dev, struct i915_hw_ppgtt *ppgtt)
> +static int __hw_ppgtt_init(struct i915_hw_ppgtt *ppgtt,
> +			   struct drm_i915_private *dev_priv)
>  {
> -	ppgtt->base.dev = dev;
> +	ppgtt->base.dev = &dev_priv->drm;
>  
> -	if (INTEL_INFO(dev)->gen < 8)
> +	if (INTEL_INFO(dev_priv)->gen < 8)

INTEL_GEN()

>  		return gen6_ppgtt_init(ppgtt);
>  	else
>  		return gen8_ppgtt_init(ppgtt);
>  
>  struct i915_hw_ppgtt *
> -i915_ppgtt_create(struct drm_device *dev, struct drm_i915_file_private *fpriv)
> +i915_ppgtt_create(struct drm_i915_private *dev_priv,
> +		  struct drm_i915_file_private *fpriv)

While touching, fix the name to file_priv.

>  int i915_ppgtt_init_hw(struct drm_device *dev);
>  void i915_ppgtt_release(struct kref *kref);
> -struct i915_hw_ppgtt *i915_ppgtt_create(struct drm_device *dev,
> +struct i915_hw_ppgtt *i915_ppgtt_create(struct drm_i915_private *dev_priv,
>  					struct drm_i915_file_private *fpriv);

I'd change file_priv again when touching.

>  static inline void i915_ppgtt_get(struct i915_hw_ppgtt *ppgtt)
>  {

Otherwise, looks good.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx