Re: [PATCH 45/55] drm/i915: Convert intel_overlay to request tracking

Chris Wilson
2016-07-27T08:34:59Z

On Wed, Jul 27, 2016 at 09:22:33AM +0100, Chris Wilson wrote:
> On Wed, Jul 27, 2016 at 11:12:32AM +0300, Joonas Lahtinen wrote:
> > > @@ -452,13 +450,9 @@ static int intel_overlay_release_old_vid(struct intel_overlay *overlay)
> > >       intel_overlay_release_old_vid_tail);
> > >   if (ret)
> > >   return ret;
> > > - }
> > > + } else
> > > + intel_overlay_release_old_vid_tail(&overlay->last_flip, NULL);
> >
> > Why you added else?
>
> Habit?

Ah, no. Because on the true branch the release is deferred. On the else
brnach the release is immediate.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre