Re: [PATCH 45/55] drm/i915: Convert intel_overlay to request tracking

Joonas Lahtinen
2016-07-27T10:59:02Z

On ke, 2016-07-27 at 09:22 +0100, Chris Wilson wrote:
> On Wed, Jul 27, 2016 at 11:12:32AM +0300, Joonas Lahtinen wrote:
> >
> > On ma, 2016-07-25 at 18:32 +0100, Chris Wilson wrote:
> > >
> > > -static void intel_overlay_release_old_vid_tail(struct intel_overlay *overlay)
> > > +static void intel_overlay_release_old_vid_tail(struct i915_gem_active *active,
> > > +        struct drm_i915_gem_request *req)
> > >  {
> > > + struct intel_overlay *overlay =
> > > + container_of(active, typeof(*overlay), last_flip);
> > >   struct drm_i915_gem_object *obj = overlay->old_vid_bo;
> > >
> > > + i915_gem_track_fb(obj, NULL,
> > > +   INTEL_FRONTBUFFER_OVERLAY(overlay->crtc->pipe));
> > > +
> > Previously this call was after the below calls and old_vid_bo was
> > always NULL, does this fix a bug?
> Yes.
> https://bugs.freedesktop.org/show_bug.cgi?id=93730
> and a recent one.
>

Maybe link it in headers?

Noticed your another e-mail too,

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation