Re: [PATCH 32/55] drm/i915: Split early global GTT initialisation

Chris Wilson
2016-07-26T07:42:09Z

On Tue, Jul 26, 2016 at 10:08:32AM +0300, Joonas Lahtinen wrote:
> On ma, 2016-07-25 at 18:32 +0100, Chris Wilson wrote:
> > -/**
> > - * i915_gem_init_ggtt - Initialize GEM for Global GTT
> > - * @dev: DRM device
> > - */
> > -void i915_gem_init_ggtt(struct drm_device *dev)
> >
> > +static void init_global_gtt(struct drm_i915_private *dev_priv)
>
> Why not s/global_gtt/ggtt/ for easier grepping.

init_global_vm() so that you don't think it is just about the ggtt.

> > - /*
> > -  * Initialise stolen early so that we may reserve preallocated
> > -  * objects for the BIOS to KMS transition.
> > -  */
> > - ret = i915_gem_init_stolen(dev);
> > - if (ret)
> > - goto out_gtt_cleanup;
> > + ggtt->mappable =
> > + io_mapping_create_wc(ggtt->mappable_base, ggtt->mappable_end);
>
> Splitting between arguments might look leaner.

I much prefer splitting like above.

> Otherwise looks OK, plenty of code motion so not super easy to track.

Looks like it has been a rebase victim.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre