Re: [PATCH 32/55] drm/i915: Split early global GTT initialisation

Chris Wilson
2016-07-27T10:34:32Z

On Wed, Jul 27, 2016 at 01:20:42PM +0300, Joonas Lahtinen wrote:
> On ti, 2016-07-26 at 08:42 +0100, Chris Wilson wrote:
> > On Tue, Jul 26, 2016 at 10:08:32AM +0300, Joonas Lahtinen wrote:
> > >
> > > On ma, 2016-07-25 at 18:32 +0100, Chris Wilson wrote:
> > > >
> > > > -/**
> > > > - * i915_gem_init_ggtt - Initialize GEM for Global GTT
> > > > - * @dev: DRM device
> > > > - */
> > > > -void i915_gem_init_ggtt(struct drm_device *dev)
> > > >
> > > > +static void init_global_gtt(struct drm_i915_private *dev_priv)
> > > Why not s/global_gtt/ggtt/ for easier grepping.
> > init_global_vm() so that you don't think it is just about the ggtt.
>
> Agreed.

I ended up inlining it :|
-Chris

--
Chris Wilson, Intel Open Source Technology Centre