Re: [PATCH 40/55] drm/i915: Refactor blocking waits

Joonas Lahtinen
2016-07-27T10:42:16Z

On ke, 2016-07-27 at 08:07 +0100, Chris Wilson wrote:
> >
> > > +           active = obj->last_read;
> > > +           active_mask = obj->active;
> > >     } else {
> > > -           for (i = 0; i < I915_NUM_ENGINES; i++) {
> > > -                   request = i915_gem_active_peek(&obj->last_read[i],
> > > -                                                  &obj->base.dev->struct_mutex);
> > > -                   if (!request)
> > > -                           continue;
> > > +           active_mask = 1;
> >
> > Wouldn't we have RENDER_RING define for this and other instances?
>
> ?

Defining a mask with first bit set is not very informative, is it?

Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation