From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
David Weinehall <david.weinehall@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Consistent drm_minor use
Date: Tue, 02 Aug 2016 11:06:11 +0300 [thread overview]
Message-ID: <1470125171.4009.5.camel@linux.intel.com> (raw)
In-Reply-To: <20160801190129.GC1585@nuc-i3427.alporthouse.com>
On ma, 2016-08-01 at 20:01 +0100, Chris Wilson wrote:
> On Mon, Aug 01, 2016 at 06:38:54PM +0300, David Weinehall wrote:
> >
> > Use consistent naming for drm_minor, and always use kdev_to_drm_minor()
> > to convert kdev to drm_minor.
> >
> > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
> I would have gone with struct drm_minor *minor, since there is no
> confusion here (and dminor is a note ;)
>
I think depending on if we end up with kdev or dev, then match with
dminor/minor.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-02 8:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 15:38 [PATCH 0/4] Various cleanup David Weinehall
2016-08-01 15:38 ` [PATCH 1/4] drm/i915: Cosmetic fixes in i915_drv.h David Weinehall
2016-08-01 18:54 ` Chris Wilson
2016-08-01 15:38 ` [PATCH 2/4] drm/i915: Consistent struct device naming David Weinehall
2016-08-01 18:57 ` Chris Wilson
2016-08-02 8:03 ` Joonas Lahtinen
2016-08-02 8:44 ` Jani Nikula
2016-08-01 15:38 ` [PATCH 3/4] drm/i915: Consistent drm_minor use David Weinehall
2016-08-01 19:01 ` Chris Wilson
2016-08-02 8:06 ` Joonas Lahtinen [this message]
2016-08-01 15:38 ` [PATCH 4/4] drm/i915: pdev cleanup David Weinehall
2016-08-01 19:03 ` Chris Wilson
2016-08-01 15:58 ` ✗ Ro.CI.BAT: failure for Various cleanup Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470125171.4009.5.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox