* [PATCH] drm/i915: remove redundant fbc warnings
@ 2016-07-05 9:28 Matthew Auld
2016-07-05 10:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-28 18:29 ` [PATCH] " Zanoni, Paulo R
0 siblings, 2 replies; 5+ messages in thread
From: Matthew Auld @ 2016-07-05 9:28 UTC (permalink / raw)
To: intel-gfx
The fbc enabled/active sanity checks are already done in
__intel_fbc_disable so no need to do them again.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/intel_fbc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 067b6f5..e77104d 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -1163,11 +1163,8 @@ void intel_fbc_disable(struct intel_crtc *crtc)
return;
mutex_lock(&fbc->lock);
- if (fbc->crtc == crtc) {
- WARN_ON(!fbc->enabled);
- WARN_ON(fbc->active);
+ if (fbc->crtc == crtc)
__intel_fbc_disable(dev_priv);
- }
mutex_unlock(&fbc->lock);
cancel_work_sync(&fbc->work.work);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✗ Ro.CI.BAT: failure for drm/i915: remove redundant fbc warnings
2016-07-05 9:28 [PATCH] drm/i915: remove redundant fbc warnings Matthew Auld
@ 2016-07-05 10:21 ` Patchwork
2016-08-02 11:05 ` Matthew Auld
2016-07-28 18:29 ` [PATCH] " Zanoni, Paulo R
1 sibling, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-07-05 10:21 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove redundant fbc warnings
URL : https://patchwork.freedesktop.org/series/9509/
State : failure
== Summary ==
Series 9509v1 drm/i915: remove redundant fbc warnings
http://patchwork.freedesktop.org/api/1.0/series/9509/revisions/1/mbox
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-cmd:
pass -> FAIL (ro-byt-n2820)
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-snb-i7-2600)
Test gem_mmap:
Subgroup basic:
incomplete -> PASS (fi-skl-i7-6700k)
Test kms_cursor_legacy:
Subgroup basic-cursor-vs-flip:
dmesg-warn -> PASS (fi-skl-i5-6260u)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b-frame-sequence:
pass -> SKIP (fi-skl-i5-6260u)
Subgroup nonblocking-crc-pipe-c-frame-sequence:
skip -> PASS (fi-skl-i5-6260u)
Subgroup read-crc-pipe-b:
skip -> PASS (fi-skl-i5-6260u)
Subgroup suspend-read-crc-pipe-c:
pass -> SKIP (fi-skl-i5-6260u)
fi-kbl-qkkr total:234 pass:162 dwarn:30 dfail:0 fail:2 skip:40
fi-skl-i5-6260u total:234 pass:204 dwarn:0 dfail:0 fail:2 skip:28
fi-skl-i7-6700k total:234 pass:191 dwarn:0 dfail:1 fail:2 skip:40
fi-snb-i7-2600 total:234 pass:178 dwarn:0 dfail:0 fail:2 skip:54
ro-bdw-i5-5250u total:229 pass:204 dwarn:2 dfail:1 fail:0 skip:22
ro-bdw-i7-5557U total:229 pass:203 dwarn:1 dfail:2 fail:0 skip:23
ro-bdw-i7-5600u total:229 pass:190 dwarn:0 dfail:1 fail:0 skip:38
ro-bsw-n3050 total:229 pass:177 dwarn:0 dfail:1 fail:2 skip:49
ro-byt-n2820 total:229 pass:180 dwarn:0 dfail:1 fail:3 skip:45
ro-hsw-i3-4010u total:229 pass:197 dwarn:0 dfail:1 fail:0 skip:31
ro-hsw-i7-4770r total:229 pass:197 dwarn:0 dfail:1 fail:0 skip:31
ro-ilk-i7-620lm total:229 pass:157 dwarn:0 dfail:1 fail:1 skip:70
ro-ilk1-i5-650 total:224 pass:157 dwarn:0 dfail:1 fail:1 skip:65
ro-ivb-i7-3770 total:229 pass:188 dwarn:0 dfail:1 fail:0 skip:40
ro-skl3-i5-6260u total:229 pass:208 dwarn:1 dfail:1 fail:0 skip:19
ro-snb-i7-2620M total:229 pass:179 dwarn:0 dfail:1 fail:1 skip:48
Results at /archive/results/CI_IGT_test/RO_Patchwork_1413/
0a1ed46 drm-intel-nightly: 2016y-07m-04d-15h-39m-24s UTC integration manifest
b12be8d drm/i915: remove redundant fbc warnings
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: remove redundant fbc warnings
2016-07-05 9:28 [PATCH] drm/i915: remove redundant fbc warnings Matthew Auld
2016-07-05 10:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-07-28 18:29 ` Zanoni, Paulo R
1 sibling, 0 replies; 5+ messages in thread
From: Zanoni, Paulo R @ 2016-07-28 18:29 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Auld, Matthew
Em Ter, 2016-07-05 às 10:28 +0100, Matthew Auld escreveu:
> The fbc enabled/active sanity checks are already done in
> __intel_fbc_disable so no need to do them again.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_fbc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c
> b/drivers/gpu/drm/i915/intel_fbc.c
> index 067b6f5..e77104d 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -1163,11 +1163,8 @@ void intel_fbc_disable(struct intel_crtc
> *crtc)
> return;
>
> mutex_lock(&fbc->lock);
> - if (fbc->crtc == crtc) {
> - WARN_ON(!fbc->enabled);
> - WARN_ON(fbc->active);
> + if (fbc->crtc == crtc)
> __intel_fbc_disable(dev_priv);
> - }
> mutex_unlock(&fbc->lock);
>
> cancel_work_sync(&fbc->work.work);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-02 11:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-05 9:28 [PATCH] drm/i915: remove redundant fbc warnings Matthew Auld
2016-07-05 10:21 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-08-02 11:05 ` Matthew Auld
2016-08-02 11:27 ` Joonas Lahtinen
2016-07-28 18:29 ` [PATCH] " Zanoni, Paulo R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox