From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 11/16] drm/i915: Remove (struct_mutex) locking for busy-ioctl Date: Fri, 05 Aug 2016 10:05:38 +0300 Message-ID: <1470380738.3634.24.camel@linux.intel.com> References: <1470075758-13871-1-git-send-email-chris@chris-wilson.co.uk> <1470075758-13871-12-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 810C46EAF0 for ; Fri, 5 Aug 2016 07:07:43 +0000 (UTC) In-Reply-To: <1470075758-13871-12-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Akash Goel List-Id: intel-gfx@lists.freedesktop.org T24gbWEsIDIwMTYtMDgtMDEgYXQgMTk6MjIgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBC eSBhcHBseWluZyB0aGUgc2FtZSBsb2dpYyBhcyBmb3Igd2FpdC1pb2N0bCwgd2UgY2FuIHF1ZXJ5 IHdoZXRoZXIgYQo+IHJlcXVlc3QgaGFzIGNvbXBsZXRlZCB3aXRob3V0IGhvbGRpbmcgc3RydWN0 X211dGV4LiBUaGUgYmlnZ2VzdCBpbXBhY3QKPiBzeXN0ZW0td2lkZSBpcyByZW1vdmluZyB0aGUg Zmx1c2hfYWN0aXZlIGFuZCB0aGUgY29udGVudGlvbiB0aGF0IGNhdXNlcy4KPiAKPiBUZXN0Y2Fz ZTogaWd0L2dlbV9idXN5Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4gQ2M6IEFrYXNoIEdvZWwgPGFrYXNoLmdvZWxAaW50ZWwuY29tPgo+ IC0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDExMCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwgODAgaW5z ZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g aW5kZXggNDMwNjliMDViZGQyLi5mMmY3MGY1ZmY5ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPiBAQCAtMzcyMSw0OSArMzcyMSw5OSBAQCBpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBp bl92aWV3KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gwqAJaTkxNV92bWFfdW5w aW4oaTkxNV9nZW1fb2JqX3RvX2dndHRfdmlldyhvYmosIHZpZXcpKTsKPiDCoH0KPiDCoAo+ICtz dGF0aWMgX19hbHdheXNfaW5saW5lIHVuc2lnbmVkCj4gK19fYnVzeV9yZWFkX2ZsYWcoY29uc3Qg c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICt7Cj4gKwlyZXR1cm4gMHgx MDAwMCA8PCByZXF1ZXN0LT5lbmdpbmUtPmV4ZWNfaWQ7Cj4gK30KPiArCj4gK3N0YXRpYyBfX2Fs d2F5c19pbmxpbmUgdW5zaWduZWQgaW50Cj4gK19fYnVzeV93cml0ZV9mbGFnKGNvbnN0IHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiArewo+ICsJcmV0dXJuIHJlcXVlc3Qt PmVuZ2luZS0+ZXhlY19pZDsKCkp1c3QgcmVhbGl6ZWQgKHRvIG15IGhvcnJvcikgdGhpcyBpcyBu b3QgYSBmbGFnLCBpdCdzIGEgYmFyZSBJRCwgc28KYmV0dGVyIG5vdCBjYWxsIHRoZSBmdW5jdGlv biBfZmxhZywgYnV0IHJhdGhlciBfaWQ/Cgo+ICt9Cj4gKwo+ICtzdGF0aWMgX19hbHdheXNfaW5s aW5lIHVuc2lnbmVkCj4gK19fYnVzeV9mbGFnKGNvbnN0IHN0cnVjdCBpOTE1X2dlbV9hY3RpdmUg KmFjdGl2ZSwKPiArCcKgwqDCoMKgdW5zaWduZWQgaW50ICgqZmxhZykoY29uc3Qgc3RydWN0IGRy bV9pOTE1X2dlbV9yZXF1ZXN0ICopKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVl c3QgKnJlcXVlc3Q7Cj4gKwo+ICsJcmVxdWVzdCA9IHJjdV9kZXJlZmVyZW5jZShhY3RpdmUtPnJl cXVlc3QpOwo+ICsJaWYgKCFyZXF1ZXN0IHx8IGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHJl cXVlc3QpKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXJldHVybiBmbGFnKHJlcXVlc3QpOwo+ICt9 Cj4gKwo+ICtzdGF0aWMgaW5saW5lIHVuc2lnbmVkCj4gK2J1c3lfcmVhZF9mbGFnKGNvbnN0IHN0 cnVjdCBpOTE1X2dlbV9hY3RpdmUgKmFjdGl2ZSkKPiArewo+ICsJcmV0dXJuIF9fYnVzeV9mbGFn KGFjdGl2ZSwgX19idXN5X3JlYWRfZmxhZyk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxpbmUgdW5z aWduZWQKPiArYnVzeV93cml0ZV9mbGFnKGNvbnN0IHN0cnVjdCBpOTE1X2dlbV9hY3RpdmUgKmFj dGl2ZSkKPiArewo+ICsJcmV0dXJuIF9fYnVzeV9mbGFnKGFjdGl2ZSwgX19idXN5X3dyaXRlX2Zs YWcpOwo+ICt9Cj4gKwo+IMKgaW50Cj4gwqBpOTE1X2dlbV9idXN5X2lvY3RsKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gwqAJCcKgwqDCoMKgc3RydWN0IGRybV9maWxlICpm aWxlKQo+IMKgewo+IMKgCXN0cnVjdCBkcm1faTkxNV9nZW1fYnVzeSAqYXJncyA9IGRhdGE7Cj4g wqAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiAtCWludCByZXQ7Cj4gLQo+IC0J cmV0ID0gaTkxNV9tdXRleF9sb2NrX2ludGVycnVwdGlibGUoZGV2KTsKPiAtCWlmIChyZXQpCj4g LQkJcmV0dXJuIHJldDsKPiArCXVuc2lnbmVkIGxvbmcgYWN0aXZlOwo+IMKgCj4gwqAJb2JqID0g aTkxNV9nZW1fb2JqZWN0X2xvb2t1cChmaWxlLCBhcmdzLT5oYW5kbGUpOwo+IC0JaWYgKCFvYmop IHsKPiAtCQlyZXQgPSAtRU5PRU5UOwo+IC0JCWdvdG8gdW5sb2NrOwo+IC0JfQo+ICsJaWYgKCFv YmopCj4gKwkJcmV0dXJuIC1FTk9FTlQ7Cj4gwqAKPiAtCS8qIENvdW50IGFsbCBhY3RpdmUgb2Jq ZWN0cyBhcyBidXN5LCBldmVuIGlmIHRoZXkgYXJlIGN1cnJlbnRseSBub3QgdXNlZAo+IC0JwqAq IGJ5IHRoZSBncHUuIFVzZXJzIG9mIHRoaXMgaW50ZXJmYWNlIGV4cGVjdCBvYmplY3RzIHRvIGV2 ZW50dWFsbHkKPiAtCcKgKiBiZWNvbWUgbm9uLWJ1c3kgd2l0aG91dCBhbnkgZnVydGhlciBhY3Rp b25zLgo+IC0JwqAqLwo+IMKgCWFyZ3MtPmJ1c3kgPSAwOwo+IC0JaWYgKGk5MTVfZ2VtX29iamVj dF9pc19hY3RpdmUob2JqKSkgewo+IC0JCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx Owo+IC0JCWludCBpOwo+ICsJYWN0aXZlID0gX19JOTE1X0JPX0FDVElWRShvYmopOwo+ICsJaWYg KGFjdGl2ZSkgewo+ICsJCWludCBpZHg7Cj4gwqAKPiAtCQlmb3IgKGkgPSAwOyBpIDwgSTkxNV9O VU1fRU5HSU5FUzsgaSsrKSB7Cj4gLQkJCXJlcSA9IGk5MTVfZ2VtX2FjdGl2ZV9wZWVrKCZvYmot Pmxhc3RfcmVhZFtpXSwKPiAtCQkJCQkJwqDCoMKgJm9iai0+YmFzZS5kZXYtPnN0cnVjdF9tdXRl eCk7Cj4gLQkJCWlmIChyZXEpCj4gLQkJCQlhcmdzLT5idXN5IHw9IDEgPDwgKDE2ICsgcmVxLT5l bmdpbmUtPmV4ZWNfaWQpOwo+IC0JCX0KPiAtCQlyZXEgPSBpOTE1X2dlbV9hY3RpdmVfcGVlaygm b2JqLT5sYXN0X3dyaXRlLAo+IC0JCQkJCcKgwqDCoCZvYmotPmJhc2UuZGV2LT5zdHJ1Y3RfbXV0 ZXgpOwo+IC0JCWlmIChyZXEpCj4gLQkJCWFyZ3MtPmJ1c3kgfD0gcmVxLT5lbmdpbmUtPmV4ZWNf aWQ7Cj4gKwkJLyogWWVzLCB0aGUgbG9va3VwcyBhcmUgaW50ZW50aW9uYWxseSByYWN5Lgo+ICsJ CcKgKgo+ICsJCcKgKiBFdmVuIHRob3VnaCB3ZSBndWFyZCB0aGUgcG9pbnRlciBsb29rdXAgYnkg UkNVLCB0aGF0IG9ubHkKPiArCQnCoCogZ3VhcmFudGVlcyB0aGF0IHRoZSBwb2ludGVyIGFuZCBp dHMgY29udGVudHMgcmVtYWluCj4gKwkJwqAqIGRlcmVmZXJlbmNhYmxlIGFuZCBkb2VzICpub3Qq IG1lYW4gdGhhdCB0aGUgcmVxdWVzdCB3ZQo+ICsJCcKgKiBoYXZlIGlzIHRoZSBzYW1lIGFzIHRo ZSBvbmUgYmVpbmcgdHJhY2tlZCBieSB0aGUgb2JqZWN0Lgo+ICsJCcKgKgo+ICsJCcKgKiBDb25z aWRlciB0aGF0IHdlIGxvb2t1cCB0aGUgcmVxdWVzdCBqdXN0IGFzIGl0IGlzIGJlaW5nCj4gKwkJ wqAqIHJldGlyZWQgYW5kIGZyZWUuIFdlIHRha2UgYSBsb2NhbCBjb3B5IG9mIHRoZSBwb2ludGVy LAoKc3RpbGwgcy9mcmVlL2ZyZWVkLwoKPiArCQnCoCogYnV0IGJlZm9yZSB3ZSBhZGQgaXRzIGVu Z2luZSBpbnRvIHRoZSBidXN5IHNldCwgdGhlIG90aGVyCj4gKwkJwqAqIHRocmVhZCByZWFsbG9j YXRlcyBpdCBhbmQgYXNzaWducyBpdCB0byBhIHRhc2sgb24gYW5vdGhlcgo+ICsJCcKgKiBlbmdp bmUgd2l0aCBhIGZyZXNoIGFuZCBpbmNvbXBsZXRlIHNlcW5vLgo+ICsJCcKgKgo+ICsJCcKgKiBT byBhZnRlciB3ZSBsb29rdXAgdGhlIGVuZ2luZSdzIGlkLCB3ZSBkb3VibGUgY2hlY2sgdGhhdAo+ ICsJCcKgKiB0aGUgYWN0aXZlIHJlcXVlc3QgaXMgdGhlIHNhbWUgYW5kIG9ubHkgdGhlbiBkbyB3 ZSBhZGQgaXQKPiArCQnCoCogaW50byB0aGUgYnVzeSBzZXQuCj4gKwkJwqAqLwo+ICsJCXJjdV9y ZWFkX2xvY2soKTsKPiArCj4gKwkJZm9yX2VhY2hfYWN0aXZlKGFjdGl2ZSwgaWR4KQo+ICsJCQlh cmdzLT5idXN5IHw9IGJ1c3lfcmVhZF9mbGFnKCZvYmotPmxhc3RfcmVhZFtpZHhdKTsKClNvIHlv dSBtZWFuIHRoaXMgaXMgZG91YmxlIGNoZWNrIGFnYWluc3TCoF9fSTkxNV9CT19BQ1RJVkUsIHJp Z2h0PwoKV2UncmUgZ2V0dGluZyB0aGVyZSwgdGhvdWdoLiBXaXRoIGFib3ZlIGZpeGVkOwoKUmV2 aWV3ZWQtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNv bT4KLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpJbnRl bCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK