From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1() Date: Wed, 12 Jul 2017 01:47:25 -0700 Message-ID: <14705705.6BrEU4IqqS@dk> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1499811596-14634-2-git-send-email-jim.bride@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1C7C6E39C for ; Wed, 12 Jul 2017 08:47:27 +0000 (UTC) Received: by mail-pg0-x243.google.com with SMTP id j186so2233780pge.1 for ; Wed, 12 Jul 2017 01:47:27 -0700 (PDT) In-Reply-To: <1499811596-14634-2-git-send-email-jim.bride@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Jani Nikula , Rodrigo Vivi , Paulo Zanoni , Wayne Boyer List-Id: intel-gfx@lists.freedesktop.org T24gVHVlc2RheSwgSnVseSAxMSwgMjAxNyAzOjE5OjUzIFBNIFBEVCBKaW0gQnJpZGUgd3JvdGU6 Cj4gT24gU0tMKyB0aGVyZSBpcyBhIGJpdCBpbiBTUkRfQ1RMIHRoYXQgc29mdHdhcmUgaXMgbm90 IHN1cHBvc2VkIHRvCj4gbW9kaWZ5LCBidXQgd2UgY3VycmVudGx5IGNsb2JiZXIgdGhhdCBiaXQg d2hlbiB3ZSBlbmFibGUgUFNSLiAgSW4KPiBvcmRlciB0byBwcmVzZXJ2ZSB0aGUgdmFsdWUgb2Yg dGhhdCBiaXQsIGdvIGFoZWFkIGFuZCByZWFkIFNSRF9DVEwgCgpBbmQgd2hpY2ggYml0IGlzIHRo YXQ/Cgo+IGFuZAo+IGRvIGEgZmllbGQtd2lzZSBzZXR0aW5nIG9mIHRoZSB2YXJpb3VzIGJpdHMg dGhhdCB3ZSBuZWVkIHRvIGluaXRpYWxpemUKPiBiZWZvcmUgd3JpdGluZyB0aGUgcmVnaXN0ZXIg YmFjayBvdXQuICBBZGRpdGlvbmFsbHksIGdvIGFoZWFkIGFuZAo+IGV4cGxpY2l0bHkgZGlzYWJs ZSBzaW5nbGUtZnJhbWUgdXBkYXRlIHNpbmNlIHdlIGFyZW4ndCBjdXJyZW50bHkKPiBzdXBwb3J0 aW5nIGl0LgoKSSBzZWUgYSBjYWxsZXIgdG8gaW50ZWxfcHNyX3NpbmdsZV9mcmFtZV91cGRhdGUo KSAKCj4gCj4gdjI6ICogRG8gYSBmaWVsZC13aXNlIGluaXQgb24gRURQX1BTUl9NQVhfU0xFRVBf VElNRSBldmVuIHRob3VnaCB3ZQo+ICAgICAgIGFsd2F5cyBzZXQgaXQgdG8gdGhlIG1heCB2YWx1 ZS4gKFJvZHJpZ28pCj4gICAgICogUmViYXNlCj4gCj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KPiBDYzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRl bC5jb20+Cj4gQ2M6IFdheW5lIEJveWVyIDx3YXluZS5ib3llckBpbnRlbC5jb20+Cj4gQ2M6IEph bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFJvZHJpZ28g Vml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKaW0gQnJpZGUg PGppbS5icmlkZUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmggIHwgIDQgKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3Iu YyB8IDIxICsrKysrKysrKysrKysrKysrKystLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcmVnLmgKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggaW5k ZXggYzcxMmQwMS4uM2U2MjQyOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC0z Nzg5LDE4ICszNzg5LDIyIEBAIGVudW0gewo+ICAjZGVmaW5lICAgRURQX1BTUl9NSU5fTElOS19F TlRSWV9USU1FXzRfTElORVMJKDE8PDI1KQo+ICAjZGVmaW5lICAgRURQX1BTUl9NSU5fTElOS19F TlRSWV9USU1FXzJfTElORVMJKDI8PDI1KQo+ICAjZGVmaW5lICAgRURQX1BTUl9NSU5fTElOS19F TlRSWV9USU1FXzBfTElORVMJKDM8PDI1KQo+ICsjZGVmaW5lICAgRURQX1BTUl9NQVhfU0xFRVBf VElNRV9NQVNLICAgICAgICAgICAoMHgxZjw8MjApCj4gICNkZWZpbmUgICBFRFBfUFNSX01BWF9T TEVFUF9USU1FX1NISUZUCQkyMAo+ICAjZGVmaW5lICAgRURQX1BTUl9TS0lQX0FVWF9FWElUCQkJ KDE8PDEyKQo+ICAjZGVmaW5lICAgRURQX1BTUl9UUDFfVFAyX1NFTAkJCSgwPDwxMSkKPiAgI2Rl ZmluZSAgIEVEUF9QU1JfVFAxX1RQM19TRUwJCQkoMTw8MTEpCj4gKyNkZWZpbmUgICBFRFBfUFNS X1RQMl9UUDNfVElNRV9NQVNLICAgICAgICAgICAgICgzPDw4KQo+ICAjZGVmaW5lICAgRURQX1BT Ul9UUDJfVFAzX1RJTUVfNTAwdXMJCSgwPDw4KQo+ICAjZGVmaW5lICAgRURQX1BTUl9UUDJfVFAz X1RJTUVfMTAwdXMJCSgxPDw4KQo+ICAjZGVmaW5lICAgRURQX1BTUl9UUDJfVFAzX1RJTUVfMjUw MHVzCQkoMjw8OCkKPiAgI2RlZmluZSAgIEVEUF9QU1JfVFAyX1RQM19USU1FXzB1cwkJKDM8PDgp Cj4gKyNkZWZpbmUgICBFRFBfUFNSX1RQMV9USU1FX01BU0sgICAgICAgICAgICAgICAgICgweDM8 PDQpCj4gICNkZWZpbmUgICBFRFBfUFNSX1RQMV9USU1FXzUwMHVzCQkoMDw8NCkKPiAgI2RlZmlu ZSAgIEVEUF9QU1JfVFAxX1RJTUVfMTAwdXMJCSgxPDw0KQo+ICAjZGVmaW5lICAgRURQX1BTUl9U UDFfVElNRV8yNTAwdXMJCSgyPDw0KQo+ICAjZGVmaW5lICAgRURQX1BTUl9UUDFfVElNRV8wdXMJ CQkoMzw8NCkKPiArI2RlZmluZSAgIEVEUF9QU1JfSURMRV9GUkFNRV9NQVNLICAgICAgICAgICAg ICAgKDB4Zjw8MCkKPiAgI2RlZmluZSAgIEVEUF9QU1JfSURMRV9GUkFNRV9TSElGVAkJMAo+IAo+ ICAjZGVmaW5lIEVEUF9QU1JfQVVYX0NUTAkJCQlfTU1JTyhkZXZfcHJpdi0+cHNyX21taW9fYmFz ZSArIDB4MTApCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5j Cj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBpbmRleCA1NTlmMWFiLi4xMzI5 ODdiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtMjgwLDE3ICsyODAsMzIg QEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX3NvdXJjZV9wc3IxKHN0cnVjdCBpbnRlbF9kcAo+ ICppbnRlbF9kcCkgKiB3aXRoIHRoZSA1IG9yIDYgaWRsZSBwYXR0ZXJucy4KPiAgCSAqLwo+ICAJ dWludDMyX3QgaWRsZV9mcmFtZXMgPSBtYXgoNiwgZGV2X3ByaXYtPnZidC5wc3IuaWRsZV9mcmFt ZXMpOwo+IC0JdWludDMyX3QgdmFsID0gRURQX1BTUl9FTkFCTEU7Cj4gKwl1aW50MzJfdCB2YWwg PSBJOTE1X1JFQUQoRURQX1BTUl9DVEwpOwo+IAo+ICsJdmFsIHw9IEVEUF9QU1JfRU5BQkxFOwo+ ICsKPiArCXZhbCAmPSB+RURQX1BTUl9NQVhfU0xFRVBfVElNRV9NQVNLOwo+ICAJdmFsIHw9IG1h eF9zbGVlcF90aW1lIDw8IEVEUF9QU1JfTUFYX1NMRUVQX1RJTUVfU0hJRlQ7Cj4gKwo+ICsJdmFs ICY9IH5FRFBfUFNSX0lETEVfRlJBTUVfTUFTSzsKPiAgCXZhbCB8PSBpZGxlX2ZyYW1lcyA8PCBF RFBfUFNSX0lETEVfRlJBTUVfU0hJRlQ7Cj4gCj4gKwl2YWwgJj0gfkVEUF9QU1JfTUlOX0xJTktf RU5UUllfVElNRV9NQVNLOwo+ICAJaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpKQo+ICAJCXZhbCB8 PSBFRFBfUFNSX01JTl9MSU5LX0VOVFJZX1RJTUVfOF9MSU5FUzsKCkVEUF9QU1JfTUlOX0xJTktf RU5UUllfVElNRV84X0xJTkVTIGlzICAoMDw8MjUpIApXZSBjYW4ganVzdCByZW1vdmUgdGhlIHR3 byBsaW5lcyBhYm92ZSwgSSB0aGluayBpdCdzIGp1c3QgbWlzbGVhZGluZyB0byBkbyBhIApub3Ag YWZ0ZXIgY2hlY2tpbmcgZm9yIEhhc3dlbGwuCgpDdXJpb3VzIGhvdyB0aGUgZW50cnkgdGltZSBp cyBkZXRlcm1pbmVkLCB0aGUgcmVzdCBzZWVtIHRvIGNvbWUgZnJvbSBWQlQuCgo+IAo+IC0JaWYg KGRldl9wcml2LT5wc3IubGlua19zdGFuZGJ5KQo+ICsJaWYgKGRldl9wcml2LT5wc3IubGlua19z dGFuZGJ5KSB7Cj4gIAkJdmFsIHw9IEVEUF9QU1JfTElOS19TVEFOREJZOwo+IAo+ICsJCS8qIFNG VSBzaG91bGQgb25seSBiZSBlbmFibGVkIHdpdGggbGluayBzdGFuZGJ5LCBidXQgZm9yCj4gKwkJ ICogbm93IHdlIGRvIG5vdCBzdXBwb3J0IGl0LiAqLwo+ICsJCXZhbCAmPSB+QkRXX1BTUl9TSU5H TEVfRlJBTUU7Cj4gKwl9IGVsc2Ugewo+ICsJCXZhbCAmPSB+RURQX1BTUl9MSU5LX1NUQU5EQlk7 Cj4gKwkJdmFsICY9IH5CRFdfUFNSX1NJTkdMRV9GUkFNRTsKPiArCX0KPiArCj4gKwl2YWwgJj0g fkVEUF9QU1JfVFAxX1RJTUVfTUFTSzsKPiAgCWlmIChkZXZfcHJpdi0+dmJ0LnBzci50cDFfd2Fr ZXVwX3RpbWUgPiA1KQo+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMV9USU1FXzI1MDB1czsKPiAgCWVs c2UgaWYgKGRldl9wcml2LT52YnQucHNyLnRwMV93YWtldXBfdGltZSA+IDEpCj4gQEAgLTMwMCw2 ICszMTUsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9lbmFibGVfc291cmNlX3BzcjEoc3RydWN0IGlu dGVsX2RwCj4gKmludGVsX2RwKSBlbHNlCj4gIAkJdmFsIHw9IEVEUF9QU1JfVFAxX1RJTUVfMHVz Owo+IAo+ICsJdmFsICY9IH5FRFBfUFNSX1RQMl9UUDNfVElNRV9NQVNLOwo+ICAJaWYgKGRldl9w cml2LT52YnQucHNyLnRwMl90cDNfd2FrZXVwX3RpbWUgPiA1KQo+ICAJCXZhbCB8PSBFRFBfUFNS X1RQMl9UUDNfVElNRV8yNTAwdXM7Cj4gIAllbHNlIGlmIChkZXZfcHJpdi0+dmJ0LnBzci50cDJf dHAzX3dha2V1cF90aW1lID4gMSkKPiBAQCAtMzA5LDYgKzMyNSw3IEBAIHN0YXRpYyB2b2lkIGlu dGVsX2VuYWJsZV9zb3VyY2VfcHNyMShzdHJ1Y3QgaW50ZWxfZHAKPiAqaW50ZWxfZHApIGVsc2UK PiAgCQl2YWwgfD0gRURQX1BTUl9UUDJfVFAzX1RJTUVfMHVzOwo+IAo+ICsJdmFsICY9IH5FRFBf UFNSX1RQMV9UUDNfU0VMOwo+ICAJaWYgKGludGVsX2RwX3NvdXJjZV9zdXBwb3J0c19oYnIyKGlu dGVsX2RwKSAmJgo+ICAJICAgIGRybV9kcF90cHMzX3N1cHBvcnRlZChpbnRlbF9kcC0+ZHBjZCkp Cj4gIAkJdmFsIHw9IEVEUF9QU1JfVFAxX1RQM19TRUw7CgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==