From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 06/10] drm/i915: Choose not to evict faultable objects from the GGTT
Date: Fri, 12 Aug 2016 13:50:56 +0300 [thread overview]
Message-ID: <1470999056.3709.48.camel@linux.intel.com> (raw)
In-Reply-To: <1470997701-988-7-git-send-email-chris@chris-wilson.co.uk>
On pe, 2016-08-12 at 11:28 +0100, Chris Wilson wrote:
> @@ -1715,10 +1716,10 @@ int i915_gem_fault(struct vm_area_struct *area, struct vm_fault *vmf)
> goto err_unlock;
> }
>
> - /* Use a partial view if the object is bigger than the aperture. */
> - /* Now pin it into the GTT if needed */
> - vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0,
> - PIN_MAPPABLE | PIN_NONBLOCK);
> + flags = PIN_MAPPABLE;
> + if (obj->base.size > 2 << 20)
Magic number.
> @@ -55,6 +55,9 @@ mark_free(struct i915_vma *vma, struct list_head *unwind)
> if (WARN_ON(!list_empty(&vma->exec_list)))
> return false;
>
> + if (flags & PIN_NOFAULT && vma->obj->fault_mappable)
> + return false;
The flag name is rather counter-intuitive for it describes other VMAs
rather than our new VMA...
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-12 10:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 10:28 Partial VMA fixes Chris Wilson
2016-08-12 10:28 ` [PATCH 01/10] drm/i915: Move map-and-fenceable tracking to the VMA Chris Wilson
2016-08-15 8:03 ` Joonas Lahtinen
2016-08-15 8:14 ` Chris Wilson
2016-08-12 10:28 ` [PATCH 02/10] drm/i915/userptr: Make gup errors stickier Chris Wilson
2016-08-15 11:16 ` Joonas Lahtinen
2016-08-15 15:08 ` Mika Kuoppala
2016-08-15 15:28 ` Chris Wilson
2016-08-16 7:40 ` Mika Kuoppala
2016-08-12 10:28 ` [PATCH 03/10] drm/i915: Move fence tracking from object to vma Chris Wilson
2016-08-15 9:18 ` Joonas Lahtinen
2016-08-15 9:25 ` Chris Wilson
2016-08-15 10:16 ` Joonas Lahtinen
2016-08-15 9:52 ` Chris Wilson
2016-08-12 10:28 ` [PATCH 04/10] drm/i915: Choose partial chunksize based on tile row size Chris Wilson
2016-08-12 10:38 ` Joonas Lahtinen
2016-08-12 10:28 ` [PATCH 05/10] drm/i915: Fix partial GGTT faulting Chris Wilson
2016-08-15 9:29 ` Joonas Lahtinen
2016-08-12 10:28 ` [PATCH 06/10] drm/i915: Choose not to evict faultable objects from the GGTT Chris Wilson
2016-08-12 10:50 ` Joonas Lahtinen [this message]
2016-08-12 11:13 ` Chris Wilson
2016-08-15 10:20 ` Joonas Lahtinen
2016-08-12 10:28 ` [PATCH 07/10] drm/i915: Fallback to using unmappable memory for scanout Chris Wilson
2016-08-15 9:33 ` Joonas Lahtinen
2016-08-12 10:28 ` [PATCH 08/10] drm/i915: Track display alignment on VMA Chris Wilson
2016-08-15 9:38 ` Joonas Lahtinen
2016-08-16 8:40 ` Chris Wilson
2016-08-12 10:28 ` [PATCH 09/10] drm/i915: Bump the inactive MRU tracking for all VMA accessed Chris Wilson
2016-08-15 9:59 ` Joonas Lahtinen
2016-08-15 10:12 ` Chris Wilson
2016-08-15 11:10 ` Joonas Lahtinen
2016-08-12 10:28 ` [PATCH 10/10] drm/i915: Stop discarding GTT cache-domain on unbind vma Chris Wilson
2016-08-15 10:03 ` Joonas Lahtinen
2016-08-12 10:33 ` ✗ Ro.CI.BAT: failure for series starting with [01/10] drm/i915: Move map-and-fenceable tracking to the VMA Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470999056.3709.48.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox