From: deepak.s@linux.intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v3] drm/i915/chv: Set min freq to RPn on CHV.
Date: Fri, 12 Aug 2016 18:46:41 +0530 [thread overview]
Message-ID: <1471007801-86075-1-git-send-email-deepak.s@linux.intel.com> (raw)
In-Reply-To: <20160812063757.GW4329@intel.com>
From: Deepak S <deepak.s@linux.intel.com>
With latest Punit FW, vgg input voltag drop falling to minimum is fixed.
So reverting the WA patch & moving to turbo freq opreation range to [RPn -> RP0]
This is not a 1:1 revert of the commit 5b7c91b78b1ce6663e0f1f037f6cb4d7c9537d44.
You can refer to commit 5b5929cbe3f7 ("drm/i915/chv: remove
pre-production hardware workarounds") as the reason for the discrepancy
commit 5b7c91b78b1ce6663e0f1f037f6cb4d7c9537d44
Author: Deepak S <deepak.s@linux.intel.com>
Date: Sat May 9 18:15:46 2015 +0530
drm/i915/chv: Set min freq to efficient frequency on chv
v2: Fix inconsistent return type. (Chris)
v3: drop pre-production hw case (Ville)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 81ab119..fa80881 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5579,6 +5579,17 @@ static int cherryview_rps_guar_freq(struct drm_i915_private *dev_priv)
return rp1;
}
+static u32 cherryview_rps_min_freq(struct drm_i915_private *dev_priv)
+{
+ u32 val, rpn;
+
+ val = vlv_punit_read(dev_priv, FB_GFX_FMIN_AT_VMIN_FUSE);
+ rpn = ((val >> FB_GFX_FMIN_AT_VMIN_FUSE_SHIFT) &
+ FB_GFX_FREQ_FUSE_MASK);
+
+ return rpn;
+}
+
static int valleyview_rps_guar_freq(struct drm_i915_private *dev_priv)
{
u32 val, rp1;
@@ -5818,8 +5829,7 @@ static void cherryview_init_gt_powersave(struct drm_i915_private *dev_priv)
intel_gpu_freq(dev_priv, dev_priv->rps.rp1_freq),
dev_priv->rps.rp1_freq);
- /* PUnit validated range is only [RPe, RP0] */
- dev_priv->rps.min_freq = dev_priv->rps.efficient_freq;
+ dev_priv->rps.min_freq = cherryview_rps_min_freq(dev_priv);
DRM_DEBUG_DRIVER("min GPU freq: %d MHz (%u)\n",
intel_gpu_freq(dev_priv, dev_priv->rps.min_freq),
dev_priv->rps.min_freq);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-12 7:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 8:50 [PATCH] Revert "drm/i915/chv: Set min freq to efficient frequency on chv" deepak.s
2016-08-12 5:32 ` Chris Wilson
2016-08-12 11:22 ` [PATCH v2] " deepak.s
2016-08-12 6:12 ` kbuild test robot
2016-08-12 6:23 ` Chris Wilson
2016-08-12 7:35 ` Deepak S
2016-08-12 6:14 ` kbuild test robot
2016-08-12 6:35 ` Ville Syrjälä
2016-08-12 6:37 ` Ville Syrjälä
2016-08-12 13:16 ` deepak.s [this message]
2017-02-14 21:28 ` [PATCH v3] drm/i915/chv: Set min freq to RPn on CHV Ville Syrjälä
2016-08-12 7:00 ` [PATCH v2] Revert "drm/i915/chv: Set min freq to efficient frequency on chv" kbuild test robot
2016-08-12 6:03 ` ✗ Fi.CI.BAT: failure for Revert "drm/i915/chv: Set min freq to efficient frequency on chv" (rev2) Patchwork
2016-08-12 6:11 ` ✗ Ro.CI.BAT: " Patchwork
2016-08-12 7:34 ` [PATCH] Revert "drm/i915/chv: Set min freq to efficient frequency on chv" Jani Nikula
2016-08-12 10:33 ` Deepak S
2016-08-12 8:12 ` ✗ Ro.CI.BAT: failure for Revert "drm/i915/chv: Set min freq to efficient frequency on chv" (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471007801-86075-1-git-send-email-deepak.s@linux.intel.com \
--to=deepak.s@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox