Re: [PATCH 09/10] drm/i915: Bump the inactive MRU tracking for all VMA accessed

Joonas Lahtinen
2016-08-15T09:59:12Z

> When we bump the MRU access tracking on set-to-gtt, we need to not only
> bump the primary GGTT VMA but all partials as well. Similarly we want to
> bump the MRU access for when unpinning an object from the scanout.

Refer to the list as LRU in the commit title and message to avoid confusion.

On pe, 2016-08-12 at 11:28 +0100, Chris Wilson wrote:
> +static void i915_gem_object_bump_inactive_ggtt(struct drm_i915_gem_object *obj)
> +{
> + struct i915_vma *vma;
> +
> + list_for_each_entry(vma, &obj->vma_list, obj_link) {
> + if (!i915_vma_is_ggtt(vma))
> + continue;
> +
> + if (i915_vma_is_active(vma))
> + continue;

Could combine these two to one if.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation