Re: [PATCH 03/10] drm/i915: Move fence tracking from object to vma

Chris Wilson
2016-08-15T09:53:00Z

On Mon, Aug 15, 2016 at 12:18:20PM +0300, Joonas Lahtinen wrote:
> On pe, 2016-08-12 at 11:28 +0100, Chris Wilson wrote:
> > @@ -1131,15 +1131,11 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_private *i915,
> >   } else {
> >   node.start = i915_ggtt_offset(vma);
> >   node.allocated = false;
> > - ret = i915_gem_object_put_fence(obj);
> > + ret = i915_vma_put_fence(vma);
> >   if (ret)
> >   goto out_unpin;
> >   }
> >
> > - ret = i915_gem_object_set_to_gtt_domain(obj, true);
> > - if (ret)
> > - goto out_unpin;
> > -
>
> This is a somewhat an unexpected change in here. Care to explain?

Spontaneous disappearance due to rebasing. Pops back into existence
again later!
-Chris

--
Chris Wilson, Intel Open Source Technology Centre