Re: [PATCH RFC 2/4] drm/i915: IOMMU based SVM implementation v13

David Woodhouse
2016-08-15T12:07:17Z

[-- Attachment #1.1: Type: text/plain, Size: 560 bytes --]

On Mon, 2016-08-15 at 14:48 +0300, Mika Kuoppala wrote:
>
>
> +static void i915_svm_fault_cb(struct device *dev, int pasid, u64 addr,
> +                             u32 private, int rwxp, int response)
> +{
> +}
> +
> +static struct svm_dev_ops i915_svm_ops = {
> +       .fault_cb = i915_svm_fault_cb,
> +};
> +

I'd prefer that you don't hook this up unless you need it.

I'd also prefer that you don't need it.

If you need it, nail a hardware designer to a tree before you hook it
up.

--
dwmw2

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5760 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]