From: David Woodhouse <dwmw2@infradead.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH RFC 2/4] drm/i915: IOMMU based SVM implementation v13
Date: Mon, 15 Aug 2016 13:07:12 +0100 [thread overview]
Message-ID: <1471262832.61594.215.camel@infradead.org> (raw)
In-Reply-To: <1471261687-10601-3-git-send-email-mika.kuoppala@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 560 bytes --]
On Mon, 2016-08-15 at 14:48 +0300, Mika Kuoppala wrote:
>
>
> +static void i915_svm_fault_cb(struct device *dev, int pasid, u64 addr,
> + u32 private, int rwxp, int response)
> +{
> +}
> +
> +static struct svm_dev_ops i915_svm_ops = {
> + .fault_cb = i915_svm_fault_cb,
> +};
> +
I'd prefer that you don't hook this up unless you need it.
I'd also prefer that you don't need it.
If you need it, nail a hardware designer to a tree before you hook it
up.
--
dwmw2
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5760 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-15 12:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 11:48 [PATCH RFC 0/4] svm support Mika Kuoppala
2016-08-15 11:48 ` [PATCH RFC 1/4] drm/i915: add create_context2 ioctl Mika Kuoppala
2016-08-15 11:55 ` Chris Wilson
2016-08-15 12:25 ` Mika Kuoppala
2016-08-15 12:56 ` Chris Wilson
2016-08-15 16:25 ` Jesse Barnes
2016-08-15 16:36 ` Chris Wilson
2016-08-15 12:03 ` Joonas Lahtinen
2016-08-15 11:48 ` [PATCH RFC 2/4] drm/i915: IOMMU based SVM implementation v13 Mika Kuoppala
2016-08-15 12:05 ` Chris Wilson
2016-08-15 12:13 ` David Woodhouse
2016-08-15 12:23 ` Chris Wilson
2016-08-15 12:30 ` David Woodhouse
2016-08-15 12:53 ` Chris Wilson
2016-08-15 13:04 ` David Woodhouse
2016-08-15 12:07 ` David Woodhouse [this message]
2016-08-15 11:48 ` [PATCH RFC 3/4] drm/i915: add SVM execbuf ioctl v10 Mika Kuoppala
2016-08-15 12:09 ` Chris Wilson
2016-08-15 12:34 ` Mika Kuoppala
2016-08-15 16:26 ` Jesse Barnes
2016-08-17 9:37 ` Joonas Lahtinen
2016-08-17 14:59 ` Jesse Barnes
2016-08-15 11:48 ` [PATCH RFC 4/4] drm/i915: Add param for SVM Mika Kuoppala
2016-08-15 12:11 ` Chris Wilson
2016-08-15 12:22 ` Mika Kuoppala
2016-08-15 12:24 ` ✗ Ro.CI.BAT: failure for svm support Patchwork
2016-08-15 13:43 ` [PATCH RFC 0/4] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471262832.61594.215.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox