From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Mark up the GTT flush following WC writes as ORIGIN_CPU
Date: Wed, 17 Aug 2016 20:34:34 +0000 [thread overview]
Message-ID: <1471466070.2630.20.camel@intel.com> (raw)
In-Reply-To: <1471458056-24377-1-git-send-email-chris@chris-wilson.co.uk>
Em Qua, 2016-08-17 às 19:20 +0100, Chris Wilson escreveu:
> Similarly to invalidating beforehand, if the object is mmapped via
> I915_MMAP_WC we cannot track writes through the I915_GEM_DOMAIN_GTT.
> At
> the conclusion of the write, i915_gem_object_flush_gtt_writes() we
> also
> need to treat the origin carefully in case it may have been
> untracked.
>
> See also commit aeecc9696aa0 ("drm/i915: use ORIGIN_CPU for
> frontbuffer
> invalidation on WC mmaps").
This patch doesn't apply cleanly to drm-intel-nightly. I reviewed it
based on the current state of my tree, and it makes sense to me, so
unless your tree as super significant changes in this area:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c
> b/drivers/gpu/drm/i915/i915_gem.c
> index 161efa96aeda..d07ff0138deb 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3105,7 +3105,7 @@ i915_gem_object_flush_gtt_write_domain(struct
> drm_i915_gem_object *obj)
> if (INTEL_GEN(dev_priv) >= 6 && !HAS_LLC(dev_priv))
> POSTING_READ(RING_ACTHD(dev_priv-
> >engine[RCS].mmio_base));
>
> - intel_fb_obj_flush(obj, false, ORIGIN_GTT);
> + intel_fb_obj_flush(obj, false, write_origin(obj,
> I915_GEM_DOMAIN_GTT));
>
> obj->base.write_domain = 0;
> trace_i915_gem_object_change_domain(obj,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-17 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 18:20 [PATCH] drm/i915: Mark up the GTT flush following WC writes as ORIGIN_CPU Chris Wilson
2016-08-17 20:34 ` Zanoni, Paulo R [this message]
2016-08-18 5:27 ` ✗ Ro.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471466070.2630.20.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox