public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: libin.yang@linux.intel.com
To: intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com,
	ville.syrjala@linux.intel.com, daniel.vetter@intel.com,
	tiwai@suse.de
Cc: Libin Yang <libin.yang@linux.intel.com>
Subject: [PATCH v4 3/3] drm/i915: HDMI audio gets the TMDS clock by crtc_clock
Date: Thu, 18 Aug 2016 14:42:28 +0800	[thread overview]
Message-ID: <1471502548-137544-4-git-send-email-libin.yang@linux.intel.com> (raw)
In-Reply-To: <1471502548-137544-1-git-send-email-libin.yang@linux.intel.com>

From: Libin Yang <libin.yang@linux.intel.com>

HDMI audio should use crtc_clock to get the TMDS clock.

This patch renames mode to adjusted_mode to unify the name.

Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index da8217c..577e23a 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -162,7 +162,7 @@ static int audio_config_get_n(struct intel_crtc *crtc,
 	if (intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI)) {
 		for (i = 0; i < ARRAY_SIZE(aud_ncts); i++) {
 			if ((rate == aud_ncts[i].sample_rate) &&
-			    (adjusted_mode->clock == aud_ncts[i].clock)) {
+			    (adjusted_mode->crtc_clock == aud_ncts[i].clock)) {
 				return aud_ncts[i].n;
 			}
 		}
@@ -257,8 +257,8 @@ static void audio_m_cts_setup(struct drm_device *dev,
 static bool audio_rate_need_prog(struct intel_crtc *crtc,
 				 const struct drm_display_mode *adjusted_mode)
 {
-	if (((adjusted_mode->clock == TMDS_297M) ||
-		 (adjusted_mode->clock == TMDS_296M)) &&
+	if (((adjusted_mode->crtc_clock == TMDS_297M) ||
+	     (adjusted_mode->crtc_clock == TMDS_296M)) &&
 		intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI))
 		return true;
 	else if (((crtc->config->port_clock == LC_540M) ||
@@ -750,7 +750,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 	struct drm_i915_private *dev_priv = dev_to_i915(dev);
 	struct intel_encoder *intel_encoder;
 	struct intel_crtc *crtc;
-	struct drm_display_mode *mode;
+	struct drm_display_mode *adjusted_mode;
 	struct i915_audio_component *acomp = dev_priv->audio_component;
 	enum pipe pipe = INVALID_PIPE;
 	u32 tmp;
@@ -782,20 +782,20 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 
 	DRM_DEBUG_KMS("pipe %c connects port %c\n",
 				  pipe_name(pipe), port_name(port));
-	mode = &crtc->config->base.adjusted_mode;
+	adjusted_mode = &crtc->config->base.adjusted_mode;
 
 	/* port must be valid now, otherwise the pipe will be invalid */
 	acomp->aud_sample_rate[port] = rate;
 
 	/* 2. check whether to set the N/CTS/M manually or not */
-	if (!audio_rate_need_prog(crtc, mode)) {
+	if (!audio_rate_need_prog(crtc, adjusted_mode)) {
 		tmp = I915_READ(HSW_AUD_CFG(pipe));
 		tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
 		I915_WRITE(HSW_AUD_CFG(pipe), tmp);
 		goto unlock;
 	}
 
-	n = audio_config_get_n(crtc, mode, rate);
+	n = audio_config_get_n(crtc, adjusted_mode, rate);
 	if (n == 0) {
 		DRM_DEBUG_KMS("Using automatic mode for N value on port %c\n",
 					  port_name(port));
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-08-18  6:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  6:42 [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues libin.yang
2016-08-18  6:42 ` [PATCH v4 1/3] drm/i915: set proper N/M in modeset libin.yang
2016-08-18  6:42 ` [PATCH v4 2/3] drm/i915: set proper N/MCTS on more platforms libin.yang
2016-08-18  6:42 ` libin.yang [this message]
2016-08-18  8:29 ` ✗ Ro.CI.BAT: failure for drm/i915: fix some audio support 4K resolution issues Patchwork
2016-08-22  1:15 ` [PATCH v4 0/3] " Yang, Libin
2016-08-24  5:35   ` Yang, Libin
2016-08-24  5:52     ` Daniel Vetter
2016-08-24  6:10       ` Yang, Libin
2016-09-12  3:12     ` Yang, Libin
2016-09-21 18:39       ` Jani Nikula
2016-09-22  5:36         ` Yang, Libin
2016-09-22  5:49           ` Jani Nikula
2016-09-22  7:45             ` Jani Nikula
2016-09-22  7:52               ` Yang, Libin
2016-09-23  5:59               ` Yang, Libin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471502548-137544-4-git-send-email-libin.yang@linux.intel.com \
    --to=libin.yang@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox