[PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[libin.yang]

From: Libin Yang <libin.yang@linux.intel.com>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for dp
    change to use mode->crtc_clock instead of mode->clock
	rename mode to adjusted_mode

v3: add support for 270MHz
    add more platforms support
	use u16 n; u16 m to save the space
	add support for 192KHz, 96KHz, 88.2KHz
	split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
    add support for 176.4KHz
    fix some tiny code style issues
    reset cts to 0 for HDMI mode

Libin Yang (3):
  drm/i915: set proper N/M in modeset
  drm/i915: set proper N/MCTS on more platforms
  drm/i915: HDMI audio gets the TMDS clock by crtc_clock

 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155 +++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)

-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v4 1/3] drm/i915: set proper N/M in modeset

[libin.yang]

From: Libin Yang <libin.yang@linux.intel.com>

When modeset occurs and the LS_CLK is set to some
special values in DP mode, the N/M need to be set
manually if audio is playing. Otherwise the first
several seconds may be silent in audio playback.

The relationship of Maud and Naud is expressed in
the following equation:
Maud/Naud = 512 * fs / f_LS_Clk

Please refer VESA DisplayPort Standard spec for details.

Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 143 +++++++++++++++++++++++++++++++++----
 2 files changed, 136 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index d4adf28..239f0af 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7337,6 +7337,13 @@ enum {
 #define _HSW_AUD_MISC_CTRL_B		0x65110
 #define HSW_AUD_MISC_CTRL(pipe)		_MMIO_PIPE(pipe, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
 
+#define _HSW_AUD_M_CTS_ENABLE_A		0x65028
+#define _HSW_AUD_M_CTS_ENABLE_B		0x65128
+#define HSW_AUD_M_CTS_ENABLE(pipe)		_MMIO_PIPE(pipe, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
+#define   AUD_M_CTS_M_VALUE_INDEX	(1 << 21)
+#define   AUD_M_CTS_M_PROG_ENABLE	(1 << 20)
+#define   AUD_CONFIG_M_MASK		0xfffff
+
 #define _HSW_AUD_DIP_ELD_CTRL_ST_A	0x650b4
 #define _HSW_AUD_DIP_ELD_CTRL_ST_B	0x651b4
 #define HSW_AUD_DIP_ELD_CTRL(pipe)	_MMIO_PIPE(pipe, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 85389cd..a8cec50 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -98,6 +98,38 @@ static const struct {
 	{ 192000, TMDS_297M, 20480, 247500 },
 };
 
+#define LC_540M 540000
+#define LC_270M 270000
+#define LC_162M 162000
+static const struct {
+	int sample_rate;
+	int clock;
+	u16 n;
+	u16 m;
+} aud_nm[] = {
+	{ 192000, LC_540M, 5625, 1024 },
+	{ 176400, LC_540M, 9375, 1568 },
+	{ 96000, LC_540M, 5625, 512 },
+	{ 88200, LC_540M, 9375, 784 },
+	{ 48000, LC_540M, 5625, 256 },
+	{ 44100, LC_540M, 9375, 392 },
+	{ 32000, LC_540M, 16875, 512 },
+	{ 192000, LC_270M, 5625, 2048 },
+	{ 176400, LC_270M, 9375, 3136 },
+	{ 96000, LC_270M, 5625, 1024 },
+	{ 88200, LC_270M, 9375, 1568 },
+	{ 48000, LC_270M, 5625, 512 },
+	{ 44100, LC_270M, 9375, 784 },
+	{ 32000, LC_270M, 16875, 1024 },
+	{ 192000, LC_162M, 3375, 2048 },
+	{ 176400, LC_162M, 5625, 3136 },
+	{ 96000, LC_162M, 3375, 1024 },
+	{ 88200, LC_162M, 5625, 1568 },
+	{ 48000, LC_162M, 3375, 512 },
+	{ 44100, LC_162M, 5625, 784 },
+	{ 32000, LC_162M, 10125, 1024 },
+};
+
 /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */
 static u32 audio_config_hdmi_pixel_clock(const struct drm_display_mode *adjusted_mode)
 {
@@ -121,20 +153,50 @@ static u32 audio_config_hdmi_pixel_clock(const struct drm_display_mode *adjusted
 	return hdmi_audio_clock[i].config;
 }
 
-static int audio_config_get_n(const struct drm_display_mode *mode, int rate)
+static int audio_config_get_n(struct intel_crtc *crtc,
+			      const struct drm_display_mode *adjusted_mode,
+			      int rate)
+{
+	int i;
+
+	if (intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI)) {
+		for (i = 0; i < ARRAY_SIZE(aud_ncts); i++) {
+			if ((rate == aud_ncts[i].sample_rate) &&
+			    (adjusted_mode->clock == aud_ncts[i].clock)) {
+				return aud_ncts[i].n;
+			}
+		}
+	}
+
+	if (intel_crtc_has_dp_encoder(crtc->config)) {
+		for (i = 0; i < ARRAY_SIZE(aud_nm); i++) {
+			if ((rate == aud_nm[i].sample_rate) &&
+			    (crtc->config->port_clock == aud_nm[i].clock)) {
+				return aud_nm[i].n;
+			}
+		}
+	}
+	return 0;
+}
+
+static int audio_config_get_m(struct intel_crtc *crtc, int rate)
 {
 	int i;
 
-	for (i = 0; i < ARRAY_SIZE(aud_ncts); i++) {
-		if ((rate == aud_ncts[i].sample_rate) &&
-			(mode->clock == aud_ncts[i].clock)) {
-			return aud_ncts[i].n;
+	if (intel_crtc_has_dp_encoder(crtc->config)) {
+		for (i = 0; i < ARRAY_SIZE(aud_nm); i++) {
+			if ((rate == aud_nm[i].sample_rate) &&
+			    (crtc->config->port_clock == aud_nm[i].clock)) {
+				return aud_nm[i].m;
+			}
 		}
 	}
+
 	return 0;
 }
 
-static uint32_t audio_config_setup_n_reg(int n, uint32_t val)
+static uint32_t audio_config_setup_n_reg(struct intel_crtc *crtc,
+					 int n, uint32_t val)
 {
 	int n_low, n_up;
 	uint32_t tmp = val;
@@ -145,17 +207,65 @@ static uint32_t audio_config_setup_n_reg(int n, uint32_t val)
 	tmp |= ((n_up << AUD_CONFIG_UPPER_N_SHIFT) |
 			(n_low << AUD_CONFIG_LOWER_N_SHIFT) |
 			AUD_CONFIG_N_PROG_ENABLE);
+	if (intel_crtc_has_dp_encoder(crtc->config))
+		tmp |= AUD_CONFIG_N_VALUE_INDEX;
+	else
+		tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
+	return tmp;
+}
+
+static uint32_t audio_config_setup_m_reg(struct intel_crtc *crtc,
+					 int m, uint32_t val)
+{
+	uint32_t tmp = val;
+
+	tmp &= ~AUD_CONFIG_M_MASK;
+	tmp |= m;
+	tmp |= AUD_M_CTS_M_VALUE_INDEX;
+	tmp |= AUD_M_CTS_M_PROG_ENABLE;
+
 	return tmp;
 }
 
+static void audio_m_cts_setup(struct drm_device *dev,
+			      struct intel_crtc *crtc, int rate)
+{
+	struct drm_i915_private *dev_priv = to_i915(dev);
+	uint32_t tmp, m;
+	/* pipe should be checked in the caller */
+	enum pipe pipe = crtc->pipe;
+
+	if (intel_crtc_has_dp_encoder(crtc->config)) {
+		/* setup m value for DP */
+		m = audio_config_get_m(crtc, rate);
+		if (m == 0)
+			return;
+		tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
+		tmp = audio_config_setup_m_reg(crtc, m, tmp);
+		I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
+	} else {
+		/* clear cts for HDMI */
+		tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
+		tmp &= ~AUD_CONFIG_M_MASK;
+		tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
+		tmp |= AUD_M_CTS_M_PROG_ENABLE;
+		I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
+	}
+}
+
 /* check whether N/CTS/M need be set manually */
 static bool audio_rate_need_prog(struct intel_crtc *crtc,
-				 const struct drm_display_mode *mode)
+				 const struct drm_display_mode *adjusted_mode)
 {
-	if (((mode->clock == TMDS_297M) ||
-		 (mode->clock == TMDS_296M)) &&
+	if (((adjusted_mode->clock == TMDS_297M) ||
+		 (adjusted_mode->clock == TMDS_296M)) &&
 		intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI))
 		return true;
+	else if (((crtc->config->port_clock == LC_540M) ||
+		  (crtc->config->port_clock == LC_270M) ||
+		  (crtc->config->port_clock == LC_162M)) &&
+		  intel_crtc_has_dp_encoder(crtc->config))
+		return true;
 	else
 		return false;
 }
@@ -343,15 +453,17 @@ static void hsw_audio_codec_enable(struct drm_connector *connector,
 			DRM_ERROR("invalid port: %d\n", port);
 			rate = 0;
 		}
-		n = audio_config_get_n(adjusted_mode, rate);
+		n = audio_config_get_n(intel_crtc, adjusted_mode, rate);
 		if (n != 0)
-			tmp = audio_config_setup_n_reg(n, tmp);
+			tmp = audio_config_setup_n_reg(intel_crtc, n, tmp);
 		else
 			DRM_DEBUG_KMS("no suitable N value is found\n");
 	}
 
 	I915_WRITE(HSW_AUD_CFG(pipe), tmp);
 
+	audio_m_cts_setup(connector->dev, intel_crtc, rate);
+
 	mutex_unlock(&dev_priv->av_mutex);
 }
 
@@ -658,7 +770,8 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 	intel_encoder = dev_priv->dig_port_map[port];
 	/* intel_encoder might be NULL for DP MST */
 	if (!intel_encoder || !intel_encoder->base.crtc ||
-	    intel_encoder->type != INTEL_OUTPUT_HDMI) {
+	    ((intel_encoder->type != INTEL_OUTPUT_HDMI) &&
+	     (intel_encoder->type != INTEL_OUTPUT_DP))) {
 		DRM_DEBUG_KMS("no valid port %c\n", port_name(port));
 		err = -ENODEV;
 		goto unlock;
@@ -686,7 +799,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 		goto unlock;
 	}
 
-	n = audio_config_get_n(mode, rate);
+	n = audio_config_get_n(crtc, mode, rate);
 	if (n == 0) {
 		DRM_DEBUG_KMS("Using automatic mode for N value on port %c\n",
 					  port_name(port));
@@ -698,9 +811,11 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 
 	/* 3. set the N/CTS/M */
 	tmp = I915_READ(HSW_AUD_CFG(pipe));
-	tmp = audio_config_setup_n_reg(n, tmp);
+	tmp = audio_config_setup_n_reg(crtc, n, tmp);
 	I915_WRITE(HSW_AUD_CFG(pipe), tmp);
 
+	audio_m_cts_setup(dev_get_drvdata(dev), crtc, pipe);
+
  unlock:
 	mutex_unlock(&dev_priv->av_mutex);
 	i915_audio_component_put_power(dev);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v4 2/3] drm/i915: set proper N/MCTS on more platforms

[libin.yang]

From: Libin Yang <libin.yang@linux.intel.com>

This patch applies setting proper N/M, N/CTS on more platforms.

Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index a8cec50..da8217c 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -757,11 +757,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 	int n;
 	int err = 0;
 
-	/* HSW, BDW, SKL, KBL need this fix */
-	if (!IS_SKYLAKE(dev_priv) &&
-	    !IS_KABYLAKE(dev_priv) &&
-	    !IS_BROADWELL(dev_priv) &&
-	    !IS_HASWELL(dev_priv))
+	if (!HAS_DDI(dev_priv))
 		return 0;
 
 	i915_audio_component_get_power(dev);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v4 3/3] drm/i915: HDMI audio gets the TMDS clock by crtc_clock

[libin.yang]

From: Libin Yang <libin.yang@linux.intel.com>

HDMI audio should use crtc_clock to get the TMDS clock.

This patch renames mode to adjusted_mode to unify the name.

Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index da8217c..577e23a 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -162,7 +162,7 @@ static int audio_config_get_n(struct intel_crtc *crtc,
 	if (intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI)) {
 		for (i = 0; i < ARRAY_SIZE(aud_ncts); i++) {
 			if ((rate == aud_ncts[i].sample_rate) &&
-			    (adjusted_mode->clock == aud_ncts[i].clock)) {
+			    (adjusted_mode->crtc_clock == aud_ncts[i].clock)) {
 				return aud_ncts[i].n;
 			}
 		}
@@ -257,8 +257,8 @@ static void audio_m_cts_setup(struct drm_device *dev,
 static bool audio_rate_need_prog(struct intel_crtc *crtc,
 				 const struct drm_display_mode *adjusted_mode)
 {
-	if (((adjusted_mode->clock == TMDS_297M) ||
-		 (adjusted_mode->clock == TMDS_296M)) &&
+	if (((adjusted_mode->crtc_clock == TMDS_297M) ||
+	     (adjusted_mode->crtc_clock == TMDS_296M)) &&
 		intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI))
 		return true;
 	else if (((crtc->config->port_clock == LC_540M) ||
@@ -750,7 +750,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 	struct drm_i915_private *dev_priv = dev_to_i915(dev);
 	struct intel_encoder *intel_encoder;
 	struct intel_crtc *crtc;
-	struct drm_display_mode *mode;
+	struct drm_display_mode *adjusted_mode;
 	struct i915_audio_component *acomp = dev_priv->audio_component;
 	enum pipe pipe = INVALID_PIPE;
 	u32 tmp;
@@ -782,20 +782,20 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 
 	DRM_DEBUG_KMS("pipe %c connects port %c\n",
 				  pipe_name(pipe), port_name(port));
-	mode = &crtc->config->base.adjusted_mode;
+	adjusted_mode = &crtc->config->base.adjusted_mode;
 
 	/* port must be valid now, otherwise the pipe will be invalid */
 	acomp->aud_sample_rate[port] = rate;
 
 	/* 2. check whether to set the N/CTS/M manually or not */
-	if (!audio_rate_need_prog(crtc, mode)) {
+	if (!audio_rate_need_prog(crtc, adjusted_mode)) {
 		tmp = I915_READ(HSW_AUD_CFG(pipe));
 		tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
 		I915_WRITE(HSW_AUD_CFG(pipe), tmp);
 		goto unlock;
 	}
 
-	n = audio_config_get_n(crtc, mode, rate);
+	n = audio_config_get_n(crtc, adjusted_mode, rate);
 	if (n == 0) {
 		DRM_DEBUG_KMS("Using automatic mode for N value on port %c\n",
 					  port_name(port));
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Ro.CI.BAT: failure for drm/i915: fix some audio support 4K resolution issues

[Patchwork]

== Series Details ==

Series: drm/i915: fix some audio support 4K resolution issues
URL   : https://patchwork.freedesktop.org/series/11252/
State : failure

== Summary ==

Series 11252v1 drm/i915: fix some audio support 4K resolution issues
http://patchwork.freedesktop.org/api/1.0/series/11252/revisions/1/mbox

Test kms_cursor_legacy:
        Subgroup basic-flip-vs-cursor-legacy:
                pass       -> FAIL       (ro-skl3-i5-6260u)
        Subgroup basic-flip-vs-cursor-varying-size:
                fail       -> PASS       (ro-skl3-i5-6260u)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (ro-bdw-i7-5600u)
                skip       -> DMESG-WARN (ro-bdw-i7-5557U)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (ro-bdw-i7-5600u)
                dmesg-warn -> SKIP       (ro-bdw-i7-5557U)
                skip       -> DMESG-WARN (ro-bdw-i5-5250u)

fi-kbl-qkkr      total:244  pass:185  dwarn:29  dfail:0   fail:3   skip:27 
fi-skl-i7-6700k  total:244  pass:208  dwarn:4   dfail:2   fail:2   skip:28 
fi-snb-i7-2600   total:244  pass:202  dwarn:0   dfail:0   fail:0   skip:42 
ro-bdw-i5-5250u  total:240  pass:219  dwarn:2   dfail:0   fail:1   skip:18 
ro-bdw-i7-5557U  total:240  pass:220  dwarn:2   dfail:0   fail:0   skip:18 
ro-bdw-i7-5600u  total:240  pass:205  dwarn:2   dfail:0   fail:1   skip:32 
ro-bsw-n3050     total:240  pass:195  dwarn:0   dfail:0   fail:3   skip:42 
ro-byt-n2820     total:240  pass:198  dwarn:0   dfail:0   fail:2   skip:40 
ro-hsw-i3-4010u  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
ro-hsw-i7-4770r  total:240  pass:185  dwarn:0   dfail:0   fail:0   skip:55 
ro-ilk1-i5-650   total:235  pass:174  dwarn:0   dfail:0   fail:1   skip:60 
ro-ivb-i7-3770   total:240  pass:205  dwarn:0   dfail:0   fail:0   skip:35 
ro-ivb2-i7-3770  total:240  pass:209  dwarn:0   dfail:0   fail:0   skip:31 
ro-skl3-i5-6260u total:240  pass:223  dwarn:0   dfail:0   fail:3   skip:14 

Results at /archive/results/CI_IGT_test/RO_Patchwork_1916/

e45fdef drm-intel-nightly: 2016y-08m-17d-13h-26m-04s UTC integration manifest
af9700f drm/i915: HDMI audio gets the TMDS clock by crtc_clock
db20b11 drm/i915: set proper N/MCTS on more platforms
cc4544f drm/i915: set proper N/M in modeset

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

Any comments?

Regards,
Libin


> -----Original Message-----
> From: libin.yang@linux.intel.com [mailto:libin.yang@linux.intel.com]
> Sent: Thursday, August 18, 2016 2:42 PM
> To: intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com;
> ville.syrjala@linux.intel.com; Vetter, Daniel <daniel.vetter@intel.com>;
> tiwai@suse.de
> Cc: Yang, Libin <libin.yang@intel.com>; Libin Yang
> <libin.yang@linux.intel.com>
> Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> issues
> 
> From: Libin Yang <libin.yang@linux.intel.com>
> 
> changelog:
> v1: initial patches
> 
> v2: change to use crtc->config->port_clock instead of mode->clock for dp
>     change to use mode->crtc_clock instead of mode->clock
> 	rename mode to adjusted_mode
> 
> v3: add support for 270MHz
>     add more platforms support
> 	use u16 n; u16 m to save the space
> 	add support for 192KHz, 96KHz, 88.2KHz
> 	split patch for more platform support separately
> 
> v4: change to use intel_crtc_has_dp_encoder() to support DP MST
>     add support for 176.4KHz
>     fix some tiny code style issues
>     reset cts to 0 for HDMI mode
> 
> Libin Yang (3):
>   drm/i915: set proper N/M in modeset
>   drm/i915: set proper N/MCTS on more platforms
>   drm/i915: HDMI audio gets the TMDS clock by crtc_clock
> 
>  drivers/gpu/drm/i915/i915_reg.h    |   7 ++
>  drivers/gpu/drm/i915/intel_audio.c | 155
> +++++++++++++++++++++++++++++++------
>  2 files changed, 140 insertions(+), 22 deletions(-)
> 
> --
> 1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

Sorry for disturb. Is there any comments for the patches?

Regards,
Libin

> -----Original Message-----
> From: Yang, Libin
> Sent: Monday, August 22, 2016 9:16 AM
> To: libin.yang@linux.intel.com; intel-gfx@lists.freedesktop.org;
> jani.nikula@linux.intel.com; ville.syrjala@linux.intel.com; Vetter, Daniel
> <daniel.vetter@intel.com>; tiwai@suse.de
> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> issues
> 
> Any comments?
> 
> Regards,
> Libin
> 
> 
> > -----Original Message-----
> > From: libin.yang@linux.intel.com [mailto:libin.yang@linux.intel.com]
> > Sent: Thursday, August 18, 2016 2:42 PM
> > To: intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com;
> > ville.syrjala@linux.intel.com; Vetter, Daniel
> > <daniel.vetter@intel.com>; tiwai@suse.de
> > Cc: Yang, Libin <libin.yang@intel.com>; Libin Yang
> > <libin.yang@linux.intel.com>
> > Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> > issues
> >
> > From: Libin Yang <libin.yang@linux.intel.com>
> >
> > changelog:
> > v1: initial patches
> >
> > v2: change to use crtc->config->port_clock instead of mode->clock for dp
> >     change to use mode->crtc_clock instead of mode->clock
> > 	rename mode to adjusted_mode
> >
> > v3: add support for 270MHz
> >     add more platforms support
> > 	use u16 n; u16 m to save the space
> > 	add support for 192KHz, 96KHz, 88.2KHz
> > 	split patch for more platform support separately
> >
> > v4: change to use intel_crtc_has_dp_encoder() to support DP MST
> >     add support for 176.4KHz
> >     fix some tiny code style issues
> >     reset cts to 0 for HDMI mode
> >
> > Libin Yang (3):
> >   drm/i915: set proper N/M in modeset
> >   drm/i915: set proper N/MCTS on more platforms
> >   drm/i915: HDMI audio gets the TMDS clock by crtc_clock
> >
> >  drivers/gpu/drm/i915/i915_reg.h    |   7 ++
> >  drivers/gpu/drm/i915/intel_audio.c | 155
> > +++++++++++++++++++++++++++++++------
> >  2 files changed, 140 insertions(+), 22 deletions(-)
> >
> > --
> > 1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Daniel Vetter]

On Wed, Aug 24, 2016 at 05:35:34AM +0000, Yang, Libin wrote:
> Sorry for disturb. Is there any comments for the patches?

Ville is on vacation, not sure whom else would be a good reviewer from our
side ... Might need to escalate to managers to finding a random reviewer
who first needs to ramp up on hdmi/audio issues.
-Daniel

> 
> Regards,
> Libin
> 
> > -----Original Message-----
> > From: Yang, Libin
> > Sent: Monday, August 22, 2016 9:16 AM
> > To: libin.yang@linux.intel.com; intel-gfx@lists.freedesktop.org;
> > jani.nikula@linux.intel.com; ville.syrjala@linux.intel.com; Vetter, Daniel
> > <daniel.vetter@intel.com>; tiwai@suse.de
> > Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> > issues
> > 
> > Any comments?
> > 
> > Regards,
> > Libin
> > 
> > 
> > > -----Original Message-----
> > > From: libin.yang@linux.intel.com [mailto:libin.yang@linux.intel.com]
> > > Sent: Thursday, August 18, 2016 2:42 PM
> > > To: intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com;
> > > ville.syrjala@linux.intel.com; Vetter, Daniel
> > > <daniel.vetter@intel.com>; tiwai@suse.de
> > > Cc: Yang, Libin <libin.yang@intel.com>; Libin Yang
> > > <libin.yang@linux.intel.com>
> > > Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> > > issues
> > >
> > > From: Libin Yang <libin.yang@linux.intel.com>
> > >
> > > changelog:
> > > v1: initial patches
> > >
> > > v2: change to use crtc->config->port_clock instead of mode->clock for dp
> > >     change to use mode->crtc_clock instead of mode->clock
> > > 	rename mode to adjusted_mode
> > >
> > > v3: add support for 270MHz
> > >     add more platforms support
> > > 	use u16 n; u16 m to save the space
> > > 	add support for 192KHz, 96KHz, 88.2KHz
> > > 	split patch for more platform support separately
> > >
> > > v4: change to use intel_crtc_has_dp_encoder() to support DP MST
> > >     add support for 176.4KHz
> > >     fix some tiny code style issues
> > >     reset cts to 0 for HDMI mode
> > >
> > > Libin Yang (3):
> > >   drm/i915: set proper N/M in modeset
> > >   drm/i915: set proper N/MCTS on more platforms
> > >   drm/i915: HDMI audio gets the TMDS clock by crtc_clock
> > >
> > >  drivers/gpu/drm/i915/i915_reg.h    |   7 ++
> > >  drivers/gpu/drm/i915/intel_audio.c | 155
> > > +++++++++++++++++++++++++++++++------
> > >  2 files changed, 140 insertions(+), 22 deletions(-)
> > >
> > > --
> > > 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

Hi Daniel,

Thanks. Let's wait for Ville back from vacation. :)

Regards,
Libin


> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Wednesday, August 24, 2016 1:53 PM
> To: Yang, Libin <libin.yang@intel.com>
> Cc: 'libin.yang@linux.intel.com' <libin.yang@linux.intel.com>; 'intel-
> gfx@lists.freedesktop.org' <intel-gfx@lists.freedesktop.org>;
> 'jani.nikula@linux.intel.com' <jani.nikula@linux.intel.com>;
> 'ville.syrjala@linux.intel.com' <ville.syrjala@linux.intel.com>; Vetter, Daniel
> <daniel.vetter@intel.com>; 'tiwai@suse.de' <tiwai@suse.de>
> Subject: Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K
> resolution issues
> 
> On Wed, Aug 24, 2016 at 05:35:34AM +0000, Yang, Libin wrote:
> > Sorry for disturb. Is there any comments for the patches?
> 
> Ville is on vacation, not sure whom else would be a good reviewer from our
> side ... Might need to escalate to managers to finding a random reviewer
> who first needs to ramp up on hdmi/audio issues.
> -Daniel
> 
> >
> > Regards,
> > Libin
> >
> > > -----Original Message-----
> > > From: Yang, Libin
> > > Sent: Monday, August 22, 2016 9:16 AM
> > > To: libin.yang@linux.intel.com; intel-gfx@lists.freedesktop.org;
> > > jani.nikula@linux.intel.com; ville.syrjala@linux.intel.com; Vetter,
> > > Daniel <daniel.vetter@intel.com>; tiwai@suse.de
> > > Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K
> > > resolution issues
> > >
> > > Any comments?
> > >
> > > Regards,
> > > Libin
> > >
> > >
> > > > -----Original Message-----
> > > > From: libin.yang@linux.intel.com
> > > > [mailto:libin.yang@linux.intel.com]
> > > > Sent: Thursday, August 18, 2016 2:42 PM
> > > > To: intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com;
> > > > ville.syrjala@linux.intel.com; Vetter, Daniel
> > > > <daniel.vetter@intel.com>; tiwai@suse.de
> > > > Cc: Yang, Libin <libin.yang@intel.com>; Libin Yang
> > > > <libin.yang@linux.intel.com>
> > > > Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K
> > > > resolution issues
> > > >
> > > > From: Libin Yang <libin.yang@linux.intel.com>
> > > >
> > > > changelog:
> > > > v1: initial patches
> > > >
> > > > v2: change to use crtc->config->port_clock instead of mode->clock for
> dp
> > > >     change to use mode->crtc_clock instead of mode->clock
> > > > 	rename mode to adjusted_mode
> > > >
> > > > v3: add support for 270MHz
> > > >     add more platforms support
> > > > 	use u16 n; u16 m to save the space
> > > > 	add support for 192KHz, 96KHz, 88.2KHz
> > > > 	split patch for more platform support separately
> > > >
> > > > v4: change to use intel_crtc_has_dp_encoder() to support DP MST
> > > >     add support for 176.4KHz
> > > >     fix some tiny code style issues
> > > >     reset cts to 0 for HDMI mode
> > > >
> > > > Libin Yang (3):
> > > >   drm/i915: set proper N/M in modeset
> > > >   drm/i915: set proper N/MCTS on more platforms
> > > >   drm/i915: HDMI audio gets the TMDS clock by crtc_clock
> > > >
> > > >  drivers/gpu/drm/i915/i915_reg.h    |   7 ++
> > > >  drivers/gpu/drm/i915/intel_audio.c | 155
> > > > +++++++++++++++++++++++++++++++------
> > > >  2 files changed, 140 insertions(+), 22 deletions(-)
> > > >
> > > > --
> > > > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

Any comments?

Regards,
Libin


> -----Original Message-----
> From: Yang, Libin
> Sent: Wednesday, August 24, 2016 1:36 PM
> To: 'libin.yang@linux.intel.com' <libin.yang@linux.intel.com>; 'intel-
> gfx@lists.freedesktop.org' <intel-gfx@lists.freedesktop.org>;
> 'jani.nikula@linux.intel.com' <jani.nikula@linux.intel.com>;
> 'ville.syrjala@linux.intel.com' <ville.syrjala@linux.intel.com>; Vetter, Daniel
> <daniel.vetter@intel.com>; 'tiwai@suse.de' <tiwai@suse.de>
> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> issues
> 
> Sorry for disturb. Is there any comments for the patches?
> 
> Regards,
> Libin
> 
> > -----Original Message-----
> > From: Yang, Libin
> > Sent: Monday, August 22, 2016 9:16 AM
> > To: libin.yang@linux.intel.com; intel-gfx@lists.freedesktop.org;
> > jani.nikula@linux.intel.com; ville.syrjala@linux.intel.com; Vetter,
> > Daniel <daniel.vetter@intel.com>; tiwai@suse.de
> > Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K
> > resolution issues
> >
> > Any comments?
> >
> > Regards,
> > Libin
> >
> >
> > > -----Original Message-----
> > > From: libin.yang@linux.intel.com [mailto:libin.yang@linux.intel.com]
> > > Sent: Thursday, August 18, 2016 2:42 PM
> > > To: intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com;
> > > ville.syrjala@linux.intel.com; Vetter, Daniel
> > > <daniel.vetter@intel.com>; tiwai@suse.de
> > > Cc: Yang, Libin <libin.yang@intel.com>; Libin Yang
> > > <libin.yang@linux.intel.com>
> > > Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K
> > > resolution issues
> > >
> > > From: Libin Yang <libin.yang@linux.intel.com>
> > >
> > > changelog:
> > > v1: initial patches
> > >
> > > v2: change to use crtc->config->port_clock instead of mode->clock for dp
> > >     change to use mode->crtc_clock instead of mode->clock
> > > 	rename mode to adjusted_mode
> > >
> > > v3: add support for 270MHz
> > >     add more platforms support
> > > 	use u16 n; u16 m to save the space
> > > 	add support for 192KHz, 96KHz, 88.2KHz
> > > 	split patch for more platform support separately
> > >
> > > v4: change to use intel_crtc_has_dp_encoder() to support DP MST
> > >     add support for 176.4KHz
> > >     fix some tiny code style issues
> > >     reset cts to 0 for HDMI mode
> > >
> > > Libin Yang (3):
> > >   drm/i915: set proper N/M in modeset
> > >   drm/i915: set proper N/MCTS on more platforms
> > >   drm/i915: HDMI audio gets the TMDS clock by crtc_clock
> > >
> > >  drivers/gpu/drm/i915/i915_reg.h    |   7 ++
> > >  drivers/gpu/drm/i915/intel_audio.c | 155
> > > +++++++++++++++++++++++++++++++------
> > >  2 files changed, 140 insertions(+), 22 deletions(-)
> > >
> > > --
> > > 1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Jani Nikula]

On Mon, 12 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> Any comments?

Apologies for the way too long delay. I felt it would have been unfair
to ask you to do the changes I thought were necessary after such a
delay, so I sent them as patches... The last one still needs review, but
at least the mundane stuff is out of the way now.

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

Hi Jani,

Thanks a lot for your help on reviewing and refining these patches. I will test your patches and let you know the result.

Regards,
Libin


> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Thursday, September 22, 2016 2:40 AM
> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org' <intel-
> gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
> <ville.syrjala@linux.intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
> 'tiwai@suse.de' <tiwai@suse.de>
> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> issues
> 
> On Mon, 12 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> > Any comments?
> 
> Apologies for the way too long delay. I felt it would have been unfair to ask
> you to do the changes I thought were necessary after such a delay, so I sent
> them as patches... The last one still needs review, but at least the mundane
> stuff is out of the way now.
> 
> https://patchwork.freedesktop.org/series/12754/
> 
> BR,
> Jani.
> 
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Jani Nikula]

On Thu, 22 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> Hi Jani,
>
> Thanks a lot for your help on reviewing and refining these patches. I
> will test your patches and let you know the result.

Thanks. Review is also much appreciated! ;)

BR,
Jani.

>
> Regards,
> Libin
>
>
>> -----Original Message-----
>> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>> Sent: Thursday, September 22, 2016 2:40 AM
>> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
>> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org' <intel-
>> gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
>> <ville.syrjala@linux.intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
>> 'tiwai@suse.de' <tiwai@suse.de>
>> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
>> issues
>> 
>> On Mon, 12 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
>> > Any comments?
>> 
>> Apologies for the way too long delay. I felt it would have been unfair to ask
>> you to do the changes I thought were necessary after such a delay, so I sent
>> them as patches... The last one still needs review, but at least the mundane
>> stuff is out of the way now.
>> 
>> https://patchwork.freedesktop.org/series/12754/
>> 
>> BR,
>> Jani.
>> 
>> 
>> --
>> Jani Nikula, Intel Open Source Technology Center

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Jani Nikula]

On Thu, 22 Sep 2016, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 22 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
>> Hi Jani,
>>
>> Thanks a lot for your help on reviewing and refining these patches. I
>> will test your patches and let you know the result.
>
> Thanks. Review is also much appreciated! ;)

Also #2, please have a look at bug [1], especially the patches and
discussion from comment #26 on.

Thanks,
Jani.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=97442


>
> BR,
> Jani.
>
>>
>> Regards,
>> Libin
>>
>>
>>> -----Original Message-----
>>> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>>> Sent: Thursday, September 22, 2016 2:40 AM
>>> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
>>> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org' <intel-
>>> gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
>>> <ville.syrjala@linux.intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
>>> 'tiwai@suse.de' <tiwai@suse.de>
>>> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
>>> issues
>>> 
>>> On Mon, 12 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
>>> > Any comments?
>>> 
>>> Apologies for the way too long delay. I felt it would have been unfair to ask
>>> you to do the changes I thought were necessary after such a delay, so I sent
>>> them as patches... The last one still needs review, but at least the mundane
>>> stuff is out of the way now.
>>> 
>>> https://patchwork.freedesktop.org/series/12754/
>>> 
>>> BR,
>>> Jani.
>>> 
>>> 
>>> --
>>> Jani Nikula, Intel Open Source Technology Center

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Thursday, September 22, 2016 3:45 PM
> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org' <intel-
> gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
> <ville.syrjala@linux.intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
> 'tiwai@suse.de' <tiwai@suse.de>
> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> issues
> 
> On Thu, 22 Sep 2016, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Thu, 22 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> >> Hi Jani,
> >>
> >> Thanks a lot for your help on reviewing and refining these patches. I
> >> will test your patches and let you know the result.
> >
> > Thanks. Review is also much appreciated! ;)
> 
> Also #2, please have a look at bug [1], especially the patches and discussion
> from comment #26 on.

OK, I will do it tomorrow. Today, I'm busy on DP MST patches.

Regards,
Libin

> 
> Thanks,
> Jani.
> 
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=97442
> 
> 
> >
> > BR,
> > Jani.
> >
> >>
> >> Regards,
> >> Libin
> >>
> >>
> >>> -----Original Message-----
> >>> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> >>> Sent: Thursday, September 22, 2016 2:40 AM
> >>> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
> >>> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org'
> >>> <intel- gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
> >>> <ville.syrjala@linux.intel.com>; Vetter, Daniel
> >>> <daniel.vetter@intel.com>; 'tiwai@suse.de' <tiwai@suse.de>
> >>> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K
> >>> resolution issues
> >>>
> >>> On Mon, 12 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> >>> > Any comments?
> >>>
> >>> Apologies for the way too long delay. I felt it would have been
> >>> unfair to ask you to do the changes I thought were necessary after
> >>> such a delay, so I sent them as patches... The last one still needs
> >>> review, but at least the mundane stuff is out of the way now.
> >>>
> >>> https://patchwork.freedesktop.org/series/12754/
> >>>
> >>> BR,
> >>> Jani.
> >>>
> >>>
> >>> --
> >>> Jani Nikula, Intel Open Source Technology Center
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

[Yang, Libin]

Patches are tested and passed. Thanks.

Regards,
Libin


> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Thursday, September 22, 2016 3:45 PM
> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org' <intel-
> gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
> <ville.syrjala@linux.intel.com>; Vetter, Daniel <daniel.vetter@intel.com>;
> 'tiwai@suse.de' <tiwai@suse.de>
> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution
> issues
> 
> On Thu, 22 Sep 2016, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Thu, 22 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> >> Hi Jani,
> >>
> >> Thanks a lot for your help on reviewing and refining these patches. I
> >> will test your patches and let you know the result.
> >
> > Thanks. Review is also much appreciated! ;)
> 
> Also #2, please have a look at bug [1], especially the patches and discussion
> from comment #26 on.
> 
> Thanks,
> Jani.
> 
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=97442
> 
> 
> >
> > BR,
> > Jani.
> >
> >>
> >> Regards,
> >> Libin
> >>
> >>
> >>> -----Original Message-----
> >>> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> >>> Sent: Thursday, September 22, 2016 2:40 AM
> >>> To: Yang, Libin <libin.yang@intel.com>; 'libin.yang@linux.intel.com'
> >>> <libin.yang@linux.intel.com>; 'intel-gfx@lists.freedesktop.org'
> >>> <intel- gfx@lists.freedesktop.org>; 'ville.syrjala@linux.intel.com'
> >>> <ville.syrjala@linux.intel.com>; Vetter, Daniel
> >>> <daniel.vetter@intel.com>; 'tiwai@suse.de' <tiwai@suse.de>
> >>> Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K
> >>> resolution issues
> >>>
> >>> On Mon, 12 Sep 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
> >>> > Any comments?
> >>>
> >>> Apologies for the way too long delay. I felt it would have been
> >>> unfair to ask you to do the changes I thought were necessary after
> >>> such a delay, so I sent them as patches... The last one still needs
> >>> review, but at least the mundane stuff is out of the way now.
> >>>
> >>> https://patchwork.freedesktop.org/series/12754/
> >>>
> >>> BR,
> >>> Jani.
> >>>
> >>>
> >>> --
> >>> Jani Nikula, Intel Open Source Technology Center
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx