From: Carlos Santa <carlos.santa@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] x86, build: Set -fno-pic for 32/64-bit kernels
Date: Fri, 19 Aug 2016 16:39:08 -0700 [thread overview]
Message-ID: <1471649948.3743.1.camel@graypixels> (raw)
In-Reply-To: <1471648997-26976-1-git-send-email-carlos.santa@intel.com>
On Fri, 2016-08-19 at 16:23 -0700, Carlos Santa wrote:
> Make the -fno-pic compiler flag common for both 32 and 64 bit kernels.
> The GCC toolchain in Android still enables -fpic by default
> causing the build to break.
>
> Signed-off-by: Carlos Santa <carlos.santa@intel.com>
Wrong version, please disregard this patch.
> ---
> arch/x86/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 830ed39..17af5e1 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -49,6 +49,10 @@ endif
> KBUILD_CFLAGS += -mno-sse -mno-mmx -mno-sse2 -mno-3dnow
> KBUILD_CFLAGS += $(call cc-option,-mno-avx,)
>
> +# Never want PIC in both 32/64-bit kernel, prevent breakage with GCC built
> +# with nonstandard options
> +KBUILD_CFLAGS += -fno-pic
> +
> ifeq ($(CONFIG_X86_32),y)
> BITS := 32
> UTS_MACHINE := i386
> @@ -60,10 +64,6 @@ ifeq ($(CONFIG_X86_32),y)
>
> KBUILD_CFLAGS += -msoft-float -mregparm=3 -freg-struct-return
>
> - # Never want PIC in a 32-bit kernel, prevent breakage with GCC built
> - # with nonstandard options
> - KBUILD_CFLAGS += -fno-pic
> -
> # prevent gcc from keeping the stack 16 byte aligned
> KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=2)
>
thanks,
Carlos Santa
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-08-19 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 23:23 [PATCH] x86, build: Set -fno-pic for 32/64-bit kernels Carlos Santa
2016-08-19 23:39 ` Carlos Santa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471649948.3743.1.camel@graypixels \
--to=carlos.santa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox