Re: [PATCH 15/17] drm/i915: Wait upon userptr get-user-pages within execbuffer

Chris Wilson
2016-08-23T11:14:50Z

On Tue, Aug 23, 2016 at 01:53:09PM +0300, Joonas Lahtinen wrote:
> On ma, 2016-08-22 at 09:03 +0100, Chris Wilson wrote:
> > @@ -4471,7 +4471,9 @@ int i915_gem_init(struct drm_device *dev)
> >    */
> >   intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
> >
> > - i915_gem_init_userptr(dev_priv);
> > + ret = i915_gem_init_userptr(dev_priv);
> > + if (ret)
> > + goto out_unlock;
>
> Don't we need a new teardown label after successful
> i915_gem_init_userptr()?

The entire function is devoid of local cleanup. Oh well.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre