Re: [PATCH 16/17] drm/i915: Remove superfluous i915_add_request_no_flush() helper

Joonas Lahtinen
2016-08-23T10:21:14Z

On ma, 2016-08-22 at 09:03 +0100, Chris Wilson wrote:
> The only time we need to emit a flush inside request emission is after
> an execbuffer, for which we can use the full __i915_add_request(). All
> other instances want the simpler i915_add_request() without flushing, so
> remove the useless helper.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

I'd probably make the title more like "Rename i915_add_request_no_flush
to i915_add_request", to make it less likely there are trouble when
somebody is rebasing.

Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation