public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: robert.foss@collabora.com
To: intel-gfx@lists.freedesktop.org, mesa-dev@lists.freedesktop.org,
	Gustavo Padovan <gustavo.padovan@collabora.com>,
	Daniel Stone <daniels@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Marius Vlad <marius.c.vlad@intel.com>
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [PATCH v1 02/13] tests/sw_sync: Add sw_sync test
Date: Tue, 23 Aug 2016 13:56:04 -0400	[thread overview]
Message-ID: <1471974975-11531-3-git-send-email-robert.foss@collabora.com> (raw)
In-Reply-To: <1471974975-11531-1-git-send-email-robert.foss@collabora.com>

From: Robert Foss <robert.foss@collabora.com>

Add initial tests for sw_sync.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 lib/sw_sync.c          | 13 ++++++-------
 lib/sw_sync.h          |  2 +-
 tests/Makefile.sources |  1 +
 tests/sw_sync.c        | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 59 insertions(+), 8 deletions(-)
 create mode 100644 tests/sw_sync.c

diff --git a/lib/sw_sync.c b/lib/sw_sync.c
index c4e7d07..e3d5f85 100644
--- a/lib/sw_sync.c
+++ b/lib/sw_sync.c
@@ -150,8 +150,6 @@ int sw_sync_wait(int fence, int timeout)
 
 	ret = poll(&fds, 1, timeout);
 
-	sw_sync_fd_close(fence);
-
 	return ret;
 }
 
@@ -179,9 +177,10 @@ static struct sync_file_info *sync_file_info(int fd)
 		info->num_fences = num_fences;
 
 		fence_info = calloc(num_fences, sizeof(struct sync_fence_info));
-		if (!fence_info)
+		if (!fence_info) {
 			free(info);
 			return NULL;
+		}
 
 		info->sync_fence_info = (uint64_t)(unsigned long) (fence_info);
 
@@ -217,18 +216,18 @@ int sw_sync_fence_size(int fd)
 	return count;
 }
 
-int sw_sync_fence_count_with_status(int fd, int status)
+int sw_sync_fence_count_status(int fd, int status)
 {
 	int i, count = 0;
-	struct sync_fence_info *fenceInfo = NULL;
+	struct sync_fence_info *fence_info = NULL;
 	struct sync_file_info *info = sync_file_info(fd);
 
 	if (!info)
 		return -1;
 
-	fenceInfo = (struct sync_fence_info *)(uintptr_t)info->sync_fence_info;
+	fence_info = (struct sync_fence_info *)(uintptr_t)info->sync_fence_info;
 	for (i = 0 ; i < info->num_fences ; i++) {
-		if (fenceInfo[i].status == status)
+		if (fence_info[i].status == status)
 			count++;
 	}
 
diff --git a/lib/sw_sync.h b/lib/sw_sync.h
index b179adf..1092608 100644
--- a/lib/sw_sync.h
+++ b/lib/sw_sync.h
@@ -43,7 +43,7 @@ void sw_sync_timeline_inc(int fd, uint32_t count);
 int sw_sync_merge(int fd1, int fd2);
 int sw_sync_wait(int fence, int timeout);
 int sw_sync_fence_size(int fd);
-int sw_sync_fence_count_with_status(int fd, int status);
+int sw_sync_fence_count_status(int fd, int status);
 
 #endif
 
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 72a58ad..0ba769f 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -125,6 +125,7 @@ TESTS_progs_M = \
 	prime_mmap_kms \
 	prime_self_import \
 	prime_vgem \
+	sw_sync \
 	template \
 	vgem_basic \
 	vgem_slow \
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
new file mode 100644
index 0000000..d2d4c42
--- /dev/null
+++ b/tests/sw_sync.c
@@ -0,0 +1,51 @@
+/*
+ * Copyright 2012 Google, Inc
+ * Copyright © 2016 Collabora, Ltd.
+ *
+ * Based on the implementation from the Android Open Source Project
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Robert Foss <robert.foss@collabora.com>
+ */
+
+#include <stdint.h>
+
+#include "sw_sync.h"
+#include "igt.h"
+#include "igt_aux.h"
+
+IGT_TEST_DESCRIPTION("Test SW Sync Framework");
+
+static void test_alloc_timeline(void)
+{
+	int timeline;
+
+	timeline = sw_sync_timeline_create();
+	sw_sync_timeline_destroy(timeline);
+}
+
+igt_main
+{
+	igt_subtest("alloc_timeline")
+		test_alloc_timeline();
+}
+
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-08-23 17:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 17:56 [PATCH v1 00/13] Implement sw_sync test robert.foss
2016-08-23 17:56 ` [PATCH v1 01/13] lib/sw_sync: Add helper functions for managing synchronization primitives robert.foss
2016-08-23 22:05   ` [Mesa-dev] " Eric Engestrom
2016-08-23 17:56 ` robert.foss [this message]
2016-08-23 22:12   ` [Mesa-dev] [PATCH v1 02/13] tests/sw_sync: Add sw_sync test Eric Engestrom
2016-08-23 17:56 ` [PATCH v1 03/13] tests/sw_sync: Add subtest test_alloc_fence robert.foss
2016-08-23 17:56 ` [PATCH v1 04/13] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline robert.foss
2016-08-23 17:56 ` [PATCH v1 05/13] tests/sw_sync: Add subtest test_alloc_merge_fence robert.foss
2016-08-23 17:56 ` [PATCH v1 06/13] tests/sw_sync: Add subtest test_sync_wait robert.foss
2016-08-23 17:56 ` [PATCH v1 07/13] tests/sw_sync: Add subtest test_sync_merge robert.foss
2016-08-23 17:56 ` [PATCH v1 08/13] tests/sw_sync: Add subtest test_sync_merge_same robert.foss
2016-08-23 17:56 ` [PATCH v1 09/13] tests/sw_sync: Add subtest test_sync_multi_consumer robert.foss
2016-08-23 17:56 ` [PATCH v1 10/13] tests/sw_sync: Add subtest test_sync_multi_consumer_producer robert.foss
2016-08-23 17:56 ` [PATCH v1 11/13] tests/sw_sync: Add subtest test_sync_random_merge robert.foss
2016-08-23 22:38   ` Eric Engestrom
2016-08-23 17:56 ` [PATCH v1 12/13] tests/sw_sync: Add subtest test_sync_multi_timeline_wait robert.foss
2016-08-23 17:56 ` [PATCH v1 13/13] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer robert.foss
2016-08-23 22:56 ` [Mesa-dev] [PATCH v1 00/13] Implement sw_sync test Eric Engestrom
2016-08-24 20:27   ` Robert Foss
2016-08-24  6:01 ` Daniel Vetter
2016-08-24 13:51   ` Robert Foss
2016-08-24 20:41   ` Gustavo Padovan
2016-08-25  6:56     ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2016-08-23 17:53 robert.foss
2016-08-23 17:53 ` [PATCH v1 02/13] tests/sw_sync: Add " robert.foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471974975-11531-3-git-send-email-robert.foss@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=gustavo.padovan@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.c.vlad@intel.com \
    --cc=mesa-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox