From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt 1/2] igt: Add test case for EXEC_OBJECT_ASYNC
Date: Wed, 31 Aug 2016 16:07:55 +0300 [thread overview]
Message-ID: <1472648875.3710.13.camel@linux.intel.com> (raw)
In-Reply-To: <20160830100027.7613-1-chris@chris-wilson.co.uk>
On ti, 2016-08-30 at 11:00 +0100, Chris Wilson wrote:
> +static void store_dword(int fd, unsigned ring,
> + uint32_t target, uint32_t offset, uint32_t value)
> +{
I'd prefer a library function (as you obviously copied this from
gem_exec_store.c), as we have more similar functions (with more or less
features) in other tests. Some of them are not even using hardcoded
magic numbers.
Adding as TODO for future.
Other than that,
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
This not need be a "basic" test?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-08-31 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 10:00 [PATCH igt 1/2] igt: Add test case for EXEC_OBJECT_ASYNC Chris Wilson
2016-08-30 10:00 ` [PATCH igt 2/2] igt: Add exerciser for execbuf fence-out <-> fence-in Chris Wilson
2016-09-01 13:20 ` Joonas Lahtinen
2016-08-31 13:07 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472648875.3710.13.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox