From: Lyude <cpaul@redhat.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/8] SKL/KBL watermark fixes
Date: Wed, 07 Sep 2016 19:54:10 -0400 [thread overview]
Message-ID: <1473292450.22966.16.camel@redhat.com> (raw)
In-Reply-To: <1473209539-6689-1-git-send-email-paulo.r.zanoni@intel.com>
For patches 6-8:
Reviewed-by: Lyude <cpaul@redhat.com>
On Tue, 2016-09-06 at 21:52 -0300, Paulo Zanoni wrote:
> Hi
>
> This series is the result of me comparing the code against BSpec. It
> doesn't solve any particular problem I was seeing, but there's enough
> changes that this code could potentially change the watermarks values
> for most machines. Maybe this will fix somebody's underrun? Even if
> it
> doesn't, we should still have a code that matches the specification
> unless there's a big justification.
>
> I still didn't finish reviewing everything and there's at least one
> workaround that we seem to be missing, but let's try to get these
> patches merged first.
>
> Thanks,
> Paulo
>
> Cc: Lyude <cpaul@redhat.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Mahesh Kumar <mahesh1.kumar@intel.com>
>
> Paulo Zanoni (8):
> drm/i915: SAGV is not SKL-only, so rename a few things
> drm/i915: introduce intel_has_sagv()
> drm/i915/kbl: KBL also needs to run the SAGV code
> drm/i915/gen9: fix the WaWmMemoryReadLatency implementation
> drm/i915/gen9: minimum scanlines for Y tile is not always 4
> drm/i915/gen9: fix plane_blocks_per_line on watermarks calculations
> drm/i915/gen9: fix the watermark res_blocks value
> drm/i915/gen9: implement missing case for SKL watermarks
> calculation
>
> drivers/gpu/drm/i915/i915_drv.h | 10 +-
> drivers/gpu/drm/i915/intel_display.c | 9 +-
> drivers/gpu/drm/i915/intel_drv.h | 6 +-
> drivers/gpu/drm/i915/intel_pm.c | 177 ++++++++++++++++++++-----
> ----------
> 4 files changed, 111 insertions(+), 91 deletions(-)
>
--
Cheers,
Lyude
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-09-07 23:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 0:52 [PATCH 0/8] SKL/KBL watermark fixes Paulo Zanoni
2016-09-07 0:52 ` [PATCH 1/8] drm/i915: SAGV is not SKL-only, so rename a few things Paulo Zanoni
2016-09-07 16:05 ` Lyude
2016-09-09 20:16 ` Zanoni, Paulo R
2016-09-07 0:52 ` [PATCH 2/8] drm/i915: introduce intel_has_sagv() Paulo Zanoni
2016-09-07 16:12 ` Lyude
2016-09-08 8:59 ` Jani Nikula
2016-09-08 14:43 ` Lyude Paul
2016-09-09 8:06 ` Jani Nikula
2016-09-09 19:51 ` Zanoni, Paulo R
2016-09-10 10:49 ` Ville Syrjälä
2016-09-12 9:48 ` Jani Nikula
2016-09-07 0:52 ` [PATCH 3/8] drm/i915/kbl: KBL also needs to run the SAGV code Paulo Zanoni
2016-09-07 16:11 ` Ville Syrjälä
2016-09-07 16:17 ` Lyude
2016-09-13 19:34 ` Zanoni, Paulo R
2016-09-14 9:59 ` Jani Nikula
2016-09-14 13:32 ` Zanoni, Paulo R
2016-09-15 7:15 ` Jani Nikula
2016-09-07 0:52 ` [PATCH 4/8] drm/i915/gen9: fix the WaWmMemoryReadLatency implementation Paulo Zanoni
2016-09-13 12:28 ` Maarten Lankhorst
2016-09-07 0:52 ` [PATCH 5/8] drm/i915/gen9: minimum scanlines for Y tile is not always 4 Paulo Zanoni
2016-09-07 23:03 ` Lyude
2016-09-13 20:22 ` Zanoni, Paulo R
2016-09-07 0:52 ` [PATCH 6/8] drm/i915/gen9: fix plane_blocks_per_line on watermarks calculations Paulo Zanoni
2016-09-07 0:52 ` [PATCH 7/8] drm/i915/gen9: fix the watermark res_blocks value Paulo Zanoni
2016-09-07 0:52 ` [PATCH 8/8] drm/i915/gen9: implement missing case for SKL watermarks calculation Paulo Zanoni
2016-09-07 1:24 ` ✗ Fi.CI.BAT: warning for SKL/KBL watermark fixes Patchwork
2016-09-07 23:54 ` Lyude [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473292450.22966.16.camel@redhat.com \
--to=cpaul@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).